| Message ID | 20250410153106.4146265-6-sakari.ailus@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | Update last busy timestamp in Runtime PM autosuspend callbacks | expand |
Hi Sakari, Thank you for the patch. On Thu, Apr 10, 2025 at 06:31:04PM +0300, Sakari Ailus wrote: > Set device's last busy timestamp to current time in > pm_runtime_autosuspend(). > > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Documentation/power/runtime_pm.rst | 15 ++++++--------- > include/linux/pm_runtime.h | 9 ++++++--- > 2 files changed, 12 insertions(+), 12 deletions(-) > > diff --git a/Documentation/power/runtime_pm.rst b/Documentation/power/runtime_pm.rst > index 9c21c913f9cf..39a0b62f6648 100644 > --- a/Documentation/power/runtime_pm.rst > +++ b/Documentation/power/runtime_pm.rst > @@ -154,11 +154,9 @@ suspending the device are satisfied) and to queue up a suspend request for the > device in that case. If there is no idle callback, or if the callback returns > 0, then the PM core will attempt to carry out a runtime suspend of the device, > also respecting devices configured for autosuspend. In essence this means a > -call to pm_runtime_autosuspend() (do note that drivers needs to update the > -device last busy mark, pm_runtime_mark_last_busy(), to control the delay under > -this circumstance). To prevent this (for example, if the callback routine has > -started a delayed suspend), the routine must return a non-zero value. Negative > -error return codes are ignored by the PM core. > +call to pm_runtime_autosuspend(). To prevent this (for example, if the callback > +routine has started a delayed suspend), the routine must return a non-zero > +value. Negative error return codes are ignored by the PM core. > > The helper functions provided by the PM core, described in Section 4, guarantee > that the following constraints are met with respect to runtime PM callbacks for > @@ -330,10 +328,9 @@ drivers/base/power/runtime.c and include/linux/pm_runtime.h: > 'power.disable_depth' is different from 0 > > `int pm_runtime_autosuspend(struct device *dev);` > - - same as pm_runtime_suspend() except that the autosuspend delay is taken > - `into account;` if pm_runtime_autosuspend_expiration() says the delay has > - not yet expired then an autosuspend is scheduled for the appropriate time > - and 0 is returned > + - same as pm_runtime_suspend() except that a call to > + pm_runtime_mark_last_busy() is made and an autosuspend is scheduled for > + the appropriate time and 0 is returned > > `int pm_runtime_resume(struct device *dev);` > - execute the subsystem-level resume callback for the device; returns 0 on > diff --git a/include/linux/pm_runtime.h b/include/linux/pm_runtime.h > index e26caf2c0552..3d12cfb0bf00 100644 > --- a/include/linux/pm_runtime.h > +++ b/include/linux/pm_runtime.h > @@ -375,11 +375,13 @@ static inline int pm_runtime_suspend(struct device *dev) > } > > /** > - * pm_runtime_autosuspend - Set up autosuspend of a device or suspend it. > + * pm_runtime_autosuspend - Update the last access time and set up autosuspend > + * of a device. > * @dev: Target device. > * > - * Set up autosuspend of @dev or suspend it (depending on whether or not > - * autosuspend is enabled for it) without engaging its "idle check" callback. > + * First update the last access time, then set up autosuspend of @dev or suspend > + * it (depending on whether or not autosuspend is enabled for it) without > + * engaging its "idle check" callback. > * > * Return: > * * 0: Success. > @@ -395,6 +397,7 @@ static inline int pm_runtime_suspend(struct device *dev) > */ > static inline int pm_runtime_autosuspend(struct device *dev) > { > + pm_runtime_mark_last_busy(dev); > return __pm_runtime_suspend(dev, RPM_AUTO); > } >
diff --git a/Documentation/power/runtime_pm.rst b/Documentation/power/runtime_pm.rst index 9c21c913f9cf..39a0b62f6648 100644 --- a/Documentation/power/runtime_pm.rst +++ b/Documentation/power/runtime_pm.rst @@ -154,11 +154,9 @@ suspending the device are satisfied) and to queue up a suspend request for the device in that case. If there is no idle callback, or if the callback returns 0, then the PM core will attempt to carry out a runtime suspend of the device, also respecting devices configured for autosuspend. In essence this means a -call to pm_runtime_autosuspend() (do note that drivers needs to update the -device last busy mark, pm_runtime_mark_last_busy(), to control the delay under -this circumstance). To prevent this (for example, if the callback routine has -started a delayed suspend), the routine must return a non-zero value. Negative -error return codes are ignored by the PM core. +call to pm_runtime_autosuspend(). To prevent this (for example, if the callback +routine has started a delayed suspend), the routine must return a non-zero +value. Negative error return codes are ignored by the PM core. The helper functions provided by the PM core, described in Section 4, guarantee that the following constraints are met with respect to runtime PM callbacks for @@ -330,10 +328,9 @@ drivers/base/power/runtime.c and include/linux/pm_runtime.h: 'power.disable_depth' is different from 0 `int pm_runtime_autosuspend(struct device *dev);` - - same as pm_runtime_suspend() except that the autosuspend delay is taken - `into account;` if pm_runtime_autosuspend_expiration() says the delay has - not yet expired then an autosuspend is scheduled for the appropriate time - and 0 is returned + - same as pm_runtime_suspend() except that a call to + pm_runtime_mark_last_busy() is made and an autosuspend is scheduled for + the appropriate time and 0 is returned `int pm_runtime_resume(struct device *dev);` - execute the subsystem-level resume callback for the device; returns 0 on diff --git a/include/linux/pm_runtime.h b/include/linux/pm_runtime.h index e26caf2c0552..3d12cfb0bf00 100644 --- a/include/linux/pm_runtime.h +++ b/include/linux/pm_runtime.h @@ -375,11 +375,13 @@ static inline int pm_runtime_suspend(struct device *dev) } /** - * pm_runtime_autosuspend - Set up autosuspend of a device or suspend it. + * pm_runtime_autosuspend - Update the last access time and set up autosuspend + * of a device. * @dev: Target device. * - * Set up autosuspend of @dev or suspend it (depending on whether or not - * autosuspend is enabled for it) without engaging its "idle check" callback. + * First update the last access time, then set up autosuspend of @dev or suspend + * it (depending on whether or not autosuspend is enabled for it) without + * engaging its "idle check" callback. * * Return: * * 0: Success. @@ -395,6 +397,7 @@ static inline int pm_runtime_suspend(struct device *dev) */ static inline int pm_runtime_autosuspend(struct device *dev) { + pm_runtime_mark_last_busy(dev); return __pm_runtime_suspend(dev, RPM_AUTO); }
Set device's last busy timestamp to current time in pm_runtime_autosuspend(). Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com> --- Documentation/power/runtime_pm.rst | 15 ++++++--------- include/linux/pm_runtime.h | 9 ++++++--- 2 files changed, 12 insertions(+), 12 deletions(-)