diff mbox series

[v2,03/17] arm64: dts: microchip: sparx5: Fix CPU node "enable-method" property dependencies

Message ID 20250410-dt-cpu-schema-v2-3-63d7dc9ddd0a@kernel.org
State New
Headers show
Series Arm cpu schema clean-ups | expand

Commit Message

Rob Herring (Arm) April 10, 2025, 3:47 p.m. UTC 
The "spin-table" enable-method requires "cpu-release-addr" property,
so add a dummy entry. It is assumed the bootloader will fill in the
correct values.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
Tested-by: Daniel Machon <daniel.machon@microchip.com>
---
 arch/arm64/boot/dts/microchip/sparx5_pcb_common.dtsi | 2 ++
 1 file changed, 2 insertions(+)

Comments

Conor Dooley April 11, 2025, 4:21 p.m. UTC | #1 
On Thu, Apr 10, 2025 at 10:47:24AM -0500, Rob Herring (Arm) wrote:
> The "spin-table" enable-method requires "cpu-release-addr" property,
> so add a dummy entry. It is assumed the bootloader will fill in the
> correct values.
> 
> Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
> Tested-by: Daniel Machon <daniel.machon@microchip.com>

This is already applied, guess I forgot to merge it into the branch that
appears in linux next. I'll do that now..
Rob Herring (Arm) April 11, 2025, 8:26 p.m. UTC | #2 
On Fri, Apr 11, 2025 at 11:22 AM Conor Dooley <conor@kernel.org> wrote:
>
> On Thu, Apr 10, 2025 at 10:47:24AM -0500, Rob Herring (Arm) wrote:
> > The "spin-table" enable-method requires "cpu-release-addr" property,
> > so add a dummy entry. It is assumed the bootloader will fill in the
> > correct values.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
> > Reviewed-by: Daniel Machon <daniel.machon@microchip.com>
> > Tested-by: Daniel Machon <daniel.machon@microchip.com>
>
> This is already applied, guess I forgot to merge it into the branch that
> appears in linux next. I'll do that now..

Sometimes I check next, but in this case I just looked at replies for
which there were none. I dislike submitting dts changes because it's a
range of AWOL maintainers, only applying around some rcN (so up to 2
months later), silently applying, and applied but never in linux-next
(until in soc tree).

Rob
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/microchip/sparx5_pcb_common.dtsi b/arch/arm64/boot/dts/microchip/sparx5_pcb_common.dtsi
index 32bb76b3202a..83bf5c81b5f7 100644
--- a/arch/arm64/boot/dts/microchip/sparx5_pcb_common.dtsi
+++ b/arch/arm64/boot/dts/microchip/sparx5_pcb_common.dtsi
@@ -12,10 +12,12 @@  &psci {
 
 &cpu0 {
 	enable-method = "spin-table";
+	cpu-release-addr = /bits/ 64 <0>;
 };
 
 &cpu1 {
 	enable-method = "spin-table";
+	cpu-release-addr = /bits/ 64 <0>;
 };
 
 &uart0 {