| Message ID | 20250409095633.33653-1-skb99@linux.ibm.com |
|---|---|
| State | New |
| Headers | show |
| Series | selftests/bpf: Fix bpf_nf selftest failure | expand |
Hello: This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko <andrii@kernel.org>: On Wed, 9 Apr 2025 15:26:33 +0530 you wrote: > For systems with missing iptables-legacy tool, this selftest fails. > > Add check to find if iptables-legacy tool is available and skip the > test if the tool is missing. > > Fixes: de9c8d848d90 ("selftests/bpf: S/iptables/iptables-legacy/ in the bpf_nf and xdp_synproxy test") > Signed-off-by: Saket Kumar Bhaskar <skb99@linux.ibm.com> > > [...] Here is the summary with links: - selftests/bpf: Fix bpf_nf selftest failure https://git.kernel.org/bpf/bpf-next/c/967e8def1100 You are awesome, thank you!
diff --git a/tools/testing/selftests/bpf/prog_tests/bpf_nf.c b/tools/testing/selftests/bpf/prog_tests/bpf_nf.c index dbd13f8e42a7..dd6512fa652b 100644 --- a/tools/testing/selftests/bpf/prog_tests/bpf_nf.c +++ b/tools/testing/selftests/bpf/prog_tests/bpf_nf.c @@ -63,6 +63,12 @@ static void test_bpf_nf_ct(int mode) .repeat = 1, ); + if (SYS_NOFAIL("iptables-legacy --version")) { + fprintf(stdout, "Missing required iptables-legacy tool\n"); + test__skip(); + return; + } + skel = test_bpf_nf__open_and_load(); if (!ASSERT_OK_PTR(skel, "test_bpf_nf__open_and_load")) return;
For systems with missing iptables-legacy tool, this selftest fails. Add check to find if iptables-legacy tool is available and skip the test if the tool is missing. Fixes: de9c8d848d90 ("selftests/bpf: S/iptables/iptables-legacy/ in the bpf_nf and xdp_synproxy test") Signed-off-by: Saket Kumar Bhaskar <skb99@linux.ibm.com> --- tools/testing/selftests/bpf/prog_tests/bpf_nf.c | 6 ++++++ 1 file changed, 6 insertions(+)