| Message ID | 20250409193429.346501-1-Ashish.Kalra@amd.com |
|---|---|
| State | New |
| Headers | show |
| Series | crypto: ccp: Fix __sev_snp_shutdown_locked() | expand |
On 4/9/25 14:34, Ashish Kalra wrote: > From: Ashish Kalra <ashish.kalra@amd.com> > > Fix smatch warning: > drivers/crypto/ccp/sev-dev.c:1755 __sev_snp_shutdown_locked() > error: uninitialized symbol 'dfflush_error'. > > Fixes: 9770b428b1a2 ("crypto: ccp - Move dev_info/err messages for SEV/SNP init and shutdown") > Reported-by: Dan Carpenter <dan.carpenter@linaro.org> > Closes: https://lore.kernel.org/linux-crypto/d9c2e79c-e26e-47b7-8243-ff6e7b101ec3@stanley.mountain/ > Signed-off-by: Ashish Kalra <ashish.kalra@amd.com> Acked-by: Tom Lendacky <thomas.lendacky@amd.com> > --- > drivers/crypto/ccp/sev-dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c > index 19fb51558a7d..1ccff5e3f4bc 100644 > --- a/drivers/crypto/ccp/sev-dev.c > +++ b/drivers/crypto/ccp/sev-dev.c > @@ -1744,7 +1744,7 @@ static int __sev_snp_shutdown_locked(int *error, bool panic) > ret = __sev_do_cmd_locked(SEV_CMD_SNP_SHUTDOWN_EX, &data, error); > /* SHUTDOWN may require DF_FLUSH */ > if (*error == SEV_RET_DFFLUSH_REQUIRED) { > - int dfflush_error; > + int dfflush_error = SEV_RET_NO_FW_CALL; > > ret = __sev_do_cmd_locked(SEV_CMD_SNP_DF_FLUSH, NULL, &dfflush_error); > if (ret) {
diff --git a/drivers/crypto/ccp/sev-dev.c b/drivers/crypto/ccp/sev-dev.c index 19fb51558a7d..1ccff5e3f4bc 100644 --- a/drivers/crypto/ccp/sev-dev.c +++ b/drivers/crypto/ccp/sev-dev.c @@ -1744,7 +1744,7 @@ static int __sev_snp_shutdown_locked(int *error, bool panic) ret = __sev_do_cmd_locked(SEV_CMD_SNP_SHUTDOWN_EX, &data, error); /* SHUTDOWN may require DF_FLUSH */ if (*error == SEV_RET_DFFLUSH_REQUIRED) { - int dfflush_error; + int dfflush_error = SEV_RET_NO_FW_CALL; ret = __sev_do_cmd_locked(SEV_CMD_SNP_DF_FLUSH, NULL, &dfflush_error); if (ret) {