| Message ID | 20250406201017.47727-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | Accepted |
| Commit | e760c4024eae35b8a6714444dbc995a4c0b20403 |
| Headers | show |
| Series | [1/2] Bluetooth: btmrvl_sdio: Fix wakeup source leaks on device unbind | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=950265 ---Test result--- Test Summary: CheckPatch PENDING 0.27 seconds GitLint PENDING 0.20 seconds SubjectPrefix PASS 0.22 seconds BuildKernel PASS 26.16 seconds CheckAllWarning PASS 27.32 seconds CheckSparse PASS 30.67 seconds BuildKernel32 PASS 24.68 seconds TestRunnerSetup PASS 438.72 seconds TestRunner_l2cap-tester PASS 23.41 seconds TestRunner_iso-tester PASS 35.17 seconds TestRunner_bnep-tester PASS 4.78 seconds TestRunner_mgmt-tester PASS 122.06 seconds TestRunner_rfcomm-tester PASS 10.97 seconds TestRunner_sco-tester PASS 12.61 seconds TestRunner_ioctl-tester PASS 8.36 seconds TestRunner_mesh-tester PASS 6.35 seconds TestRunner_smp-tester PASS 7.24 seconds TestRunner_userchan-tester PASS 4.94 seconds IncrementalBuild PENDING 0.65 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
Hello: This series was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Sun, 6 Apr 2025 22:10:16 +0200 you wrote: > Device can be unbound or probe can fail, so driver must also release > memory for the wakeup source. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > drivers/bluetooth/btmrvl_sdio.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Here is the summary with links: - [1/2] Bluetooth: btmrvl_sdio: Fix wakeup source leaks on device unbind https://git.kernel.org/bluetooth/bluetooth-next/c/e760c4024eae - [2/2] Bluetooth: btmtksdio: Fix wakeup source leaks on device unbind https://git.kernel.org/bluetooth/bluetooth-next/c/0be454533788 You are awesome, thank you!
diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c index 07cd308f7abf..93932a0d8625 100644 --- a/drivers/bluetooth/btmrvl_sdio.c +++ b/drivers/bluetooth/btmrvl_sdio.c @@ -100,7 +100,9 @@ static int btmrvl_sdio_probe_of(struct device *dev, } /* Configure wakeup (enabled by default) */ - device_init_wakeup(dev, true); + ret = devm_device_init_wakeup(dev); + if (ret) + return dev_err_probe(dev, ret, "Failed to init wakeup\n"); } }
Device can be unbound or probe can fail, so driver must also release memory for the wakeup source. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/bluetooth/btmrvl_sdio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)