| Message ID | 20250331072311.3987967-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/1] ACPI: VIOT: Remove (explicitly) unused header | expand |
On Mon, Mar 31, 2025 at 10:23:11AM +0300, Andy Shevchenko wrote: > The fwnode.h is not supposed to be used by the drivers as it > has the definitions for the core parts for different device > property provider implementations. Drop it. > > Note, that fwnode API for drivers is provided in property.h > which is included here. Any comments? Can it be applied?
On Mon, Mar 31, 2025 at 10:23:11AM +0300, Andy Shevchenko wrote: > The fwnode.h is not supposed to be used by the drivers as it > has the definitions for the core parts for different device > property provider implementations. Drop it. > > Note, that fwnode API for drivers is provided in property.h > which is included here. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org> > --- > drivers/acpi/viot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/acpi/viot.c b/drivers/acpi/viot.c > index 2aa69a2fba73..c13a20365c2c 100644 > --- a/drivers/acpi/viot.c > +++ b/drivers/acpi/viot.c > @@ -19,11 +19,11 @@ > #define pr_fmt(fmt) "ACPI: VIOT: " fmt > > #include <linux/acpi_viot.h> > -#include <linux/fwnode.h> > #include <linux/iommu.h> > #include <linux/list.h> > #include <linux/pci.h> > #include <linux/platform_device.h> > +#include <linux/property.h> > > struct viot_iommu { > /* Node offset within the table */ > -- > 2.47.2 >
On Fri, May 2, 2025 at 5:15 PM Jean-Philippe Brucker <jean-philippe@linaro.org> wrote: > > On Mon, Mar 31, 2025 at 10:23:11AM +0300, Andy Shevchenko wrote: > > The fwnode.h is not supposed to be used by the drivers as it > > has the definitions for the core parts for different device > > property provider implementations. Drop it. > > > > Note, that fwnode API for drivers is provided in property.h > > which is included here. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org> > > > --- > > drivers/acpi/viot.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/acpi/viot.c b/drivers/acpi/viot.c > > index 2aa69a2fba73..c13a20365c2c 100644 > > --- a/drivers/acpi/viot.c > > +++ b/drivers/acpi/viot.c > > @@ -19,11 +19,11 @@ > > #define pr_fmt(fmt) "ACPI: VIOT: " fmt > > > > #include <linux/acpi_viot.h> > > -#include <linux/fwnode.h> > > #include <linux/iommu.h> > > #include <linux/list.h> > > #include <linux/pci.h> > > #include <linux/platform_device.h> > > +#include <linux/property.h> > > > > struct viot_iommu { > > /* Node offset within the table */ > > -- Applied as 6.16 material, thanks!
diff --git a/drivers/acpi/viot.c b/drivers/acpi/viot.c index 2aa69a2fba73..c13a20365c2c 100644 --- a/drivers/acpi/viot.c +++ b/drivers/acpi/viot.c @@ -19,11 +19,11 @@ #define pr_fmt(fmt) "ACPI: VIOT: " fmt #include <linux/acpi_viot.h> -#include <linux/fwnode.h> #include <linux/iommu.h> #include <linux/list.h> #include <linux/pci.h> #include <linux/platform_device.h> +#include <linux/property.h> struct viot_iommu { /* Node offset within the table */
The fwnode.h is not supposed to be used by the drivers as it has the definitions for the core parts for different device property provider implementations. Drop it. Note, that fwnode API for drivers is provided in property.h which is included here. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/acpi/viot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)