Message ID | 20250401084749.175246-4-oneukum@suse.com |
---|---|
State | Superseded |
Headers | show
Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 346CE1EB1AF for <linux-usb@vger.kernel.org>; Tue, 1 Apr 2025 08:47:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743497280; cv=none; b=Z/jPGxHTO802rL1cCzPkLSOUKjqtBuHUxeyGPrvn2GQqhT3opUGxFgNTgb5ZxeM2oxTDNowov+fqOtYGufsCgI+/RmEsJjNHcFzTMIOYroVinbOdKIPuBDLnM/BnmmgsGpfmKTDfxsGqVNeaytpjd+PTxpVXMviVzKnRjePayzU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743497280; c=relaxed/simple; bh=YGcbHkt9eFpSEQOn+JlWmpSRXYfydlDZmE8XHbwBf3I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=d/R4ubfR06mZdW0QmN2Jx7TN6RU3VNAw2+sepvlHCz//0xdjtyRP1UutaZkBbbJLcmTdA/FZURcLl/9pqLaB2wO3jU0VirEc5YXnIk2zHIOXyc5n4VlDWbxKL59ZfJx3Ci27NLjr8TQZZ9innlnuUdw/7gQ3a3AUby8quykd48g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=k37MAJKZ; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b=k37MAJKZ; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="k37MAJKZ"; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="k37MAJKZ" Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 9A892211E8; Tue, 1 Apr 2025 08:47:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1743497271; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vojwZpSclVawxe5kq+1eROdzfpvhdcPhUWVb2RnGyOU=; b=k37MAJKZ+dFnP2uOPfvM6EdsWx4N7JQ9/M39bCdN0Jmk+iqnZlTMJI8WsjFpxBg24C0HW4 IzEUVLX9XL72WIoAl1ZijAA6wj0kV/yfP3DlNbvOEgNQ86rl9jhtxWlP3gknUVqpHjJ+Qz +FDmoXyq+B99aN9gqMpDb/Tl3XClq1o= Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1743497271; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vojwZpSclVawxe5kq+1eROdzfpvhdcPhUWVb2RnGyOU=; b=k37MAJKZ+dFnP2uOPfvM6EdsWx4N7JQ9/M39bCdN0Jmk+iqnZlTMJI8WsjFpxBg24C0HW4 IzEUVLX9XL72WIoAl1ZijAA6wj0kV/yfP3DlNbvOEgNQ86rl9jhtxWlP3gknUVqpHjJ+Qz +FDmoXyq+B99aN9gqMpDb/Tl3XClq1o= Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7071713A50; Tue, 1 Apr 2025 08:47:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id oHVNGjeo62cRcQAAD6G6ig (envelope-from <oneukum@suse.com>); Tue, 01 Apr 2025 08:47:51 +0000 From: Oliver Neukum <oneukum@suse.com> To: gregkh@linuxfoundation.org, bjorn@mork.no, loic.poulain@linaro.org, linux-usb@vger.kernel.org, netdev@vger.kernel.org Cc: Oliver Neukum <oneukum@suse.com> Subject: [PATCHv2 3/4] USB: wdm: wdm_wwan_port_tx_complete mutex in atomic context Date: Tue, 1 Apr 2025 10:45:40 +0200 Message-ID: <20250401084749.175246-4-oneukum@suse.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250401084749.175246-1-oneukum@suse.com> References: <20250401084749.175246-1-oneukum@suse.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: <linux-usb.vger.kernel.org> List-Subscribe: <mailto:linux-usb+subscribe@vger.kernel.org> List-Unsubscribe: <mailto:linux-usb+unsubscribe@vger.kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -6.80 X-Spamd-Result: default: False [-6.80 / 50.00]; REPLY(-4.00)[]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_MISSING_CHARSET(0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; TO_DN_SOME(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; DKIM_SIGNED(0.00)[suse.com:s=susede1]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[] X-Spam-Flag: NO X-Spam-Level: |
Series |
USB: wdm: fix WWAN integration issue
|
expand
|
diff --git a/drivers/usb/class/cdc-wdm.c b/drivers/usb/class/cdc-wdm.c index 355627982343..8b99db506b71 100644 --- a/drivers/usb/class/cdc-wdm.c +++ b/drivers/usb/class/cdc-wdm.c @@ -881,7 +881,7 @@ static void wdm_wwan_port_tx_complete(struct urb *urb) struct sk_buff *skb = urb->context; struct wdm_device *desc = skb_shinfo(skb)->destructor_arg; - usb_autopm_put_interface(desc->intf); + usb_autopm_put_interface_async(desc->intf); wwan_port_txon(desc->wwanp); kfree_skb(skb); }
wdm_wwan_port_tx_complete is called from a completion handler with irqs disabled and possible in IRQ context usb_autopm_put_interface can take a mutex. Hence usb_autopm_put_interface_async must be used. Fixes: cac6fb015f71 ("usb: class: cdc-wdm: WWAN framework integration") Signed-off-by: Oliver Neukum <oneukum@suse.com> --- drivers/usb/class/cdc-wdm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)