| Message ID | 20250327031600.99723-1-hui.wang@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: imx: Return NULL if no group is matched and found | expand |
On Thu, Mar 27, 2025 at 11:16:00AM +0800, Hui Wang wrote: > Currently if no group is matched and found, this function will return > the last grp to the caller, this is not expected, it is supposed to > return NULL in this case. > > Fixes: e566fc11ea76 ("pinctrl: imx: use generic pinctrl helpers for managing groups") > Signed-off-by: Hui Wang <hui.wang@canonical.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> > --- > drivers/pinctrl/freescale/pinctrl-imx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c > index 842a1e6cbfc4..18de31328540 100644 > --- a/drivers/pinctrl/freescale/pinctrl-imx.c > +++ b/drivers/pinctrl/freescale/pinctrl-imx.c > @@ -37,16 +37,16 @@ static inline const struct group_desc *imx_pinctrl_find_group_by_name( > struct pinctrl_dev *pctldev, > const char *name) > { > - const struct group_desc *grp = NULL; > + const struct group_desc *grp; > int i; > > for (i = 0; i < pctldev->num_groups; i++) { > grp = pinctrl_generic_get_group(pctldev, i); > if (grp && !strcmp(grp->grp.name, name)) > - break; > + return grp; > } > > - return grp; > + return NULL; > } > > static void imx_pin_dbg_show(struct pinctrl_dev *pctldev, struct seq_file *s, > -- > 2.34.1 >
diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c index 842a1e6cbfc4..18de31328540 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx.c +++ b/drivers/pinctrl/freescale/pinctrl-imx.c @@ -37,16 +37,16 @@ static inline const struct group_desc *imx_pinctrl_find_group_by_name( struct pinctrl_dev *pctldev, const char *name) { - const struct group_desc *grp = NULL; + const struct group_desc *grp; int i; for (i = 0; i < pctldev->num_groups; i++) { grp = pinctrl_generic_get_group(pctldev, i); if (grp && !strcmp(grp->grp.name, name)) - break; + return grp; } - return grp; + return NULL; } static void imx_pin_dbg_show(struct pinctrl_dev *pctldev, struct seq_file *s,
Currently if no group is matched and found, this function will return the last grp to the caller, this is not expected, it is supposed to return NULL in this case. Fixes: e566fc11ea76 ("pinctrl: imx: use generic pinctrl helpers for managing groups") Signed-off-by: Hui Wang <hui.wang@canonical.com> --- drivers/pinctrl/freescale/pinctrl-imx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)