| Message ID | 20250326150114.71401-1-bryan.odonoghue@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | media: dt-bindings: Add OmniVision OV02C10 | expand |
On 27/03/2025 07:09, Krzysztof Kozlowski wrote: > On 26/03/2025 18:34, Bryan O'Donoghue wrote: >>> >>> I meant bindings are exactly the same, unless I missed something. >>> Devices are similar enough as well. >>> >>>> Seems simpler to me to have two separate files ? >>> >>> Not really, more files to maintain, more trivialities to fix if we >>> decide to change something in all bindings (e.g. style). >>> >>> Best regards, >>> Krzysztof >> >> Hmm, so we have two in-flight series and one yaml file. >> >> OK, I'll drop this patch and add ov02c10 to the ov02e10 yaml as you suggest. >> >> So long as the yaml file goes in first, the order of application of the >> ov02c10/ov02e10 drivers won't matter and can be fixed with a cherry-pick. > You can combine the series or add here a dependency. > > Best regards, > Krzysztof So just in terms of sequencing, are you happy for us to merge ovo2c10 and then do ov02e10 ? Since I have a bunch of driver work to do on ov02e10 I think this would make sense. --- bod
On 27/03/2025 15:07, Bryan O'Donoghue wrote: > On 27/03/2025 07:09, Krzysztof Kozlowski wrote: >> On 26/03/2025 18:34, Bryan O'Donoghue wrote: >>>> >>>> I meant bindings are exactly the same, unless I missed something. >>>> Devices are similar enough as well. >>>> >>>>> Seems simpler to me to have two separate files ? >>>> >>>> Not really, more files to maintain, more trivialities to fix if we >>>> decide to change something in all bindings (e.g. style). >>>> >>>> Best regards, >>>> Krzysztof >>> >>> Hmm, so we have two in-flight series and one yaml file. >>> >>> OK, I'll drop this patch and add ov02c10 to the ov02e10 yaml as you >>> suggest. >>> >>> So long as the yaml file goes in first, the order of application of the >>> ov02c10/ov02e10 drivers won't matter and can be fixed with a cherry- >>> pick. >> You can combine the series or add here a dependency. >> >> Best regards, >> Krzysztof > > So just in terms of sequencing, are you happy for us to merge ovo2c10 > and then do ov02e10 ? > > Since I have a bunch of driver work to do on ov02e10 I think this would > make sense. > > --- > bod Just to be clear I mean merge this yaml with ov02c10, then adding ov02e to that yaml later on. I'd expect there is 1-3 more submission cycles on the ov02e side. --- bod
diff --git a/Documentation/devicetree/bindings/media/i2c/ovti,ov02c10.yaml b/Documentation/devicetree/bindings/media/i2c/ovti,ov02c10.yaml new file mode 100644 index 000000000000..8cd174075d52 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ovti,ov02c10.yaml @@ -0,0 +1,115 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +# Copyright (c) 2025 Linaro Ltd. +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/i2c/ovti,ov02c10.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Omnivision OV02C10 CMOS Sensor + +maintainers: + - Bryan O'Donoghue <bryan.odonoghue@linaro.org> + +description: | + The Omnivision OV02C10 is a 2 megapixel, CMOS image sensor which supports: + - Automatic black level calibration (ABLC) + - Programmable controls for frame rate, mirror and flip, binning, cropping + and windowing + - Output formats 10-bit 4C RGB RAW, 10-bit Bayer RAW + - 2-lane MIPI D-PHY TX @ 800 Mbps per lane + - 1-lane MIPI D-PHY TX @ 1.5 Gbps per lane + - Dynamic defect pixel cancellation + - Standard SCCB command interface + +allOf: + - $ref: /schemas/media/video-interface-devices.yaml# + +properties: + compatible: + const: ovti,ov02c10 + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + avdd-supply: + description: Analogue circuit voltage supply. + + dovdd-supply: + description: I/O circuit voltage supply. + + dvdd-supply: + description: Digital circuit voltage supply. + + reset-gpios: + description: Active low GPIO connected to XSHUTDOWN pad of the sensor. + + port: + $ref: /schemas/graph.yaml#/$defs/port-base + additionalProperties: false + + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + additionalProperties: false + + properties: + data-lanes: + minItems: 1 + items: + - const: 1 + - const: 2 + link-frequencies: true + remote-endpoint: true + + required: + - data-lanes + - link-frequencies + - remote-endpoint + +required: + - compatible + - reg + - clocks + - port + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + ov02c10: camera@36 { + compatible = "ovti,ov02c10"; + reg = <0x36>; + + reset-gpios = <&tlmm 237 GPIO_ACTIVE_LOW>; + pinctrl-names = "default"; + pinctrl-0 = <&cam_rgb_defaultt>; + + clocks = <&ov02c10_clk>; + + assigned-clocks = <&ov02c10_clk>; + assigned-clock-parents = <&ov02c10_clk_parent>; + assigned-clock-rates = <19200000>; + + avdd-supply = <&vreg_l7b_2p8>; + dvdd-supply = <&vreg_l7b_1p8>; + dovdd-supply = <&vreg_l3m_1p8>; + + port { + ov02c10_ep: endpoint { + remote-endpoint = <&csiphy4_ep>; + data-lanes = <1 2>; + link-frequencies = /bits/ 64 <400000000>; + }; + }; + }; + }; +...
Add bindings for OVO2C10 a two megapixel 1080p RGB sensor. Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../bindings/media/i2c/ovti,ov02c10.yaml | 115 ++++++++++++++++++ 1 file changed, 115 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ovti,ov02c10.yaml