| Message ID | 20250325224403.4011975-12-richard.henderson@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | target/avr: Increase page size | expand |
On 3/25/25 15:44, Richard Henderson wrote: > Now that we can handle the MCU allocating only a portion of the > first page to i/o, increase the page size. Choose 10 as larger > than the i/o on every MCU, just so that this path is tested. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/avr/cpu-param.h | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/target/avr/cpu-param.h b/target/avr/cpu-param.h > index 81f3f49ee1..f5248ce9e7 100644 > --- a/target/avr/cpu-param.h > +++ b/target/avr/cpu-param.h > @@ -21,13 +21,7 @@ > #ifndef AVR_CPU_PARAM_H > #define AVR_CPU_PARAM_H > > -/* > - * TARGET_PAGE_BITS cannot be more than 8 bits because > - * 1. all IO registers occupy [0x0000 .. 0x00ff] address range, and they > - * should be implemented as a device and not memory > - * 2. SRAM starts at the address 0x0100 > - */ > -#define TARGET_PAGE_BITS 8 > +#define TARGET_PAGE_BITS 10 > #define TARGET_PHYS_ADDR_SPACE_BITS 24 > #define TARGET_VIRT_ADDR_SPACE_BITS 24 > Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
diff --git a/target/avr/cpu-param.h b/target/avr/cpu-param.h index 81f3f49ee1..f5248ce9e7 100644 --- a/target/avr/cpu-param.h +++ b/target/avr/cpu-param.h @@ -21,13 +21,7 @@ #ifndef AVR_CPU_PARAM_H #define AVR_CPU_PARAM_H -/* - * TARGET_PAGE_BITS cannot be more than 8 bits because - * 1. all IO registers occupy [0x0000 .. 0x00ff] address range, and they - * should be implemented as a device and not memory - * 2. SRAM starts at the address 0x0100 - */ -#define TARGET_PAGE_BITS 8 +#define TARGET_PAGE_BITS 10 #define TARGET_PHYS_ADDR_SPACE_BITS 24 #define TARGET_VIRT_ADDR_SPACE_BITS 24
Now that we can handle the MCU allocating only a portion of the first page to i/o, increase the page size. Choose 10 as larger than the i/o on every MCU, just so that this path is tested. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/avr/cpu-param.h | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)