| Message ID | 20250324125105.81774-1-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: pinctrl: mediatek: Drop unrelated nodes from DTS example | expand |
Il 24/03/25 13:51, Krzysztof Kozlowski ha scritto: > Binding example should not contain other nodes, e.g. consumers of > pinctrl of, because this is completely redundant and adds unnecessary > bloat. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Il 24/03/25 13:51, Krzysztof Kozlowski ha scritto: > DTS example in the bindings should be indented with 2- or 4-spaces and > aligned with opening '- |', so correct any differences like 3-spaces or > mixtures 2- and 4-spaces in one binding. > > No functional changes here, but saves some comments during reviews of > new patches built on existing code. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../pinctrl/mediatek,mt65xx-pinctrl.yaml | 83 +++++++------------ > .../pinctrl/mediatek,mt7622-pinctrl.yaml | 48 +++++------ > .../pinctrl/mediatek,mt8183-pinctrl.yaml | 68 +++++++-------- > .../pinctrl/mediatek,mt8192-pinctrl.yaml | 76 ++++++++--------- > 4 files changed, 127 insertions(+), 148 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml > index 5f2808212f39..b9680b896f12 100644 > --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml > @@ -137,64 +137,43 @@ examples: > #size-cells = <2>; > > pinctrl@1c20800 { > - compatible = "mediatek,mt8135-pinctrl"; > - reg = <0 0x1000B000 0 0x1000>; > - mediatek,pctl-regmap = <&syscfg_pctl_a>, <&syscfg_pctl_b>; > - gpio-controller; > - #gpio-cells = <2>; > - interrupt-controller; > - #interrupt-cells = <2>; > - interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>, > - <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>; > + compatible = "mediatek,mt8135-pinctrl"; > + reg = <0 0x1000B000 0 0x1000>; > + mediatek,pctl-regmap = <&syscfg_pctl_a>, <&syscfg_pctl_b>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupt-controller; > + #interrupt-cells = <2>; > + interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>, > + <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>; > > - i2c0_pins_a: i2c0-pins { > - pins1 { > - pinmux = <MT8135_PIN_100_SDA0__FUNC_SDA0>, > - <MT8135_PIN_101_SCL0__FUNC_SCL0>; > - bias-disable; > - }; > - }; > - > - i2c1_pins_a: i2c1-pins { > - pins { > - pinmux = <MT8135_PIN_195_SDA1__FUNC_SDA1>, > - <MT8135_PIN_196_SCL1__FUNC_SCL1>; > - bias-pull-up = <MTK_PUPD_SET_R1R0_01>; > - }; > - }; > - > - i2c2_pins_a: i2c2-pins { > - pins1 { > - pinmux = <MT8135_PIN_193_SDA2__FUNC_SDA2>; > - bias-pull-down; > + i2c0_pins_a: i2c0-pins { Agreeing with Rob - if you can please also remove the labels while at it, that'd be great, but regardless of that... Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml index bccff08a5ba3..5f2808212f39 100644 --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml @@ -136,16 +136,6 @@ examples: #address-cells = <2>; #size-cells = <2>; - syscfg_pctl_a: syscfg-pctl-a@10005000 { - compatible = "mediatek,mt8135-pctl-a-syscfg", "syscon"; - reg = <0 0x10005000 0 0x1000>; - }; - - syscfg_pctl_b: syscfg-pctl-b@1020c020 { - compatible = "mediatek,mt8135-pctl-b-syscfg", "syscon"; - reg = <0 0x1020C020 0 0x1000>; - }; - pinctrl@1c20800 { compatible = "mediatek,mt8135-pinctrl"; reg = <0 0x1000B000 0 0x1000>; diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml index 3bbc00df5548..f4bab7a132d3 100644 --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt6779-pinctrl.yaml @@ -245,9 +245,4 @@ examples: }; }; }; - - mmc0 { - pinctrl-0 = <&mmc0_pins_default>; - pinctrl-names = "default"; - }; };
Binding example should not contain other nodes, e.g. consumers of pinctrl of, because this is completely redundant and adds unnecessary bloat. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../bindings/pinctrl/mediatek,mt65xx-pinctrl.yaml | 10 ---------- .../bindings/pinctrl/mediatek,mt6779-pinctrl.yaml | 5 ----- 2 files changed, 15 deletions(-)