| Message ID | 20250323153018.73491-1-philmd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | target/s390x: Fix a typo in s390_cpu_class_init() | expand |
On 3/23/25 08:30, Philippe Mathieu-Daudé wrote: > Fixes: 41868f846d2 ("s390x/cpumodel: "host" and "qemu" as CPU subclasses") > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > target/s390x/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c > index d73142600bf..1f75629ddc2 100644 > --- a/target/s390x/cpu.c > +++ b/target/s390x/cpu.c > @@ -377,7 +377,7 @@ static void s390_cpu_class_init(ObjectClass *oc, void *data) > resettable_class_set_parent_phases(rc, NULL, s390_cpu_reset_hold, NULL, > &scc->parent_phases); > > - cc->class_by_name = s390_cpu_class_by_name, > + cc->class_by_name = s390_cpu_class_by_name; > cc->mmu_index = s390x_cpu_mmu_index; > cc->dump_state = s390_cpu_dump_state; > cc->query_cpu_fast = s390_query_cpu_fast; Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 23/03/2025 16.30, Philippe Mathieu-Daudé wrote: > Fixes: 41868f846d2 ("s390x/cpumodel: "host" and "qemu" as CPU subclasses") > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > target/s390x/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c > index d73142600bf..1f75629ddc2 100644 > --- a/target/s390x/cpu.c > +++ b/target/s390x/cpu.c > @@ -377,7 +377,7 @@ static void s390_cpu_class_init(ObjectClass *oc, void *data) > resettable_class_set_parent_phases(rc, NULL, s390_cpu_reset_hold, NULL, > &scc->parent_phases); > > - cc->class_by_name = s390_cpu_class_by_name, > + cc->class_by_name = s390_cpu_class_by_name; Please add a proper patch description next time. I spent dozens of seconds to spot the typo in one of the words 'til I realized that it is the comma at the end ;-) Reviewed-by: Thomas Huth <thuth@redhat.com>
On 24/3/25 07:05, Thomas Huth wrote: > On 23/03/2025 16.30, Philippe Mathieu-Daudé wrote: >> Fixes: 41868f846d2 ("s390x/cpumodel: "host" and "qemu" as CPU >> subclasses") >> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> >> --- >> target/s390x/cpu.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c >> index d73142600bf..1f75629ddc2 100644 >> --- a/target/s390x/cpu.c >> +++ b/target/s390x/cpu.c >> @@ -377,7 +377,7 @@ static void s390_cpu_class_init(ObjectClass *oc, >> void *data) >> resettable_class_set_parent_phases(rc, NULL, >> s390_cpu_reset_hold, NULL, >> &scc->parent_phases); >> - cc->class_by_name = s390_cpu_class_by_name, >> + cc->class_by_name = s390_cpu_class_by_name; > > Please add a proper patch description next time. I spent dozens of > seconds to spot the typo in one of the words 'til I realized that it is > the comma at the end ;-) Sorry I thought it was trivial, but since it got unnoticed during 8 years, maybe not. > > Reviewed-by: Thomas Huth <thuth@redhat.com> >
diff --git a/target/s390x/cpu.c b/target/s390x/cpu.c index d73142600bf..1f75629ddc2 100644 --- a/target/s390x/cpu.c +++ b/target/s390x/cpu.c @@ -377,7 +377,7 @@ static void s390_cpu_class_init(ObjectClass *oc, void *data) resettable_class_set_parent_phases(rc, NULL, s390_cpu_reset_hold, NULL, &scc->parent_phases); - cc->class_by_name = s390_cpu_class_by_name, + cc->class_by_name = s390_cpu_class_by_name; cc->mmu_index = s390x_cpu_mmu_index; cc->dump_state = s390_cpu_dump_state; cc->query_cpu_fast = s390_query_cpu_fast;
Fixes: 41868f846d2 ("s390x/cpumodel: "host" and "qemu" as CPU subclasses") Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- target/s390x/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)