| Message ID | 20250319182255.3096731-6-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | gdbstub: conversion to runtime endianess helpers | expand |
On 3/19/25 11:22, Alex Bennée wrote: > Mainly as an aid to myself getting confused too many bswaps deep into > the code. > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > target/ppc/cpu.h | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h > index efab54a068..1e833ade04 100644 > --- a/target/ppc/cpu.h > +++ b/target/ppc/cpu.h > @@ -2906,7 +2906,12 @@ static inline bool lsw_reg_in_range(int start, int nregs, int rx) > (start + nregs > 32 && (rx >= start || rx < start + nregs - 32)); > } > > -/* Accessors for FP, VMX and VSX registers */ > +/* > + * Access functions for FP, VMX and VSX registers > + * > + * The register is stored as a 128 bit host endian value so we need to > + * take that into account when accessing smaller parts of it. > + */ > #if HOST_BIG_ENDIAN > #define VsrB(i) u8[i] > #define VsrSB(i) s8[i] Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h index efab54a068..1e833ade04 100644 --- a/target/ppc/cpu.h +++ b/target/ppc/cpu.h @@ -2906,7 +2906,12 @@ static inline bool lsw_reg_in_range(int start, int nregs, int rx) (start + nregs > 32 && (rx >= start || rx < start + nregs - 32)); } -/* Accessors for FP, VMX and VSX registers */ +/* + * Access functions for FP, VMX and VSX registers + * + * The register is stored as a 128 bit host endian value so we need to + * take that into account when accessing smaller parts of it. + */ #if HOST_BIG_ENDIAN #define VsrB(i) u8[i] #define VsrSB(i) s8[i]
Mainly as an aid to myself getting confused too many bswaps deep into the code. Signed-off-by: Alex Bennée <alex.bennee@linaro.org> --- target/ppc/cpu.h | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)