| Message ID | 20250314-ufs-dma-coherent-v1-2-bdf9f9be2919@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | Add dma-coherent for gs101 UFS dt node | expand |
On Fri, Mar 14, 2025 at 03:38:03PM +0000, Peter Griffin wrote: > dma-coherent property is required for gs101 as ufs-exynos enables > sharability. > > Fixes: 438e23b61cd4 ("scsi: ufs: dt-bindings: exynos: Add gs101 compatible") > Cc: stable@vger.kernel.org This change is a noop and fixes nothing, which you can test by testing your DTS without and with this patch. Best regards, Krzysztof
Hi André On Fri, 14 Mar 2025 at 15:59, André Draszik <andre.draszik@linaro.org> wrote: > > Hi Pete, > > On Fri, 2025-03-14 at 15:38 +0000, Peter Griffin wrote: > > dma-coherent property is required for gs101 as ufs-exynos enables > > sharability. > > > > Fixes: 438e23b61cd4 ("scsi: ufs: dt-bindings: exynos: Add gs101 compatible") > > Cc: stable@vger.kernel.org > > Signed-off-by: Peter Griffin <peter.griffin@linaro.org> > > --- > > Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml b/Documentation/devicetree/bindings/ufs/samsung,exynos- > > ufs.yaml > > index 720879820f6616a30cae2db3d4d2d22e847666c4..5dbb7f6a8c354b82685c521e70655e106f702a8d 100644 > > --- a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml > > +++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml > > @@ -96,6 +96,8 @@ allOf: > > clock-names: > > minItems: 6 > > > > + dma-coherent: true > > + > > This is allowed globally already in this file. Did you meant to make it 'required'? I hadn't noticed it was already handled further up in the yaml. In which case this patch can be dropped entirely. Thanks, Peter
diff --git a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml index 720879820f6616a30cae2db3d4d2d22e847666c4..5dbb7f6a8c354b82685c521e70655e106f702a8d 100644 --- a/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml @@ -96,6 +96,8 @@ allOf: clock-names: minItems: 6 + dma-coherent: true + else: properties: clocks:
dma-coherent property is required for gs101 as ufs-exynos enables sharability. Fixes: 438e23b61cd4 ("scsi: ufs: dt-bindings: exynos: Add gs101 compatible") Cc: stable@vger.kernel.org Signed-off-by: Peter Griffin <peter.griffin@linaro.org> --- Documentation/devicetree/bindings/ufs/samsung,exynos-ufs.yaml | 2 ++ 1 file changed, 2 insertions(+)