| Message ID | 20250312074320.1430175-1-nichen@iscas.ac.cn |
|---|---|
| State | New |
| Headers | show |
| Series | scsi: fnic: Remove redundant 'flush_workqueue()' calls | expand |
On Wednesday, March 12, 2025 12:43 AM, Chen Ni <nichen@iscas.ac.cn> wrote: > > 'destroy_workqueue()' already drains the queue before destroying it, so > there is no need to flush it explicitly. > > Remove the redundant 'flush_workqueue()' calls. > > This was generated with coccinelle: > > @@ > expression E; > @@ > - flush_workqueue(E); > destroy_workqueue(E); > > Signed-off-by: Chen Ni <nichen@iscas.ac.cn> > --- > drivers/scsi/fnic/fnic_main.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c > index 0b20ac8c3f46..3dd06376e97b 100644 > --- a/drivers/scsi/fnic/fnic_main.c > +++ b/drivers/scsi/fnic/fnic_main.c > @@ -1365,10 +1365,9 @@ static void __exit fnic_cleanup_module(void) > if (pc_rscn_handling_feature_flag == PC_RSCN_HANDLING_FEATURE_ON) > destroy_workqueue(reset_fnic_work_queue); > > - if (fnic_fip_queue) { > - flush_workqueue(fnic_fip_queue); > + if (fnic_fip_queue) > destroy_workqueue(fnic_fip_queue); > - } > + > kmem_cache_destroy(fnic_sgl_cache[FNIC_SGL_CACHE_MAX]); > kmem_cache_destroy(fnic_sgl_cache[FNIC_SGL_CACHE_DFLT]); > kmem_cache_destroy(fnic_io_req_cache); > -- > 2.25.1 > > Looks good to me. Reviewed-by: Karan Tilak Kumar <kartilak@cisco.com> Regards, Karan
diff --git a/drivers/scsi/fnic/fnic_main.c b/drivers/scsi/fnic/fnic_main.c index 0b20ac8c3f46..3dd06376e97b 100644 --- a/drivers/scsi/fnic/fnic_main.c +++ b/drivers/scsi/fnic/fnic_main.c @@ -1365,10 +1365,9 @@ static void __exit fnic_cleanup_module(void) if (pc_rscn_handling_feature_flag == PC_RSCN_HANDLING_FEATURE_ON) destroy_workqueue(reset_fnic_work_queue); - if (fnic_fip_queue) { - flush_workqueue(fnic_fip_queue); + if (fnic_fip_queue) destroy_workqueue(fnic_fip_queue); - } + kmem_cache_destroy(fnic_sgl_cache[FNIC_SGL_CACHE_MAX]); kmem_cache_destroy(fnic_sgl_cache[FNIC_SGL_CACHE_DFLT]); kmem_cache_destroy(fnic_io_req_cache);
'destroy_workqueue()' already drains the queue before destroying it, so there is no need to flush it explicitly. Remove the redundant 'flush_workqueue()' calls. This was generated with coccinelle: @@ expression E; @@ - flush_workqueue(E); destroy_workqueue(E); Signed-off-by: Chen Ni <nichen@iscas.ac.cn> --- drivers/scsi/fnic/fnic_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)