| Message ID | ab79cf4415d21ff2854fee4f4189fac555c30b7a.1741610847.git.mazziesaccount@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Support ROHM BD79124 ADC | expand |
Hi Matti, Thank you for the patch. On Mon, Mar 10, 2025 at 02:57:40PM +0200, Matti Vaittinen wrote: > Slightly simplify code iterating the child nodes with specific names > using the new fwnode_for_each_available_named_child_node(). > > Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > Revision history: > v5 => v6: > - New patch > > NOTE: This patch depends on the patch: > [2/10] "property: Add functions to iterate named child" > > Compile-tested only! > --- > drivers/media/i2c/thp7312.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/i2c/thp7312.c b/drivers/media/i2c/thp7312.c > index 8852c56431fe..104754b2ace2 100644 > --- a/drivers/media/i2c/thp7312.c > +++ b/drivers/media/i2c/thp7312.c > @@ -2067,11 +2067,9 @@ static int thp7312_parse_dt(struct thp7312_device *thp7312) > return -EINVAL; > } > > - fwnode_for_each_available_child_node(sensors, node) { > - if (fwnode_name_eq(node, "sensor")) { > - if (!thp7312_sensor_parse_dt(thp7312, node)) > - num_sensors++; > - } > + fwnode_for_each_available_named_child_node(sensors, node, "sensor") { > + if (!thp7312_sensor_parse_dt(thp7312, node)) > + num_sensors++; > } > > fwnode_handle_put(sensors);
diff --git a/drivers/media/i2c/thp7312.c b/drivers/media/i2c/thp7312.c index 8852c56431fe..104754b2ace2 100644 --- a/drivers/media/i2c/thp7312.c +++ b/drivers/media/i2c/thp7312.c @@ -2067,11 +2067,9 @@ static int thp7312_parse_dt(struct thp7312_device *thp7312) return -EINVAL; } - fwnode_for_each_available_child_node(sensors, node) { - if (fwnode_name_eq(node, "sensor")) { - if (!thp7312_sensor_parse_dt(thp7312, node)) - num_sensors++; - } + fwnode_for_each_available_named_child_node(sensors, node, "sensor") { + if (!thp7312_sensor_parse_dt(thp7312, node)) + num_sensors++; } fwnode_handle_put(sensors);
Slightly simplify code iterating the child nodes with specific names using the new fwnode_for_each_available_named_child_node(). Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com> --- Revision history: v5 => v6: - New patch NOTE: This patch depends on the patch: [2/10] "property: Add functions to iterate named child" Compile-tested only! --- drivers/media/i2c/thp7312.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)