diff mbox series

[v6,1/3] ttynull: Always initialize console index to -1

Message ID 20250304035447.3138221-2-adamsimonelli@gmail.com
State New
Headers show
Series Optionally allow ttynull to be selected as a default console | expand

Commit Message

Adam Simonelli March 4, 2025, 3:54 a.m. UTC 
From: Adam Simonelli <adamsimonelli@gmail.com>

Signed-off-by: Adam Simonelli <adamsimonelli@gmail.com>
---
 drivers/tty/ttynull.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Andy Shevchenko March 4, 2025, 6:01 a.m. UTC | #1 
On Tue, Mar 4, 2025 at 5:55 AM <adamsimonelli@gmail.com> wrote:
>
> From: Adam Simonelli <adamsimonelli@gmail.com>

In general we do not accept empty commit messages (yes, it was done in
the past and in some exceptional cases, but should be taken as a very
bad practice).

Should it also have Suggested-by: ?

> Signed-off-by: Adam Simonelli <adamsimonelli@gmail.com>
diff mbox series

Patch

diff --git a/drivers/tty/ttynull.c b/drivers/tty/ttynull.c
index 6b2f7208b564..d8b51edde628 100644
--- a/drivers/tty/ttynull.c
+++ b/drivers/tty/ttynull.c
@@ -57,6 +57,7 @@  static struct tty_driver *ttynull_device(struct console *c, int *index)
 static struct console ttynull_console = {
 	.name = "ttynull",
 	.device = ttynull_device,
+	.index = -1,
 };
 
 static int __init ttynull_init(void)