diff mbox series

serial: 8250_dw: Add ACPI ID for Sophgo SG2044 UART

Message ID 20250304070212.350155-1-inochiama@gmail.com
State New
Headers show
Series serial: 8250_dw: Add ACPI ID for Sophgo SG2044 UART | expand

Commit Message

Inochi Amaoto March 4, 2025, 7:02 a.m. UTC 
The UART on Sophgo SG2044 can be enumerated via ACPI.
Add ACPI ID for it.

Signed-off-by: Inochi Amaoto <inochiama@gmail.com>
---
 drivers/tty/serial/8250/8250_dw.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Andy Shevchenko March 4, 2025, 11:36 a.m. UTC | #1 
On Tue, Mar 04, 2025 at 03:02:09PM +0800, Inochi Amaoto wrote:
> The UART on Sophgo SG2044 can be enumerated via ACPI.
> Add ACPI ID for it.

This is fake ACPI ID. Please work with a vendor to issue the proper one.
Vendor ACPI ID registry has no records on Sophgo:
https://uefi.org/ACPI_ID_List?acpi_search=SophGo

NAK.
Andy Shevchenko March 4, 2025, 11:48 a.m. UTC | #2 
On Tue, Mar 04, 2025 at 01:36:47PM +0200, Andy Shevchenko wrote:
> On Tue, Mar 04, 2025 at 03:02:09PM +0800, Inochi Amaoto wrote:
> > The UART on Sophgo SG2044 can be enumerated via ACPI.
> > Add ACPI ID for it.
> 
> This is fake ACPI ID. Please work with a vendor to issue the proper one.
> Vendor ACPI ID registry has no records on Sophgo:
> https://uefi.org/ACPI_ID_List?acpi_search=SophGo
> 
> NAK.

FWIW, the I2C thread has more insights and details:
https://lore.kernel.org/r/20250304070212.350155-3-inochiama@gmail.com
diff mbox series

Patch

diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c
index 6afcf27db3b8..031ca1a7155b 100644
--- a/drivers/tty/serial/8250/8250_dw.c
+++ b/drivers/tty/serial/8250/8250_dw.c
@@ -785,6 +785,7 @@  static const struct acpi_device_id dw8250_acpi_match[] = {
 	{ "INT3434", (kernel_ulong_t)&dw8250_dw_apb },
 	{ "INT3435", (kernel_ulong_t)&dw8250_dw_apb },
 	{ "INTC10EE", (kernel_ulong_t)&dw8250_dw_apb },
+	{ "SOPH0002", (kernel_ulong_t)&dw8250_skip_set_rate_data },
 	{ },
 };
 MODULE_DEVICE_TABLE(acpi, dw8250_acpi_match);