| Message ID | 1481107365-24839-3-git-send-email-bgolaszewski@baylibre.com |
|---|---|
| State | New |
| Headers | show |
2016-12-07 11:42 GMT+01:00 Bartosz Golaszewski <bgolaszewski@baylibre.com>: > THS8135 is a configurable video DAC. Add DT bindings for this chip and > use the dumb-vga-dac driver for now as no configuration is required to > make it work. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > .../bindings/display/bridge/ti,ths8135.txt | 52 ++++++++++++++++++++++ > drivers/gpu/drm/bridge/dumb-vga-dac.c | 1 + > 2 files changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt b/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt > new file mode 100644 > index 0000000..23cd8ee > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt > @@ -0,0 +1,52 @@ > +THS8135 Video DAC > +----------------- > + > +This is the binding for Texas Instruments THS8135 Video DAC bridge. > + > +Required properties: > + > +- compatible: Must be "ti,ths8135" > + > +Required nodes: > + > +This device has two video ports. Their connections are modelled using the OF > +graph bindings specified in Documentation/devicetree/bindings/graph.txt. > + > +- Video port 0 for RGB input > +- Video port 1 for VGA output > + > +Example > +------- > + > +vga-bridge { > + compatible = "ti,ths8135"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0>; > + > + vga_bridge_in: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&lcdc_out_vga>; > + }; > + }; > + > + port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + > + vga_bridge_out: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&vga_con_in>; > + }; > + }; > + }; > +}; > diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c > index afec232..498fa75 100644 > --- a/drivers/gpu/drm/bridge/dumb-vga-dac.c > +++ b/drivers/gpu/drm/bridge/dumb-vga-dac.c > @@ -204,6 +204,7 @@ static int dumb_vga_remove(struct platform_device *pdev) > > static const struct of_device_id dumb_vga_match[] = { > { .compatible = "dumb-vga-dac" }, > + { .compatible = "ti,ths8135" }, > {}, > }; > MODULE_DEVICE_TABLE(of, dumb_vga_match); > -- > 2.9.3 > + Maxime Sorry, I forgot to include your e-mail. Bartosz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Bartosz, Thank you for the patch. On Wednesday 07 Dec 2016 11:45:11 Bartosz Golaszewski wrote: > 2016-12-07 11:42 GMT+01:00 Bartosz Golaszewski <bgolaszewski@baylibre.com>: > > THS8135 is a configurable video DAC. Add DT bindings for this chip and > > use the dumb-vga-dac driver for now as no configuration is required to > > make it work. > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > --- > > > > .../bindings/display/bridge/ti,ths8135.txt | 52 +++++++++++++++++ > > drivers/gpu/drm/bridge/dumb-vga-dac.c | 1 + You might be asked by DT maintainers to split this in two, but regardless of whether it's one patch or two, you can add my Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > 2 files changed, 53 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt> > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt > > b/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt new > > file mode 100644 > > index 0000000..23cd8ee > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt > > @@ -0,0 +1,52 @@ > > +THS8135 Video DAC > > +----------------- > > + > > +This is the binding for Texas Instruments THS8135 Video DAC bridge. > > + > > +Required properties: > > + > > +- compatible: Must be "ti,ths8135" > > + > > +Required nodes: > > + > > +This device has two video ports. Their connections are modelled using the > > OF +graph bindings specified in > > Documentation/devicetree/bindings/graph.txt. + > > +- Video port 0 for RGB input > > +- Video port 1 for VGA output > > + > > +Example > > +------- > > + > > +vga-bridge { > > + compatible = "ti,ths8135"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0>; > > + > > + vga_bridge_in: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&lcdc_out_vga>; > > + }; > > + }; > > + > > + port@1 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <1>; > > + > > + vga_bridge_out: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&vga_con_in>; > > + }; > > + }; > > + }; > > +}; > > diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c > > b/drivers/gpu/drm/bridge/dumb-vga-dac.c index afec232..498fa75 100644 > > --- a/drivers/gpu/drm/bridge/dumb-vga-dac.c > > +++ b/drivers/gpu/drm/bridge/dumb-vga-dac.c > > @@ -204,6 +204,7 @@ static int dumb_vga_remove(struct platform_device > > *pdev)> > > static const struct of_device_id dumb_vga_match[] = { > > > > { .compatible = "dumb-vga-dac" }, > > > > + { .compatible = "ti,ths8135" }, > > > > {}, > > > > }; > > MODULE_DEVICE_TABLE(of, dumb_vga_match); > > > > -- > > 2.9.3 > > + Maxime > > Sorry, I forgot to include your e-mail. > > Bartosz -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Dec 07, 2016 at 11:42:43AM +0100, Bartosz Golaszewski wrote: > THS8135 is a configurable video DAC. Add DT bindings for this chip and > use the dumb-vga-dac driver for now as no configuration is required to > make it work. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > .../bindings/display/bridge/ti,ths8135.txt | 52 ++++++++++++++++++++++ > drivers/gpu/drm/bridge/dumb-vga-dac.c | 1 + > 2 files changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt Acked-by: Rob Herring <robh@kernel.org> But one nit below: > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt b/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt > new file mode 100644 > index 0000000..23cd8ee > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt > @@ -0,0 +1,52 @@ > +THS8135 Video DAC > +----------------- > + > +This is the binding for Texas Instruments THS8135 Video DAC bridge. > + > +Required properties: > + > +- compatible: Must be "ti,ths8135" > + > +Required nodes: > + > +This device has two video ports. Their connections are modelled using the OF > +graph bindings specified in Documentation/devicetree/bindings/graph.txt. > + > +- Video port 0 for RGB input > +- Video port 1 for VGA output > + > +Example > +------- > + > +vga-bridge { > + compatible = "ti,ths8135"; > + #address-cells = <1>; > + #size-cells = <0>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + > + port@0 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0>; > + > + vga_bridge_in: endpoint@0 { > + reg = <0>; You don't need reg here. > + remote-endpoint = <&lcdc_out_vga>; > + }; > + }; > + > + port@1 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <1>; > + > + vga_bridge_out: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&vga_con_in>; > + }; > + }; > + }; > +}; > diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c > index afec232..498fa75 100644 > --- a/drivers/gpu/drm/bridge/dumb-vga-dac.c > +++ b/drivers/gpu/drm/bridge/dumb-vga-dac.c > @@ -204,6 +204,7 @@ static int dumb_vga_remove(struct platform_device *pdev) > > static const struct of_device_id dumb_vga_match[] = { > { .compatible = "dumb-vga-dac" }, > + { .compatible = "ti,ths8135" }, > {}, > }; > MODULE_DEVICE_TABLE(of, dumb_vga_match); > -- > 2.9.3 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello, On Monday 12 Dec 2016 10:45:47 Rob Herring wrote: > On Wed, Dec 07, 2016 at 11:42:43AM +0100, Bartosz Golaszewski wrote: > > THS8135 is a configurable video DAC. Add DT bindings for this chip and > > use the dumb-vga-dac driver for now as no configuration is required to > > make it work. > > > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > --- > > > > .../bindings/display/bridge/ti,ths8135.txt | 52 +++++++++++++++++ > > drivers/gpu/drm/bridge/dumb-vga-dac.c | 1 + > > 2 files changed, 53 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt > Acked-by: Rob Herring <robh@kernel.org> > > But one nit below: > > diff --git > > a/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt > > b/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt new > > file mode 100644 > > index 0000000..23cd8ee > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt > > @@ -0,0 +1,52 @@ > > +THS8135 Video DAC > > +----------------- > > + > > +This is the binding for Texas Instruments THS8135 Video DAC bridge. > > + > > +Required properties: > > + > > +- compatible: Must be "ti,ths8135" > > + > > +Required nodes: > > + > > +This device has two video ports. Their connections are modelled using the > > OF +graph bindings specified in > > Documentation/devicetree/bindings/graph.txt. + > > +- Video port 0 for RGB input > > +- Video port 1 for VGA output > > + > > +Example > > +------- > > + > > +vga-bridge { > > + compatible = "ti,ths8135"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0>; > > + > > + vga_bridge_in: endpoint@0 { > > + reg = <0>; > > You don't need reg here. In which case the endpoint node should be named endpoint, not endpoint@0. You could then also remove the #address-cells and #size-cells properties from the port@0 node. Same for port@1 below. > > + remote-endpoint = <&lcdc_out_vga>; > > + }; > > + }; > > + > > + port@1 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <1>; > > + > > + vga_bridge_out: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&vga_con_in>; > > + }; > > + }; > > + }; > > +}; > > diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c > > b/drivers/gpu/drm/bridge/dumb-vga-dac.c index afec232..498fa75 100644 > > --- a/drivers/gpu/drm/bridge/dumb-vga-dac.c > > +++ b/drivers/gpu/drm/bridge/dumb-vga-dac.c > > @@ -204,6 +204,7 @@ static int dumb_vga_remove(struct platform_device > > *pdev) > > > > static const struct of_device_id dumb_vga_match[] = { > > { .compatible = "dumb-vga-dac" }, > > + { .compatible = "ti,ths8135" }, > > {}, > > }; > > MODULE_DEVICE_TABLE(of, dumb_vga_match); -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt b/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt new file mode 100644 index 0000000..23cd8ee --- /dev/null +++ b/Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt @@ -0,0 +1,52 @@ +THS8135 Video DAC +----------------- + +This is the binding for Texas Instruments THS8135 Video DAC bridge. + +Required properties: + +- compatible: Must be "ti,ths8135" + +Required nodes: + +This device has two video ports. Their connections are modelled using the OF +graph bindings specified in Documentation/devicetree/bindings/graph.txt. + +- Video port 0 for RGB input +- Video port 1 for VGA output + +Example +------- + +vga-bridge { + compatible = "ti,ths8135"; + #address-cells = <1>; + #size-cells = <0>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + + port@0 { + #address-cells = <1>; + #size-cells = <0>; + reg = <0>; + + vga_bridge_in: endpoint@0 { + reg = <0>; + remote-endpoint = <&lcdc_out_vga>; + }; + }; + + port@1 { + #address-cells = <1>; + #size-cells = <0>; + reg = <1>; + + vga_bridge_out: endpoint@0 { + reg = <0>; + remote-endpoint = <&vga_con_in>; + }; + }; + }; +}; diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c index afec232..498fa75 100644 --- a/drivers/gpu/drm/bridge/dumb-vga-dac.c +++ b/drivers/gpu/drm/bridge/dumb-vga-dac.c @@ -204,6 +204,7 @@ static int dumb_vga_remove(struct platform_device *pdev) static const struct of_device_id dumb_vga_match[] = { { .compatible = "dumb-vga-dac" }, + { .compatible = "ti,ths8135" }, {}, }; MODULE_DEVICE_TABLE(of, dumb_vga_match);
THS8135 is a configurable video DAC. Add DT bindings for this chip and use the dumb-vga-dac driver for now as no configuration is required to make it work. Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> --- .../bindings/display/bridge/ti,ths8135.txt | 52 ++++++++++++++++++++++ drivers/gpu/drm/bridge/dumb-vga-dac.c | 1 + 2 files changed, 53 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/bridge/ti,ths8135.txt -- 2.9.3 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html