diff mbox series

[v2,07/32] tests/functional: update the aarch64_virg_gpu images

Message ID 20250304222439.2035603-8-alex.bennee@linaro.org
State New
Headers show
Series maintainer updates for 10.0 softfreeze (gpu/tcg tests, plugins, MAINTAINERS) pre-PR | expand

Commit Message

Alex Bennée March 4, 2025, 10:24 p.m. UTC 
Update to the most recent aarch64_virt_gpu image. The principle
differences are:

  - target a v8.0 baseline CPU
  - latest vkmark (2025.1)
  - actually uses the rootfs (previously was initrd)
  - rootfs includes more testing tools for interactive use

See README.md in https://fileserver.linaro.org/s/ce5jXBFinPxtEdx for
details about the image creation and the buildroot config.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
 tests/functional/test_aarch64_virt_gpu.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Thomas Huth March 5, 2025, 8:35 a.m. UTC | #1 
On 04/03/2025 23.24, Alex Bennée wrote:
> Update to the most recent aarch64_virt_gpu image. The principle
> differences are:
> 
>    - target a v8.0 baseline CPU
>    - latest vkmark (2025.1)
>    - actually uses the rootfs (previously was initrd)
>    - rootfs includes more testing tools for interactive use
> 
> See README.md in https://fileserver.linaro.org/s/ce5jXBFinPxtEdx for
> details about the image creation and the buildroot config.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
>   tests/functional/test_aarch64_virt_gpu.py | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/tests/functional/test_aarch64_virt_gpu.py b/tests/functional/test_aarch64_virt_gpu.py
> index 3fdb31f034..e417ca9beb 100755
> --- a/tests/functional/test_aarch64_virt_gpu.py
> +++ b/tests/functional/test_aarch64_virt_gpu.py
> @@ -25,14 +25,14 @@ class Aarch64VirtGPUMachine(LinuxKernelTest):
>       ASSET_VIRT_GPU_KERNEL = Asset(
>           'https://fileserver.linaro.org/s/ce5jXBFinPxtEdx/'
>           'download?path=%2F&files='
> -        'Image',
> -        '89e5099d26166204cc5ca4bb6d1a11b92c217e1f82ec67e3ba363d09157462f6')
> +        'Image.6.12.16.aarch64',
> +        '7888c51c55d37e86bbbdeb5acea9f08c34e6b0f03c1f5b2463285f6a6f6eec8b')
>   
>       ASSET_VIRT_GPU_ROOTFS = Asset(
>           'https://fileserver.linaro.org/s/ce5jXBFinPxtEdx/'
>           'download?path=%2F&files='
> -        'rootfs.ext4.zstd',
> -        '792da7573f5dc2913ddb7c638151d4a6b2d028a4cb2afb38add513c1924bdad4')
> +        'rootfs.aarch64.ext2.zstd',

I'm a little bit surprised to see "ext2" instead of "ext4" here, did they 
really downgrade the filesystem?

Anyway,
Reviewed-by: Thomas Huth <thuth@redhat.com>
Alex Bennée March 5, 2025, 4:58 p.m. UTC | #2 
Thomas Huth <thuth@redhat.com> writes:

> On 04/03/2025 23.24, Alex Bennée wrote:
>> Update to the most recent aarch64_virt_gpu image. The principle
>> differences are:
>>    - target a v8.0 baseline CPU
>>    - latest vkmark (2025.1)
>>    - actually uses the rootfs (previously was initrd)
>>    - rootfs includes more testing tools for interactive use
>> See README.md in https://fileserver.linaro.org/s/ce5jXBFinPxtEdx for
>> details about the image creation and the buildroot config.
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> ---
>>   tests/functional/test_aarch64_virt_gpu.py | 10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>> diff --git a/tests/functional/test_aarch64_virt_gpu.py
>> b/tests/functional/test_aarch64_virt_gpu.py
>> index 3fdb31f034..e417ca9beb 100755
>> --- a/tests/functional/test_aarch64_virt_gpu.py
>> +++ b/tests/functional/test_aarch64_virt_gpu.py
>> @@ -25,14 +25,14 @@ class Aarch64VirtGPUMachine(LinuxKernelTest):
>>       ASSET_VIRT_GPU_KERNEL = Asset(
>>           'https://fileserver.linaro.org/s/ce5jXBFinPxtEdx/'
>>           'download?path=%2F&files='
>> -        'Image',
>> -        '89e5099d26166204cc5ca4bb6d1a11b92c217e1f82ec67e3ba363d09157462f6')
>> +        'Image.6.12.16.aarch64',
>> +        '7888c51c55d37e86bbbdeb5acea9f08c34e6b0f03c1f5b2463285f6a6f6eec8b')
>>         ASSET_VIRT_GPU_ROOTFS = Asset(
>>           'https://fileserver.linaro.org/s/ce5jXBFinPxtEdx/'
>>           'download?path=%2F&files='
>> -        'rootfs.ext4.zstd',
>> -        '792da7573f5dc2913ddb7c638151d4a6b2d028a4cb2afb38add513c1924bdad4')
>> +        'rootfs.aarch64.ext2.zstd',
>
> I'm a little bit surprised to see "ext2" instead of "ext4" here, did
> they really downgrade the filesystem?

I think buildroot just symlinked them all together. I'll double check.

>
> Anyway,
> Reviewed-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/tests/functional/test_aarch64_virt_gpu.py b/tests/functional/test_aarch64_virt_gpu.py
index 3fdb31f034..e417ca9beb 100755
--- a/tests/functional/test_aarch64_virt_gpu.py
+++ b/tests/functional/test_aarch64_virt_gpu.py
@@ -25,14 +25,14 @@  class Aarch64VirtGPUMachine(LinuxKernelTest):
     ASSET_VIRT_GPU_KERNEL = Asset(
         'https://fileserver.linaro.org/s/ce5jXBFinPxtEdx/'
         'download?path=%2F&files='
-        'Image',
-        '89e5099d26166204cc5ca4bb6d1a11b92c217e1f82ec67e3ba363d09157462f6')
+        'Image.6.12.16.aarch64',
+        '7888c51c55d37e86bbbdeb5acea9f08c34e6b0f03c1f5b2463285f6a6f6eec8b')
 
     ASSET_VIRT_GPU_ROOTFS = Asset(
         'https://fileserver.linaro.org/s/ce5jXBFinPxtEdx/'
         'download?path=%2F&files='
-        'rootfs.ext4.zstd',
-        '792da7573f5dc2913ddb7c638151d4a6b2d028a4cb2afb38add513c1924bdad4')
+        'rootfs.aarch64.ext2.zstd',
+        'd45118c899420b7e673f1539a37a35480134b3e36e3a59e2cb69b1781cbb14ef')
 
     def _launch_virt_gpu(self, gpu_device):
 
@@ -47,7 +47,7 @@  def _launch_virt_gpu(self, gpu_device):
                                'console=ttyAMA0 root=/dev/vda')
 
         self.vm.add_args("-accel", "tcg")
-        self.vm.add_args("-cpu", "neoverse-v1,pauth-impdef=on")
+        self.vm.add_args("-cpu", "cortex-a72")
         self.vm.add_args("-machine", "virt,gic-version=max",
                          '-kernel', kernel_path,
                          '-append', kernel_command_line)