| Message ID | 20250227180817.3386795-1-quic_yrangana@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] arm64: dts: qcom: sa8775p: add QCrypto node | expand |
On 28/02/2025 15:14, Bjorn Andersson wrote: > On Fri, Feb 28, 2025 at 11:01:16AM +0530, Yuvaraj Ranganathan wrote: >> On 2/28/2025 5:56 AM, Bjorn Andersson wrote: >>> On Thu, Feb 27, 2025 at 11:38:16PM +0530, Yuvaraj Ranganathan wrote: >>>> The initial QCE node change is reverted by the following patch >>> >>> s/is/was/ >>> >>>> https://lore.kernel.org/all/20250128115333.95021-1-krzysztof.kozlowski@linaro.org/ >>>> because of the build warning, >>>> >>>> sa8775p-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: >>>> ... >>>> 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] >>>> >>>> Add the QCE node back that fix the warnings. >>>> >>> >>> Are you saying that adding this node back will fix the warning? >>> >>> I'd expect that you would say something like "The changes to the >>> Devicetree binding has accepted, so add the node back". >>> >>> Regards, >>> Bjorn >>> >>>> Signed-off-by: Yuvaraj Ranganathan <quic_yrangana@quicinc.com> >>>> --- >>>> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 12 ++++++++++++ >>>> 1 file changed, 12 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >>>> index 23049cc58896..b0d77b109305 100644 >>>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi >>>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >>>> @@ -2418,6 +2418,18 @@ cryptobam: dma-controller@1dc4000 { >>>> <&apps_smmu 0x481 0x00>; >>>> }; >>>> >>>> + crypto: crypto@1dfa000 { >>>> + compatible = "qcom,sa8775p-qce", "qcom,sm8150-qce", "qcom,qce"; >>>> + reg = <0x0 0x01dfa000 0x0 0x6000>; >>>> + dmas = <&cryptobam 4>, <&cryptobam 5>; >>>> + dma-names = "rx", "tx"; >>>> + iommus = <&apps_smmu 0x480 0x00>, >>>> + <&apps_smmu 0x481 0x00>; >>>> + interconnects = <&aggre2_noc MASTER_CRYPTO_CORE0 0 >>>> + &mc_virt SLAVE_EBI1 0>; >>>> + interconnect-names = "memory"; >>>> + }; >>>> + >>>> stm: stm@4002000 { >>>> compatible = "arm,coresight-stm", "arm,primecell"; >>>> reg = <0x0 0x4002000 0x0 0x1000>, >>>> -- >>>> 2.34.1 >>>> >> >> DeviceTree bindings were accepted but the comptabile string does not >> properly bind to it. Hence, adding the correct binding string in the >> compatible has resolved the issue. >> > > Please then write that in the commit message. > > > That said, what did you base this patch on? While I have picked > Krzysztof's two reverts in my local tree, I have not yet published them. > So your patch is not even based on v6.14-rc1, which now is 4 weeks old. > > Patches sent upstream should be built and tested on a suitable upstream > branch! I sent reverts because author, even though pinged more than once (!), ignored reported problems. It seems that reverting the code gets some attention, so maybe author will fix the original issue and my reverts can be dropped/ignored. Best regards, Krzysztof
On 3/1/2025 7:06 PM, Krzysztof Kozlowski wrote: > On 28/02/2025 15:14, Bjorn Andersson wrote: >> On Fri, Feb 28, 2025 at 11:01:16AM +0530, Yuvaraj Ranganathan wrote: >>> On 2/28/2025 5:56 AM, Bjorn Andersson wrote: >>>> On Thu, Feb 27, 2025 at 11:38:16PM +0530, Yuvaraj Ranganathan wrote: >>>>> The initial QCE node change is reverted by the following patch >>>> >>>> s/is/was/ >>>> >>>>> https://lore.kernel.org/all/20250128115333.95021-1-krzysztof.kozlowski@linaro.org/ >>>>> because of the build warning, >>>>> >>>>> sa8775p-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: >>>>> ... >>>>> 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] >>>>> >>>>> Add the QCE node back that fix the warnings. >>>>> >>>> >>>> Are you saying that adding this node back will fix the warning? >>>> >>>> I'd expect that you would say something like "The changes to the >>>> Devicetree binding has accepted, so add the node back". >>>> >>>> Regards, >>>> Bjorn >>>> >>>>> Signed-off-by: Yuvaraj Ranganathan <quic_yrangana@quicinc.com> >>>>> --- >>>>> arch/arm64/boot/dts/qcom/sa8775p.dtsi | 12 ++++++++++++ >>>>> 1 file changed, 12 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >>>>> index 23049cc58896..b0d77b109305 100644 >>>>> --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi >>>>> +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi >>>>> @@ -2418,6 +2418,18 @@ cryptobam: dma-controller@1dc4000 { >>>>> <&apps_smmu 0x481 0x00>; >>>>> }; >>>>> >>>>> + crypto: crypto@1dfa000 { >>>>> + compatible = "qcom,sa8775p-qce", "qcom,sm8150-qce", "qcom,qce"; >>>>> + reg = <0x0 0x01dfa000 0x0 0x6000>; >>>>> + dmas = <&cryptobam 4>, <&cryptobam 5>; >>>>> + dma-names = "rx", "tx"; >>>>> + iommus = <&apps_smmu 0x480 0x00>, >>>>> + <&apps_smmu 0x481 0x00>; >>>>> + interconnects = <&aggre2_noc MASTER_CRYPTO_CORE0 0 >>>>> + &mc_virt SLAVE_EBI1 0>; >>>>> + interconnect-names = "memory"; >>>>> + }; >>>>> + >>>>> stm: stm@4002000 { >>>>> compatible = "arm,coresight-stm", "arm,primecell"; >>>>> reg = <0x0 0x4002000 0x0 0x1000>, >>>>> -- >>>>> 2.34.1 >>>>> >>> >>> DeviceTree bindings were accepted but the comptabile string does not >>> properly bind to it. Hence, adding the correct binding string in the >>> compatible has resolved the issue. >>> >> >> Please then write that in the commit message. >> >> >> That said, what did you base this patch on? While I have picked >> Krzysztof's two reverts in my local tree, I have not yet published them. >> So your patch is not even based on v6.14-rc1, which now is 4 weeks old. >> >> Patches sent upstream should be built and tested on a suitable upstream >> branch! > > I sent reverts because author, even though pinged more than once (!), > ignored reported problems. > > It seems that reverting the code gets some attention, so maybe author > will fix the original issue and my reverts can be dropped/ignored. > > Best regards, > Krzysztof The original issue was not observed at our end during the first time validation and its due to some environment issue. This patch does resolves the issue and it is validated against the linux-next master branch. Thanks, Yuvaraj.
On 27/02/2025 19:08, Yuvaraj Ranganathan wrote: > The initial QCE node change is reverted by the following patch > https://lore.kernel.org/all/20250128115333.95021-1-krzysztof.kozlowski@linaro.org/ Use commit SHA syntax (see submitting patches, checkpatch). > because of the build warning, > > sa8775p-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: > ... > 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] Not relevant warning. Best regards, Krzysztof
On Thu, Feb 27, 2025 at 11:38:16PM +0530, Yuvaraj Ranganathan wrote: > The initial QCE node change is reverted by the following patch > https://lore.kernel.org/all/20250128115333.95021-1-krzysztof.kozlowski@linaro.org/ > because of the build warning, > > sa8775p-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: > ... > 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] > > Add the QCE node back that fix the warnings. > > Signed-off-by: Yuvaraj Ranganathan <quic_yrangana@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 23049cc58896..b0d77b109305 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -2418,6 +2418,18 @@ cryptobam: dma-controller@1dc4000 { > <&apps_smmu 0x481 0x00>; > }; > > + crypto: crypto@1dfa000 { > + compatible = "qcom,sa8775p-qce", "qcom,sm8150-qce", "qcom,qce"; > + reg = <0x0 0x01dfa000 0x0 0x6000>; > + dmas = <&cryptobam 4>, <&cryptobam 5>; > + dma-names = "rx", "tx"; > + iommus = <&apps_smmu 0x480 0x00>, > + <&apps_smmu 0x481 0x00>; > + interconnects = <&aggre2_noc MASTER_CRYPTO_CORE0 0 > + &mc_virt SLAVE_EBI1 0>; QCOM_ICC_TAG_ALWAYS > + interconnect-names = "memory"; > + }; > + > stm: stm@4002000 { > compatible = "arm,coresight-stm", "arm,primecell"; > reg = <0x0 0x4002000 0x0 0x1000>, > -- > 2.34.1 >
On 3/25/2025 1:00 PM, Krzysztof Kozlowski wrote: > On 27/02/2025 19:08, Yuvaraj Ranganathan wrote: >> The initial QCE node change is reverted by the following patch >> https://lore.kernel.org/all/20250128115333.95021-1-krzysztof.kozlowski@linaro.org/ > > Use commit SHA syntax (see submitting patches, checkpatch). > >> because of the build warning, >> >> sa8775p-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: >> ... >> 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] > > Not relevant warning. > > > > Best regards, > Krzysztof Are you saying this is not the warning seen at merging? Thanks, Yuvaraj.
On 26/03/2025 18:40, Yuvaraj Ranganathan wrote: > On 3/25/2025 1:00 PM, Krzysztof Kozlowski wrote: >> On 27/02/2025 19:08, Yuvaraj Ranganathan wrote: >>> The initial QCE node change is reverted by the following patch >>> https://lore.kernel.org/all/20250128115333.95021-1-krzysztof.kozlowski@linaro.org/ >> >> Use commit SHA syntax (see submitting patches, checkpatch). >> >>> because of the build warning, >>> >>> sa8775p-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: >>> ... >>> 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] >> >> Not relevant warning. >> >> >> >> Best regards, >> Krzysztof > > Are you saying this is not the warning seen at merging? Tell me how it is relevant? Tell me how can I reproduce it. Best regards, Krzysztof
On 3/27/2025 12:38 PM, Krzysztof Kozlowski wrote: > On 26/03/2025 18:40, Yuvaraj Ranganathan wrote: >> On 3/25/2025 1:00 PM, Krzysztof Kozlowski wrote: >>> On 27/02/2025 19:08, Yuvaraj Ranganathan wrote: >>>> The initial QCE node change is reverted by the following patch >>>> https://lore.kernel.org/all/20250128115333.95021-1-krzysztof.kozlowski@linaro.org/ >>> >>> Use commit SHA syntax (see submitting patches, checkpatch). >>> >>>> because of the build warning, >>>> >>>> sa8775p-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: >>>> ... >>>> 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] >>> >>> Not relevant warning. >>> >>> >>> >>> Best regards, >>> Krzysztof >> >> Are you saying this is not the warning seen at merging? > Tell me how it is relevant? Tell me how can I reproduce it. > > Best regards, > Krzysztof Below commands will show the above warnings without the fix, make clean && make qcom/qcs9100-ride.dtb CHECK_DTBS=1 make clean && make qcom/qcs8300-ride.dtb CHECK_DTBS=1 Thanks, Yuvaraj.
On 28/03/2025 07:04, Yuvaraj Ranganathan wrote: >>>> Use commit SHA syntax (see submitting patches, checkpatch). >>>> >>>>> because of the build warning, >>>>> >>>>> sa8775p-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: >>>>> ... >>>>> 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] >>>> >>>> Not relevant warning. >>>> >>>> >>>> >>>> Best regards, >>>> Krzysztof >>> >>> Are you saying this is not the warning seen at merging? >> Tell me how it is relevant? Tell me how can I reproduce it. >> >> Best regards, >> Krzysztof > > Below commands will show the above warnings without the fix, > make clean && make qcom/qcs9100-ride.dtb CHECK_DTBS=1 > make clean && make qcom/qcs8300-ride.dtb CHECK_DTBS=1 As I suspected, not possible to reproduce. Best regards, Krzysztof
On 3/28/2025 12:47 PM, Krzysztof Kozlowski wrote: > On 28/03/2025 07:04, Yuvaraj Ranganathan wrote: >>>>> Use commit SHA syntax (see submitting patches, checkpatch). >>>>> >>>>>> because of the build warning, >>>>>> >>>>>> sa8775p-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: >>>>>> ... >>>>>> 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] >>>>> >>>>> Not relevant warning. >>>>> >>>>> >>>>> >>>>> Best regards, >>>>> Krzysztof >>>> >>>> Are you saying this is not the warning seen at merging? >>> Tell me how it is relevant? Tell me how can I reproduce it. >>> >>> Best regards, >>> Krzysztof >> >> Below commands will show the above warnings without the fix, >> make clean && make qcom/qcs9100-ride.dtb CHECK_DTBS=1 >> make clean && make qcom/qcs8300-ride.dtb CHECK_DTBS=1 > > As I suspected, not possible to reproduce. > > Best regards, > Krzysztof I'm able to reproduce without this fix, I hope you are discussing about this failure only, from schema $id: http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# /local/mnt/workspace/K2L/upstream-kernel/linux-tree/arch/arm64/boot/dts/qcom/qcs9100-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: ['qcom,sa8775p-qce', 'qcom,qce'] is too long ['qcom,sa8775p-qce', 'qcom,qce'] is too short 'qcom,crypto-v5.1' was expected 'qcom,crypto-v5.4' was expected 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] 'qcom,sa8775p-qce' is not one of ['qcom,ipq6018-qce', 'qcom,ipq8074-qce', 'qcom,ipq9574-qce', 'qcom,msm8996-qce', 'qcom,qcm2290-qce', 'qcom,sdm845-qce', 'qcom,sm6115-qce'] 'qcom,ipq4019-qce' was expected 'qcom,sm8150-qce' was expected Thanks, Yuvaraj.
On 28/03/2025 09:32, Yuvaraj Ranganathan wrote: > > > On 3/28/2025 12:47 PM, Krzysztof Kozlowski wrote: >> On 28/03/2025 07:04, Yuvaraj Ranganathan wrote: >>>>>> Use commit SHA syntax (see submitting patches, checkpatch). >>>>>> >>>>>>> because of the build warning, >>>>>>> >>>>>>> sa8775p-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: >>>>>>> ... >>>>>>> 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] >>>>>> >>>>>> Not relevant warning. >>>>>> >>>>>> >>>>>> >>>>>> Best regards, >>>>>> Krzysztof >>>>> >>>>> Are you saying this is not the warning seen at merging? >>>> Tell me how it is relevant? Tell me how can I reproduce it. >>>> >>>> Best regards, >>>> Krzysztof >>> >>> Below commands will show the above warnings without the fix, >>> make clean && make qcom/qcs9100-ride.dtb CHECK_DTBS=1 >>> make clean && make qcom/qcs8300-ride.dtb CHECK_DTBS=1 >> >> As I suspected, not possible to reproduce. >> >> Best regards, >> Krzysztof > > I'm able to reproduce without this fix, I hope you are discussing about > this failure only, > > from schema $id: > http://devicetree.org/schemas/net/bluetooth/qualcomm-bluetooth.yaml# I suspect you work on outdated tree. I followed your instructions on my tree (you did not specify which) and did not see these errors. I bet you reply now third time, without any more details claiming the same but it's just waste of my time. Best regards, Krzysztof
On Fri, Mar 28, 2025 at 11:34:58AM +0530, Yuvaraj Ranganathan wrote: > > > On 3/27/2025 12:38 PM, Krzysztof Kozlowski wrote: > > On 26/03/2025 18:40, Yuvaraj Ranganathan wrote: > >> On 3/25/2025 1:00 PM, Krzysztof Kozlowski wrote: > >>> On 27/02/2025 19:08, Yuvaraj Ranganathan wrote: > >>>> The initial QCE node change is reverted by the following patch > >>>> https://lore.kernel.org/all/20250128115333.95021-1-krzysztof.kozlowski@linaro.org/ > >>> > >>> Use commit SHA syntax (see submitting patches, checkpatch). > >>> > >>>> because of the build warning, > >>>> > >>>> sa8775p-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: > >>>> ... > >>>> 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] > >>> > >>> Not relevant warning. > >>> > >>> > >>> > >>> Best regards, > >>> Krzysztof > >> > >> Are you saying this is not the warning seen at merging? > > Tell me how it is relevant? Tell me how can I reproduce it. > > > > Best regards, > > Krzysztof > > Below commands will show the above warnings without the fix, > make clean && make qcom/qcs9100-ride.dtb CHECK_DTBS=1 > make clean && make qcom/qcs8300-ride.dtb CHECK_DTBS=1 You are probably running those commands on a tree where the patch was not reverted. That's useless. Please update your patches to stop mentioning the (outdated) warning and just describe your changes (i.e. adding the QCE nodes, you are not fixing any warnings with your change).
On 3/28/25 1:48 PM, Dmitry Baryshkov wrote: > On Fri, Mar 28, 2025 at 11:34:58AM +0530, Yuvaraj Ranganathan wrote: >> >> >> On 3/27/2025 12:38 PM, Krzysztof Kozlowski wrote: >>> On 26/03/2025 18:40, Yuvaraj Ranganathan wrote: >>>> On 3/25/2025 1:00 PM, Krzysztof Kozlowski wrote: >>>>> On 27/02/2025 19:08, Yuvaraj Ranganathan wrote: >>>>>> The initial QCE node change is reverted by the following patch >>>>>> https://lore.kernel.org/all/20250128115333.95021-1-krzysztof.kozlowski@linaro.org/ >>>>> >>>>> Use commit SHA syntax (see submitting patches, checkpatch). >>>>> >>>>>> because of the build warning, >>>>>> >>>>>> sa8775p-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: >>>>>> ... >>>>>> 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] >>>>> >>>>> Not relevant warning. >>>>> >>>>> >>>>> >>>>> Best regards, >>>>> Krzysztof >>>> >>>> Are you saying this is not the warning seen at merging? >>> Tell me how it is relevant? Tell me how can I reproduce it. >>> >>> Best regards, >>> Krzysztof >> >> Below commands will show the above warnings without the fix, >> make clean && make qcom/qcs9100-ride.dtb CHECK_DTBS=1 >> make clean && make qcom/qcs8300-ride.dtb CHECK_DTBS=1 > > You are probably running those commands on a tree where the patch was > not reverted. That's useless. Please update your patches to stop > mentioning the (outdated) warning and just describe your changes (i.e. > adding the QCE nodes, you are not fixing any warnings with your change). (please use linux-next/master unless asked otherwise) Konrad
diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi index 23049cc58896..b0d77b109305 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi @@ -2418,6 +2418,18 @@ cryptobam: dma-controller@1dc4000 { <&apps_smmu 0x481 0x00>; }; + crypto: crypto@1dfa000 { + compatible = "qcom,sa8775p-qce", "qcom,sm8150-qce", "qcom,qce"; + reg = <0x0 0x01dfa000 0x0 0x6000>; + dmas = <&cryptobam 4>, <&cryptobam 5>; + dma-names = "rx", "tx"; + iommus = <&apps_smmu 0x480 0x00>, + <&apps_smmu 0x481 0x00>; + interconnects = <&aggre2_noc MASTER_CRYPTO_CORE0 0 + &mc_virt SLAVE_EBI1 0>; + interconnect-names = "memory"; + }; + stm: stm@4002000 { compatible = "arm,coresight-stm", "arm,primecell"; reg = <0x0 0x4002000 0x0 0x1000>,
The initial QCE node change is reverted by the following patch https://lore.kernel.org/all/20250128115333.95021-1-krzysztof.kozlowski@linaro.org/ because of the build warning, sa8775p-ride.dtb: crypto@1dfa000: compatible: 'oneOf' conditional failed, one must be fixed: ... 'qcom,sa8775p-qce' is not one of ['qcom,ipq4019-qce', 'qcom,sm8150-qce'] Add the QCE node back that fix the warnings. Signed-off-by: Yuvaraj Ranganathan <quic_yrangana@quicinc.com> --- arch/arm64/boot/dts/qcom/sa8775p.dtsi | 12 ++++++++++++ 1 file changed, 12 insertions(+)