diff mbox series

[*-next,15/18] mfd: db8500-prcmu: Remove needless return in three void APIs

Message ID 20250221-rmv_return-v1-15-cc8dff275827@quicinc.com
State New
Headers show
Series Remove weird and needless 'return' for void APIs | expand

Commit Message

Zijun Hu Feb. 21, 2025, 1:02 p.m. UTC 
Remove needless 'return' in the following void APIs:

 prcmu_early_init()
 prcmu_system_reset()
 prcmu_modem_reset()

Since both the API and callee involved are void functions.

Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>
---
 include/linux/mfd/dbx500-prcmu.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Linus Walleij Feb. 27, 2025, 11:12 p.m. UTC | #1 
On Fri, Feb 21, 2025 at 2:03 PM Zijun Hu <quic_zijuhu@quicinc.com> wrote:

> Remove needless 'return' in the following void APIs:
>
>  prcmu_early_init()
>  prcmu_system_reset()
>  prcmu_modem_reset()
>
> Since both the API and callee involved are void functions.
>
> Signed-off-by: Zijun Hu <quic_zijuhu@quicinc.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij
Lee Jones March 13, 2025, 1:03 p.m. UTC | #2 
On Fri, 21 Feb 2025 05:02:20 -0800, Zijun Hu wrote:
> Remove needless 'return' in the following void APIs:
> 
>  prcmu_early_init()
>  prcmu_system_reset()
>  prcmu_modem_reset()
> 
> Since both the API and callee involved are void functions.
> 
> [...]

Applied, thanks!

[15/18] mfd: db8500-prcmu: Remove needless return in three void APIs
        commit: ccf5c7a8e5b9fe7c36d8c384f8f7c495f45c63a0

--
Lee Jones [李琼斯]
diff mbox series

Patch

diff --git a/include/linux/mfd/dbx500-prcmu.h b/include/linux/mfd/dbx500-prcmu.h
index dd0fc891b228..98567623c9df 100644
--- a/include/linux/mfd/dbx500-prcmu.h
+++ b/include/linux/mfd/dbx500-prcmu.h
@@ -215,7 +215,7 @@  struct prcmu_fw_version {
 
 static inline void prcmu_early_init(void)
 {
-	return db8500_prcmu_early_init();
+	db8500_prcmu_early_init();
 }
 
 static inline int prcmu_set_power_state(u8 state, bool keep_ulp_clk,
@@ -302,7 +302,7 @@  static inline int prcmu_request_ape_opp_100_voltage(bool enable)
 
 static inline void prcmu_system_reset(u16 reset_code)
 {
-	return db8500_prcmu_system_reset(reset_code);
+	db8500_prcmu_system_reset(reset_code);
 }
 
 static inline u16 prcmu_get_reset_code(void)
@@ -314,7 +314,7 @@  int prcmu_ac_wake_req(void);
 void prcmu_ac_sleep_req(void);
 static inline void prcmu_modem_reset(void)
 {
-	return db8500_prcmu_modem_reset();
+	db8500_prcmu_modem_reset();
 }
 
 static inline bool prcmu_is_ac_wake_requested(void)