| Message ID | 20250220074657.120288-1-janusz.dziedzic@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | wifi: nl80211: report real HE length | expand |
pt., 21 lut 2025 o 19:40 Jeff Johnson <jeff.johnson@oss.qualcomm.com> napisał(a): > > On 2/19/2025 11:46 PM, Janusz Dziedzic wrote: > > Report real length for: > > - supported HE-MCS and NSS set > > - PPE Thresholds > > Are there observable issues with the current code? If so, perhaps describe > them so that anybody with similar issues will be able to find this patch via a > search engine? > Not critical one. Just found it in my app when parse nl80211 HE caps. > Is a Fixes: tag warranted? > While not critical, no. > > > > Signed-off-by: Janusz Dziedzic <janusz.dziedzic@gmail.com> > > Actual code LGTM, > Reviewed-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com> > > > --- > > net/wireless/nl80211.c | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c > > index 8bd09110d393..c0772e24cc2e 100644 > > --- a/net/wireless/nl80211.c > > +++ b/net/wireless/nl80211.c > > @@ -1873,6 +1873,12 @@ nl80211_send_iftype_data(struct sk_buff *msg, > > return -ENOBUFS; > > > > if (he_cap->has_he) { > > + u8 mcs_nss_size, ppe_thresh_size; > > + > > + mcs_nss_size = ieee80211_he_mcs_nss_size(&he_cap->he_cap_elem); > > + ppe_thresh_size = ieee80211_he_ppe_size(he_cap->ppe_thres[0], > > + he_cap->he_cap_elem.phy_cap_info); > > + > > if (nla_put(msg, NL80211_BAND_IFTYPE_ATTR_HE_CAP_MAC, > > sizeof(he_cap->he_cap_elem.mac_cap_info), > > he_cap->he_cap_elem.mac_cap_info) || > > @@ -1880,10 +1886,9 @@ nl80211_send_iftype_data(struct sk_buff *msg, > > sizeof(he_cap->he_cap_elem.phy_cap_info), > > he_cap->he_cap_elem.phy_cap_info) || > > nla_put(msg, NL80211_BAND_IFTYPE_ATTR_HE_CAP_MCS_SET, > > - sizeof(he_cap->he_mcs_nss_supp), > > - &he_cap->he_mcs_nss_supp) || > > + mcs_nss_size, &he_cap->he_mcs_nss_supp) || > > nla_put(msg, NL80211_BAND_IFTYPE_ATTR_HE_CAP_PPE, > > - sizeof(he_cap->ppe_thres), he_cap->ppe_thres)) > > + ppe_thresh_size, he_cap->ppe_thres)) > > return -ENOBUFS; > > } > > >
diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 8bd09110d393..c0772e24cc2e 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -1873,6 +1873,12 @@ nl80211_send_iftype_data(struct sk_buff *msg, return -ENOBUFS; if (he_cap->has_he) { + u8 mcs_nss_size, ppe_thresh_size; + + mcs_nss_size = ieee80211_he_mcs_nss_size(&he_cap->he_cap_elem); + ppe_thresh_size = ieee80211_he_ppe_size(he_cap->ppe_thres[0], + he_cap->he_cap_elem.phy_cap_info); + if (nla_put(msg, NL80211_BAND_IFTYPE_ATTR_HE_CAP_MAC, sizeof(he_cap->he_cap_elem.mac_cap_info), he_cap->he_cap_elem.mac_cap_info) || @@ -1880,10 +1886,9 @@ nl80211_send_iftype_data(struct sk_buff *msg, sizeof(he_cap->he_cap_elem.phy_cap_info), he_cap->he_cap_elem.phy_cap_info) || nla_put(msg, NL80211_BAND_IFTYPE_ATTR_HE_CAP_MCS_SET, - sizeof(he_cap->he_mcs_nss_supp), - &he_cap->he_mcs_nss_supp) || + mcs_nss_size, &he_cap->he_mcs_nss_supp) || nla_put(msg, NL80211_BAND_IFTYPE_ATTR_HE_CAP_PPE, - sizeof(he_cap->ppe_thres), he_cap->ppe_thres)) + ppe_thresh_size, he_cap->ppe_thres)) return -ENOBUFS; }
Report real length for: - supported HE-MCS and NSS set - PPE Thresholds Signed-off-by: Janusz Dziedzic <janusz.dziedzic@gmail.com> --- net/wireless/nl80211.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)