| Message ID | 20250213005841.4143929-2-tony.obrien@alliedtelesis.co.nz |
|---|---|
| State | New |
| Headers | show |
| Series | dt-bindings:leds: Add function define for POE | expand |
Hi Krzysztof - > Where did these two reviews happen? They were in-house reviews. Please feel free to remove them from the patch. > Where is any user of this? We are adding Kernel control of PoE LEDs and thought this might be useful to others, maybe those working on netdev, or anyone implementing PoE on their devices. Also, the Kernel >> Docs >> LEDs page states: "If required color or function is missing, please submit a patch to linux-leds@vger.kernel.org", which is included here. Cheers, Tony O'Brien On Thu, 2025-02-13 at 10:31 +0100, Krzysztof Kozlowski wrote: > On Thu, Feb 13, 2025 at 01:58:41PM +1300, Tony O'Brien wrote: > > Add a define so network devices with a PoE PSE feature can provide > > status indications of connected PoE PDs. > > > > Reviewed-by: Ben Hoelker <ben.hoelker@alliedtelesis.co.nz> > > Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz> > > Where did these two reviews happen? > > > Signed-off-by: Tony O'Brien <tony.obrien@alliedtelesis.co.nz> > > --- > > include/dt-bindings/leds/common.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/include/dt-bindings/leds/common.h b/include/dt- > > bindings/leds/common.h > > index 4f017bea0123..3a8958b81c87 100644 > > --- a/include/dt-bindings/leds/common.h > > +++ b/include/dt-bindings/leds/common.h > > @@ -94,6 +94,7 @@ > > #define LED_FUNCTION_MOBILE "mobile" > > #define LED_FUNCTION_MTD "mtd" > > #define LED_FUNCTION_PANIC "panic" > > +#define LED_FUNCTION_POE "poe" > > Where is any user of this? > > Best regards, > Krzysztof >
On 16/02/2025 22:37, Tony O'Brien wrote: > Hi Krzysztof - > >> Where did these two reviews happen? > They were in-house reviews. Please feel free to remove them from the > patch. > >> Where is any user of this? > We are adding Kernel control of PoE LEDs and thought this might be > useful to others, maybe those working on netdev, or anyone implementing > PoE on their devices. Also, the Kernel >> Docs >> LEDs page states: > "If required color or function is missing, please submit a patch to > linux-leds@vger.kernel.org", which is included here. You did not answer: where is the user? By "we are adding" you mean downstream? Best regards, Krzysztof
diff --git a/include/dt-bindings/leds/common.h b/include/dt-bindings/leds/common.h index 4f017bea0123..3a8958b81c87 100644 --- a/include/dt-bindings/leds/common.h +++ b/include/dt-bindings/leds/common.h @@ -94,6 +94,7 @@ #define LED_FUNCTION_MOBILE "mobile" #define LED_FUNCTION_MTD "mtd" #define LED_FUNCTION_PANIC "panic" +#define LED_FUNCTION_POE "poe" #define LED_FUNCTION_PROGRAMMING "programming" #define LED_FUNCTION_RX "rx" #define LED_FUNCTION_SD "sd"