diff mbox

usb: gadget: uvc: fix UVC_ATTR macro for UVCG_OPTS_ATTR

Message ID 1480659722-3344-1-git-send-email-jassisinghbrar@gmail.com
State New
Headers show

Commit Message

Jassi Brar Dec. 2, 2016, 6:22 a.m. UTC 
From: Jassi Brar <jaswinder.singh@linaro.org>


Typo in commit 76e0da34c7cec5a7d introduced a bug that prevents
creation of streaming_{interval,maxpacket,maxburst} nodes for
invalid 'aname' node.

Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>

---
 drivers/usb/gadget/function/uvc_configfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Greg KH Dec. 2, 2016, 6:56 a.m. UTC | #1 
On Fri, Dec 02, 2016 at 11:52:02AM +0530, Jassi Brar wrote:
> From: Jassi Brar <jaswinder.singh@linaro.org>

> 

> Typo in commit 76e0da34c7cec5a7d introduced a bug that prevents

> creation of streaming_{interval,maxpacket,maxburst} nodes for

> invalid 'aname' node.

> 

> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>


Fixes: tag?
cc: stable tag?

Come on, you know better than this...

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sergei Shtylyov Dec. 2, 2016, 10:25 a.m. UTC | #2 
Hello!

On 12/2/2016 9:22 AM, Jassi Brar wrote:

> From: Jassi Brar <jaswinder.singh@linaro.org>

>

> Typo in commit 76e0da34c7cec5a7d introduced a bug that prevents


    scripts/checkpatch.pl didn't complain about the commit citing style?
You forgot to specify the summary line enclosed in ("").

> creation of streaming_{interval,maxpacket,maxburst} nodes for

> invalid 'aname' node.

>

> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>

[...]

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Laurent Pinchart Dec. 2, 2016, 8:34 p.m. UTC | #3 
On Friday 02 Dec 2016 07:56:32 Greg KH wrote:
> On Fri, Dec 02, 2016 at 11:52:02AM +0530, Jassi Brar wrote:

> > From: Jassi Brar <jaswinder.singh@linaro.org>

> > 

> > Typo in commit 76e0da34c7cec5a7d introduced a bug that prevents

> > creation of streaming_{interval,maxpacket,maxburst} nodes for

> > invalid 'aname' node.

> > 

> > Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>

> 

> Fixes: tag?

> cc: stable tag?

> 

> Come on, you know better than this...


Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>


-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/usb/gadget/function/uvc_configfs.c b/drivers/usb/gadget/function/uvc_configfs.c
index ecb5614..158849e 100644
--- a/drivers/usb/gadget/function/uvc_configfs.c
+++ b/drivers/usb/gadget/function/uvc_configfs.c
@@ -2245,7 +2245,7 @@  end:									\
 	return ret;							\
 }									\
 									\
-UVC_ATTR(f_uvc_opts_, cname, aname)
+UVC_ATTR(f_uvc_opts_, cname, cname)
 
 #define identity_conv(x) (x)