| Message ID | 20250204-must_check-devm_mutex_init-v2-1-7b6271c4b7e6@weissschuh.net |
|---|---|
| State | Superseded |
| Headers | show |
| Series | locking/mutex: Mark devm_mutex_init() as __must_check | expand |
On Tue, 04 Feb 2025 07:52:50 +0100, Thomas Weißschuh wrote: > Even if it's not critical, the avoidance of checking the error code > from devm_mutex_init() call today diminishes the point of using devm > variant of it. Tomorrow it may even leak something. Add the missed > check. > > Applied, thanks! [1/2] leds: st1202: Check for error code from devm_mutex_init() call commit: 8168906bbb3ba678583422de29e6349407a94bb5 -- Lee Jones [李琼斯]
diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c index b691c4886993f3e371e857543863c9a724742f39..657c62cb24fa726622369fc965fa7195e73170f0 100644 --- a/drivers/leds/leds-st1202.c +++ b/drivers/leds/leds-st1202.c @@ -356,7 +356,9 @@ static int st1202_probe(struct i2c_client *client) if (!chip) return -ENOMEM; - devm_mutex_init(&client->dev, &chip->lock); + ret = devm_mutex_init(&client->dev, &chip->lock); + if (ret < 0) + return ret; chip->client = client; ret = st1202_dt_init(chip);
Even if it's not critical, the avoidance of checking the error code from devm_mutex_init() call today diminishes the point of using devm variant of it. Tomorrow it may even leak something. Add the missed check. Fixes: 259230378c65 ("leds: Add LED1202 I2C driver") Signed-off-by: Thomas Weißschuh <linux@weissschuh.net> --- drivers/leds/leds-st1202.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)