| Message ID | 3bed95a7-5808-3558-fefb-064649788e62@denx.de |
|---|---|
| State | New |
| Headers | show |
On 2 December 2016 at 04:02, Marek Vasut <marex@denx.de> wrote: > Hi, > > as asked by Daniel, I collected the MXSFB DT Acks and the driver and > wrapped it into PR (below). Hi Marek this isn't pullable as-is as it seems to be based on -next tree or something. Please create pull requests based on a Linus or drm-next base, Dave.
On Tue, Dec 06, 2016 at 11:08:06AM +1000, Dave Airlie wrote: > On 2 December 2016 at 04:02, Marek Vasut <marex@denx.de> wrote: > > Hi, > > > > as asked by Daniel, I collected the MXSFB DT Acks and the driver and > > wrapped it into PR (below). > > Hi Marek > > this isn't pullable as-is as it seems to be based on -next tree or something. > > Please create pull requests based on a Linus or drm-next base, Please base on drm-next, to make sure you can (and do) use latest drm code with all the latest refactorings applied. -Daniel
On 12/06/2016 08:53 AM, Daniel Vetter wrote: > On Tue, Dec 06, 2016 at 11:08:06AM +1000, Dave Airlie wrote: >> On 2 December 2016 at 04:02, Marek Vasut <marex@denx.de> wrote: >>> Hi, >>> >>> as asked by Daniel, I collected the MXSFB DT Acks and the driver and >>> wrapped it into PR (below). >> >> Hi Marek >> >> this isn't pullable as-is as it seems to be based on -next tree or something. >> >> Please create pull requests based on a Linus or drm-next base, > > Please base on drm-next, to make sure you can (and do) use latest drm code > with all the latest refactorings applied. Yeah, already done.
On 2016-12-06 04:36, Marek Vasut wrote: > On 12/06/2016 08:53 AM, Daniel Vetter wrote: >> On Tue, Dec 06, 2016 at 11:08:06AM +1000, Dave Airlie wrote: >>> On 2 December 2016 at 04:02, Marek Vasut <marex@denx.de> wrote: >>>> Hi, >>>> >>>> as asked by Daniel, I collected the MXSFB DT Acks and the driver and >>>> wrapped it into PR (below). >>> >>> Hi Marek >>> >>> this isn't pullable as-is as it seems to be based on -next tree or something. >>> >>> Please create pull requests based on a Linus or drm-next base, >> >> Please base on drm-next, to make sure you can (and do) use latest drm code >> with all the latest refactorings applied. > > Yeah, already done. Just tried to build drm-next/mxsfb I get: drivers/built-in.o: In function `mxsfb_probe': core.c:(.text+0x9ce9c): undefined reference to `drm_panel_attach' core.c:(.text+0x9cff0): undefined reference to `drm_panel_detach' drivers/built-in.o: In function `mxsfb_panel_connector_destroy': core.c:(.text+0x9d614): undefined reference to `drm_panel_detach' drivers/built-in.o: In function `mxsfb_create_output': core.c:(.text+0x9d68c): undefined reference to `of_drm_find_panel' make: *** [Makefile:962: vmlinux] Error 1 I guess there is a select DRM_PANEL missing. -- Stefan
On 12/07/2016 08:22 PM, Stefan Agner wrote: > On 2016-12-06 04:36, Marek Vasut wrote: >> On 12/06/2016 08:53 AM, Daniel Vetter wrote: >>> On Tue, Dec 06, 2016 at 11:08:06AM +1000, Dave Airlie wrote: >>>> On 2 December 2016 at 04:02, Marek Vasut <marex@denx.de> wrote: >>>>> Hi, >>>>> >>>>> as asked by Daniel, I collected the MXSFB DT Acks and the driver and >>>>> wrapped it into PR (below). >>>> >>>> Hi Marek >>>> >>>> this isn't pullable as-is as it seems to be based on -next tree or something. >>>> >>>> Please create pull requests based on a Linus or drm-next base, >>> >>> Please base on drm-next, to make sure you can (and do) use latest drm code >>> with all the latest refactorings applied. >> >> Yeah, already done. > > Just tried to build drm-next/mxsfb I get: > > drivers/built-in.o: In function `mxsfb_probe': > core.c:(.text+0x9ce9c): undefined reference to `drm_panel_attach' > core.c:(.text+0x9cff0): undefined reference to `drm_panel_detach' > drivers/built-in.o: In function `mxsfb_panel_connector_destroy': > core.c:(.text+0x9d614): undefined reference to `drm_panel_detach' > drivers/built-in.o: In function `mxsfb_create_output': > core.c:(.text+0x9d68c): undefined reference to `of_drm_find_panel' > make: *** [Makefile:962: vmlinux] Error 1 > > I guess there is a select DRM_PANEL missing. Aw snap, I think imx_v6_v7_defconfig selects DRM_PANEL already, so this was never caught. Which is the path of least resistance, additional patch or respinning the whole PR ?
>>> Yeah, already done. >> >> Just tried to build drm-next/mxsfb I get: >> >> drivers/built-in.o: In function `mxsfb_probe': >> core.c:(.text+0x9ce9c): undefined reference to `drm_panel_attach' >> core.c:(.text+0x9cff0): undefined reference to `drm_panel_detach' >> drivers/built-in.o: In function `mxsfb_panel_connector_destroy': >> core.c:(.text+0x9d614): undefined reference to `drm_panel_detach' >> drivers/built-in.o: In function `mxsfb_create_output': >> core.c:(.text+0x9d68c): undefined reference to `of_drm_find_panel' >> make: *** [Makefile:962: vmlinux] Error 1 >> >> I guess there is a select DRM_PANEL missing. > > Aw snap, I think imx_v6_v7_defconfig selects DRM_PANEL already, so this > was never caught. Which is the path of least resistance, additional > patch or respinning the whole PR ? Just send patch to list and then a pull request for it. Dave.
On 12/07/2016 09:53 PM, Dave Airlie wrote: >>>> Yeah, already done. >>> >>> Just tried to build drm-next/mxsfb I get: >>> >>> drivers/built-in.o: In function `mxsfb_probe': >>> core.c:(.text+0x9ce9c): undefined reference to `drm_panel_attach' >>> core.c:(.text+0x9cff0): undefined reference to `drm_panel_detach' >>> drivers/built-in.o: In function `mxsfb_panel_connector_destroy': >>> core.c:(.text+0x9d614): undefined reference to `drm_panel_detach' >>> drivers/built-in.o: In function `mxsfb_create_output': >>> core.c:(.text+0x9d68c): undefined reference to `of_drm_find_panel' >>> make: *** [Makefile:962: vmlinux] Error 1 >>> >>> I guess there is a select DRM_PANEL missing. >> >> Aw snap, I think imx_v6_v7_defconfig selects DRM_PANEL already, so this >> was never caught. Which is the path of least resistance, additional >> patch or respinning the whole PR ? > > Just send patch to list and then a pull request for it. > Patch is out, sorry for the hassle.
Hi, as asked by Daniel, I collected the MXSFB DT Acks and the driver and wrapped it into PR (below). -- The following changes since commit 09bfc750ec237029d69ebb749602b6f1304d028a: Add linux-next specific files for 20161125 (2016-11-25 14:11:29 +1100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/marex/linux-2.6.git next/mxsfb for you to fetch changes up to 037c4f02b617383a8d6af6e8d89f4e142ad71470: drm: Add new driver for MXSFB controller (2016-12-01 18:55:17 +0100) ---------------------------------------------------------------- Marek Vasut (3): dt-bindings: mxsfb: Indentation cleanup dt-bindings: mxsfb: Add new bindings for the MXSFB driver drm: Add new driver for MXSFB controller Documentation/devicetree/bindings/display/mxsfb.txt | 53 +++++++++-- MAINTAINERS | 6 ++ drivers/gpu/drm/Kconfig | 2 + drivers/gpu/drm/Makefile | 1 + drivers/gpu/drm/mxsfb/Kconfig | 18 ++++ drivers/gpu/drm/mxsfb/Makefile | 2 + drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 241 ++++++++++++++++++++++++++++++++++++++++++++++ drivers/gpu/drm/mxsfb/mxsfb_drv.c | 444 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ drivers/gpu/drm/mxsfb/mxsfb_drv.h | 54 +++++++++++ drivers/gpu/drm/mxsfb/mxsfb_out.c | 131 +++++++++++++++++++++++++ drivers/gpu/drm/mxsfb/mxsfb_regs.h | 114 ++++++++++++++++++++++ 11 files changed, 1058 insertions(+), 8 deletions(-) create mode 100644 drivers/gpu/drm/mxsfb/Kconfig create mode 100644 drivers/gpu/drm/mxsfb/Makefile create mode 100644 drivers/gpu/drm/mxsfb/mxsfb_crtc.c create mode 100644 drivers/gpu/drm/mxsfb/mxsfb_drv.c create mode 100644 drivers/gpu/drm/mxsfb/mxsfb_drv.h create mode 100644 drivers/gpu/drm/mxsfb/mxsfb_out.c create mode 100644 drivers/gpu/drm/mxsfb/mxsfb_regs.h