| Message ID | CWLP123MB54732954D59EFDB0D344A6DAC5EB2@CWLP123MB5473.GBRP123.PROD.OUTLOOK.COM |
|---|---|
| State | New |
| Headers | show |
| Series | LED1202 / leds-st1202 fixes and improvements | expand |
On Sat, 01 Feb 2025, Manuel Fombuena wrote: > Arguably, there are more chances of errors occurring during the > initialization of the hardware, so this should complete successfully > before the DT node childreen are initialized. Okay. And you're sure nothing in Setup needs the DT info? > Signed-off-by: Manuel Fombuena <fombuena@outlook.com> > --- > drivers/leds/leds-st1202.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c > index e894b3f9a0f4..927874f20839 100644 > --- a/drivers/leds/leds-st1202.c > +++ b/drivers/leds/leds-st1202.c > @@ -348,11 +348,11 @@ static int st1202_probe(struct i2c_client *client) > devm_mutex_init(&client->dev, &chip->lock); > chip->client = client; > > - ret = st1202_dt_init(chip); > + ret = st1202_setup(chip); > if (ret < 0) > return ret; > > - ret = st1202_setup(chip); > + ret = st1202_dt_init(chip); > if (ret < 0) > return ret; > > -- > 2.48.1 >
On Tue, 11 Feb 2025, Lee Jones wrote: > On Sat, 01 Feb 2025, Manuel Fombuena wrote: > > > Arguably, there are more chances of errors occurring during the > > initialization of the hardware, so this should complete successfully > > before the DT node childreen are initialized. > > Okay. And you're sure nothing in Setup needs the DT info? Yes, st1202_setup() doesn't require anything previously done in st1202_dt_init() to do its thing. Additionally, I am not just relying on reviewing the code. I am also carrying out real-world testing on a device I use daily and it works either way. -- Manuel Fombuena
diff --git a/drivers/leds/leds-st1202.c b/drivers/leds/leds-st1202.c index e894b3f9a0f4..927874f20839 100644 --- a/drivers/leds/leds-st1202.c +++ b/drivers/leds/leds-st1202.c @@ -348,11 +348,11 @@ static int st1202_probe(struct i2c_client *client) devm_mutex_init(&client->dev, &chip->lock); chip->client = client; - ret = st1202_dt_init(chip); + ret = st1202_setup(chip); if (ret < 0) return ret; - ret = st1202_setup(chip); + ret = st1202_dt_init(chip); if (ret < 0) return ret;
Arguably, there are more chances of errors occurring during the initialization of the hardware, so this should complete successfully before the DT node childreen are initialized. Signed-off-by: Manuel Fombuena <fombuena@outlook.com> --- drivers/leds/leds-st1202.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)