[v8,08/21] HID: pidff: Add FIX_WHEEL_DIRECTION quirk

Message ID	20250129212935.780998-9-tomasz.pakula.oficjalny@gmail.com
State	New
Headers	show Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E5A11E5020; Wed, 29 Jan 2025 21:29:53 +0000 (UTC) From: =?utf-8?q?Tomasz_Paku=C5=82a?= <tomasz.pakula.oficjalny@gmail.com> To: jikos@kernel.org, bentiss@kernel.org Cc: anssi.hannula@gmail.com, oleg@makarenk.ooo, linux-input@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v8 08/21] HID: pidff: Add FIX_WHEEL_DIRECTION quirk Date: Wed, 29 Jan 2025 22:29:22 +0100 Message-ID: <20250129212935.780998-9-tomasz.pakula.oficjalny@gmail.com> In-Reply-To: <20250129212935.780998-1-tomasz.pakula.oficjalny@gmail.com> References: <20250129212935.780998-1-tomasz.pakula.oficjalny@gmail.com> Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
Series	HID: Upgrade the generic pidff driver and add hid-universal-pidff \| expand [v8,00/21] HID: Upgrade the generic pidff driver and add hid-universal-pidff [v8,01/21] HID: pidff: Convert infinite length from Linux API to PID standard [v8,02/21] HID: pidff: Do not send effect envelope if it's empty [v8,03/21] HID: pidff: Clamp PERIODIC effect period to device's logical range [v8,04/21] HID: pidff: Add MISSING_DELAY quirk and its detection [v8,05/21] HID: pidff: Add MISSING_PBO quirk and its detection [v8,06/21] HID: pidff: Add PERMISSIVE_CONTROL quirk [v8,07/21] HID: pidff: Add hid_pidff_init_with_quirks and export as GPL symbol [v8,08/21] HID: pidff: Add FIX_WHEEL_DIRECTION quirk [v8,09/21] HID: pidff: Stop all effects before enabling actuators [v8,10/21] HID: Add hid-universal-pidff driver and supported device ids [v8,11/21] MAINTAINERS: Add entry for hid-universal-pidff driver [v8,12/21] HID: pidff: Add PERIODIC_SINE_ONLY quirk [v8,13/21] HID: pidff: Completely rework and fix pidff_reset function [v8,14/21] HID: pidff: Simplify pidff_upload_effect function [v8,15/21] HID: pidff: Define values used in pidff_find_special_fields [v8,16/21] HID: pidff: Rescale time values to match field units [v8,17/21] HID: pidff: Factor out code for setting gain [v8,18/21] HID: pidff: Fix null pointer dereference in pidff_find_fields [v8,19/21] HID: pidff: Move all hid-pidff definitions to a dedicated header [v8,20/21] HID: pidff: Simplify pidff_rescale_signed [v8,21/21] HID: pidff: Use macros instead of hardcoded min/max values for shorts

Message ID

20250129212935.780998-9-tomasz.pakula.oficjalny@gmail.com

State

New

Headers

From: =?utf-8?q?Tomasz_Paku=C5=82a?= <tomasz.pakula.oficjalny@gmail.com>
To: jikos@kernel.org,
	bentiss@kernel.org
Cc: anssi.hannula@gmail.com,
	oleg@makarenk.ooo,
	linux-input@vger.kernel.org,
	linux-usb@vger.kernel.org
Subject: [PATCH v8 08/21] HID: pidff: Add FIX_WHEEL_DIRECTION quirk
Date: Wed, 29 Jan 2025 22:29:22 +0100
Message-ID: <20250129212935.780998-9-tomasz.pakula.oficjalny@gmail.com>
In-Reply-To: <20250129212935.780998-1-tomasz.pakula.oficjalny@gmail.com>
References: <20250129212935.780998-1-tomasz.pakula.oficjalny@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Series

HID: Upgrade the generic pidff driver and add hid-universal-pidff | expand

Commit Message

Tomasz Pakuła Jan. 29, 2025, 9:29 p.m. UTC

Most steering wheels simply ignore DIRECTION field, but some try to be
compliant with the PID standard and use it in force calculations. Games
often ignore setting this field properly and/or there can be issues with
dinput8 -> wine -> SDL -> Linux API translation, and this value can be
incorrect. This can lead to partial/complete loss of Force Feedback or
even unexpected force reversal.

Sadly, this quirk can't be detected automatically without sending out
effects that would move an axis.

This fixes FFB on Moza Racing devices and others where effect direction
is not simply ignored.

Signed-off-by: Tomasz Pakuła <tomasz.pakula.oficjalny@gmail.com>
Reviewed-by: Michał Kopeć <michal@nozomi.space>
---
 drivers/hid/usbhid/hid-pidff.c | 12 +++++++++---
 include/linux/hid.h            |  1 +
 2 files changed, 10 insertions(+), 3 deletions(-)

diff --git a/drivers/hid/usbhid/hid-pidff.c b/drivers/hid/usbhid/hid-pidff.c
index 298a971c63fd..9e03dfb2b1e7 100644
--- a/drivers/hid/usbhid/hid-pidff.c
+++ b/drivers/hid/usbhid/hid-pidff.c
@@ -136,6 +136,9 @@  static const u8 pidff_block_load_status[] = { 0x8c, 0x8d };
 #define PID_EFFECT_STOP		1
 static const u8 pidff_effect_operation_status[] = { 0x79, 0x7b };
 
+/* Polar direction 90 degrees (North) */
+#define PIDFF_FIXED_WHEEL_DIRECTION	0x4000
+
 struct pidff_usage {
 	struct hid_field *field;
 	s32 *value;
@@ -337,9 +340,12 @@  static void pidff_set_effect_report(struct pidff_device *pidff,
 	pidff->set_effect[PID_GAIN].value[0] =
 		pidff->set_effect[PID_GAIN].field->logical_maximum;
 	pidff->set_effect[PID_DIRECTION_ENABLE].value[0] = 1;
-	pidff->effect_direction->value[0] =
-		pidff_rescale(effect->direction, 0xffff,
-				pidff->effect_direction);
+
+	/* Use fixed direction if needed */
+	pidff->effect_direction->value[0] = pidff_rescale(
+		pidff->quirks & HID_PIDFF_QUIRK_FIX_WHEEL_DIRECTION ?
+		PIDFF_FIXED_WHEEL_DIRECTION : effect->direction,
+		0xffff, pidff->effect_direction);
 
 	/* Omit setting delay field if it's missing */
 	if (!(pidff->quirks & HID_PIDFF_QUIRK_MISSING_DELAY))
diff --git a/include/linux/hid.h b/include/linux/hid.h
index e6e9081d7dac..856bed149246 100644
--- a/include/linux/hid.h
+++ b/include/linux/hid.h
@@ -1233,6 +1233,7 @@  int hid_pidff_init_with_quirks(struct hid_device *hid, __u32 initial_quirks);
 #define HID_PIDFF_QUIRK_MISSING_DELAY		BIT(0)
 #define HID_PIDFF_QUIRK_MISSING_PBO		BIT(1)
 #define HID_PIDFF_QUIRK_PERMISSIVE_CONTROL	BIT(2)
+#define HID_PIDFF_QUIRK_FIX_WHEEL_DIRECTION	BIT(3)
 
 #define dbg_hid(fmt, ...) pr_debug("%s: " fmt, __FILE__, ##__VA_ARGS__)

[v8,08/21] HID: pidff: Add FIX_WHEEL_DIRECTION quirk

Commit Message

Patch