| Message ID | 20250128135046.4108775-1-peter.maydell@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | target/arm: Drop unused AARCh64DecodeTable typedefs | expand |
On 1/28/25 05:50, Peter Maydell wrote: > We removed the old table-based decoder in favour of decodetree, but > we left a couple of typedefs that are now unused; delete them. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > target/arm/tcg/translate-a64.c | 11 ----------- > 1 file changed, 11 deletions(-) Oops. Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~ > > diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c > index bd814849c19..155169aeafd 100644 > --- a/target/arm/tcg/translate-a64.c > +++ b/target/arm/tcg/translate-a64.c > @@ -75,17 +75,6 @@ static int scale_by_log2_tag_granule(DisasContext *s, int x) > #include "decode-sme-fa64.c.inc" > #include "decode-a64.c.inc" > > -/* Table based decoder typedefs - used when the relevant bits for decode > - * are too awkwardly scattered across the instruction (eg SIMD). > - */ > -typedef void AArch64DecodeFn(DisasContext *s, uint32_t insn); > - > -typedef struct AArch64DecodeTable { > - uint32_t pattern; > - uint32_t mask; > - AArch64DecodeFn *disas_fn; > -} AArch64DecodeTable; > - > /* initialize TCG globals. */ > void a64_translate_init(void) > {
diff --git a/target/arm/tcg/translate-a64.c b/target/arm/tcg/translate-a64.c index bd814849c19..155169aeafd 100644 --- a/target/arm/tcg/translate-a64.c +++ b/target/arm/tcg/translate-a64.c @@ -75,17 +75,6 @@ static int scale_by_log2_tag_granule(DisasContext *s, int x) #include "decode-sme-fa64.c.inc" #include "decode-a64.c.inc" -/* Table based decoder typedefs - used when the relevant bits for decode - * are too awkwardly scattered across the instruction (eg SIMD). - */ -typedef void AArch64DecodeFn(DisasContext *s, uint32_t insn); - -typedef struct AArch64DecodeTable { - uint32_t pattern; - uint32_t mask; - AArch64DecodeFn *disas_fn; -} AArch64DecodeTable; - /* initialize TCG globals. */ void a64_translate_init(void) {
We removed the old table-based decoder in favour of decodetree, but we left a couple of typedefs that are now unused; delete them. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- target/arm/tcg/translate-a64.c | 11 ----------- 1 file changed, 11 deletions(-)