| Message ID | 20250127102620.39159-9-philmd@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | target/ppc: Move TCG code from excp_helper.c to tcg-excp_helper.c | expand |
On 1/27/25 15:56, Philippe Mathieu-Daudé wrote: > Introduced in commit db789c6cd33 ("ppc: Provide basic > raise_exception_* functions"), raise_exception_ra() has > never been used. Remove as dead code. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> Although there are a bunch of raise_exception_err_ra calls passing error_code as 0, I hope removing this is fine as still unused. Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com> > --- > target/ppc/cpu.h | 2 -- > target/ppc/excp_helper.c | 6 ------ > 2 files changed, 8 deletions(-) > > diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h > index 0b8b4c05172..4ca27d6b389 100644 > --- a/target/ppc/cpu.h > +++ b/target/ppc/cpu.h > @@ -2753,8 +2753,6 @@ static inline void cpu_get_tb_cpu_state(CPUPPCState *env, vaddr *pc, > #endif > > G_NORETURN void raise_exception(CPUPPCState *env, uint32_t exception); > -G_NORETURN void raise_exception_ra(CPUPPCState *env, uint32_t exception, > - uintptr_t raddr); > G_NORETURN void raise_exception_err(CPUPPCState *env, uint32_t exception, > uint32_t error_code); > G_NORETURN void raise_exception_err_ra(CPUPPCState *env, uint32_t exception, > diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c > index 236e5078f56..9e1a2ecc36f 100644 > --- a/target/ppc/excp_helper.c > +++ b/target/ppc/excp_helper.c > @@ -2528,12 +2528,6 @@ void raise_exception(CPUPPCState *env, uint32_t exception) > raise_exception_err_ra(env, exception, 0, 0); > } > > -void raise_exception_ra(CPUPPCState *env, uint32_t exception, > - uintptr_t raddr) > -{ > - raise_exception_err_ra(env, exception, 0, raddr); > -} > - > #ifdef CONFIG_TCG > void helper_raise_exception_err(CPUPPCState *env, uint32_t exception, > uint32_t error_code)
On 28/1/25 10:46, Harsh Prateek Bora wrote: > > > On 1/27/25 15:56, Philippe Mathieu-Daudé wrote: >> Introduced in commit db789c6cd33 ("ppc: Provide basic >> raise_exception_* functions"), raise_exception_ra() has >> never been used. Remove as dead code. >> >> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > > Although there are a bunch of raise_exception_err_ra calls passing > error_code as 0, I hope removing this is fine as still unused. I dunno about error_code=0, where I'm suspicious is raddr=0, I'd expect raddr=GETPC(), but I haven't bothered to check yet. > > Reviewed-by: Harsh Prateek Bora <harshpb@linux.ibm.com> > >> --- >> target/ppc/cpu.h | 2 -- >> target/ppc/excp_helper.c | 6 ------ >> 2 files changed, 8 deletions(-)
diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h index 0b8b4c05172..4ca27d6b389 100644 --- a/target/ppc/cpu.h +++ b/target/ppc/cpu.h @@ -2753,8 +2753,6 @@ static inline void cpu_get_tb_cpu_state(CPUPPCState *env, vaddr *pc, #endif G_NORETURN void raise_exception(CPUPPCState *env, uint32_t exception); -G_NORETURN void raise_exception_ra(CPUPPCState *env, uint32_t exception, - uintptr_t raddr); G_NORETURN void raise_exception_err(CPUPPCState *env, uint32_t exception, uint32_t error_code); G_NORETURN void raise_exception_err_ra(CPUPPCState *env, uint32_t exception, diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c index 236e5078f56..9e1a2ecc36f 100644 --- a/target/ppc/excp_helper.c +++ b/target/ppc/excp_helper.c @@ -2528,12 +2528,6 @@ void raise_exception(CPUPPCState *env, uint32_t exception) raise_exception_err_ra(env, exception, 0, 0); } -void raise_exception_ra(CPUPPCState *env, uint32_t exception, - uintptr_t raddr) -{ - raise_exception_err_ra(env, exception, 0, raddr); -} - #ifdef CONFIG_TCG void helper_raise_exception_err(CPUPPCState *env, uint32_t exception, uint32_t error_code)
Introduced in commit db789c6cd33 ("ppc: Provide basic raise_exception_* functions"), raise_exception_ra() has never been used. Remove as dead code. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- target/ppc/cpu.h | 2 -- target/ppc/excp_helper.c | 6 ------ 2 files changed, 8 deletions(-)