| Message ID | 20250124105309.295769-2-quic_vdadhani@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support to load QUP SE firmware from | expand |
On 24/01/2025 11:53, Viken Dadhaniya wrote: > Document the 'firmware-name' property in the device tree bindings to > support loading SE (Serial Engine) firmware from the protocol driver, > allowing for more flexible firmware management. > > Co-developed-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com> > Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com> > Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com> > --- > Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml > index 7b031ef09669..3e029d4d6f58 100644 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml > @@ -54,6 +54,10 @@ properties: > > dma-coherent: true > > + firmware-name: > + $ref: /schemas/types.yaml#/definitions/string You work on outdated tree. Just look how other bindings are doing this. maxItems instead. Best regards, Krzysztof
On 1/24/2025 4:30 PM, Krzysztof Kozlowski wrote: > On 24/01/2025 11:53, Viken Dadhaniya wrote: >> Document the 'firmware-name' property in the device tree bindings to >> support loading SE (Serial Engine) firmware from the protocol driver, >> allowing for more flexible firmware management. >> >> Co-developed-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com> >> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com> >> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com> >> --- >> Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml >> index 7b031ef09669..3e029d4d6f58 100644 >> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml >> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml >> @@ -54,6 +54,10 @@ properties: >> >> dma-coherent: true >> >> + firmware-name: >> + $ref: /schemas/types.yaml#/definitions/string > > > You work on outdated tree. Just look how other bindings are doing this. > maxItems instead. > > > Best regards, > Krzysztof > Sure, Will update in next patch. Thanks Viken
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml index 7b031ef09669..3e029d4d6f58 100644 --- a/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml @@ -54,6 +54,10 @@ properties: dma-coherent: true + firmware-name: + $ref: /schemas/types.yaml#/definitions/string + description: Specify the name of the QUP firmware to load. + required: - compatible - reg @@ -135,6 +139,7 @@ examples: #address-cells = <2>; #size-cells = <2>; ranges; + firmware-name = "qcom/sa8775p/qupv3fw.elf"; i2c0: i2c@a94000 { compatible = "qcom,geni-i2c";