diff mbox series

i2c: imx-lpi2c: select CONFIG_I2C_SLAVE

Message ID 20250122064906.1220557-1-arnd@kernel.org
State New
Headers show
Series i2c: imx-lpi2c: select CONFIG_I2C_SLAVE | expand

Commit Message

Arnd Bergmann Jan. 22, 2025, 6:48 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

The addition of target mode causes a build failure when CONFIG_I2C_SLAVE
is turned off:

drivers/i2c/busses/i2c-imx-lpi2c.c:1273:10: error: 'const struct i2c_algorithm' has no member named 'reg_target'
 1273 |         .reg_target     = lpi2c_imx_register_target,
      |          ^~~~~~~~~~
drivers/i2c/busses/i2c-imx-lpi2c.c:1274:10: error: 'const struct i2c_algorithm' has no member named 'unreg_target'
 1274 |         .unreg_target   = lpi2c_imx_unregister_target,
      |          ^~~~~~~~~~~~

Select the Kconfig symbol like we do for other similar drivers.

Fixes: 1ee867e465c1 ("i2c: imx-lpi2c: add target mode support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/i2c/busses/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Carlos Song Jan. 24, 2025, 4:59 a.m. UTC | #1 
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The addition of target mode causes a build failure when CONFIG_I2C_SLAVE is
> turned off:
> 
> drivers/i2c/busses/i2c-imx-lpi2c.c:1273:10: error: 'const struct i2c_algorithm'
> has no member named 'reg_target'
>  1273 |         .reg_target     = lpi2c_imx_register_target,
>       |          ^~~~~~~~~~
> drivers/i2c/busses/i2c-imx-lpi2c.c:1274:10: error: 'const struct i2c_algorithm'
> has no member named 'unreg_target'
>  1274 |         .unreg_target   = lpi2c_imx_unregister_target,
>       |          ^~~~~~~~~~~~
> 
> Select the Kconfig symbol like we do for other similar drivers.
> 
> Fixes: 1ee867e465c1 ("i2c: imx-lpi2c: add target mode support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/i2c/busses/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index
> 3fb1fa8244fb..60736a2831ba 100644
> --- a/drivers/i2c/busses/Kconfig
> +++ b/drivers/i2c/busses/Kconfig
> @@ -756,6 +756,7 @@ config I2C_IMX
>  config I2C_IMX_LPI2C
>         tristate "IMX Low Power I2C interface"
>         depends on ARCH_MXC || COMPILE_TEST
> +       select I2C_SLAVE
>         help
>           Say Y here if you want to use the Low Power IIC bus controller
>           on the Freescale i.MX processors.
> --

Hi, Arnd

Thank you for very much for your fix!:) 

You may add my ack:
Acked-by: Carlos Song <carlos.song@nxp.com>

Best Regards
Carlos
> 2.39.5
diff mbox series

Patch

diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
index 3fb1fa8244fb..60736a2831ba 100644
--- a/drivers/i2c/busses/Kconfig
+++ b/drivers/i2c/busses/Kconfig
@@ -756,6 +756,7 @@  config I2C_IMX
 config I2C_IMX_LPI2C
 	tristate "IMX Low Power I2C interface"
 	depends on ARCH_MXC || COMPILE_TEST
+	select I2C_SLAVE
 	help
 	  Say Y here if you want to use the Low Power IIC bus controller
 	  on the Freescale i.MX processors.