| Message ID | 20250120141946.2690063-1-neeraj.sanjaykale@nxp.com |
|---|---|
| State | Accepted |
| Commit | 52f17be9931e5252a0f576528943f21a3c180fa6 |
| Headers | show |
| Series | [v1] Bluetooth: btnxpuart: Fix glitches seen in dual A2DP streaming | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=926954 ---Test result--- Test Summary: CheckPatch PENDING 0.21 seconds GitLint PENDING 0.21 seconds SubjectPrefix PASS 0.12 seconds BuildKernel PASS 24.58 seconds CheckAllWarning PASS 26.55 seconds CheckSparse PASS 30.31 seconds BuildKernel32 PASS 24.19 seconds TestRunnerSetup PASS 428.24 seconds TestRunner_l2cap-tester PASS 20.49 seconds TestRunner_iso-tester PASS 30.09 seconds TestRunner_bnep-tester PASS 4.88 seconds TestRunner_mgmt-tester FAIL 121.16 seconds TestRunner_rfcomm-tester PASS 7.64 seconds TestRunner_sco-tester PASS 9.47 seconds TestRunner_ioctl-tester PASS 8.00 seconds TestRunner_mesh-tester PASS 6.03 seconds TestRunner_smp-tester PASS 7.00 seconds TestRunner_userchan-tester PASS 5.01 seconds IncrementalBuild PENDING 0.65 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: TestRunner_mgmt-tester - FAIL Desc: Run mgmt-tester with test-runner Output: Total: 490, Passed: 484 (98.8%), Failed: 2, Not Run: 4 Failed Test Cases LL Privacy - Add Device 3 (AL is full) Failed 0.201 seconds LL Privacy - Set Flags 1 (Add to RL) Failed 0.131 seconds ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
Hello: This patch was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 20 Jan 2025 19:49:46 +0530 you wrote: > This fixes a regression caused by previous commit for fixing truncated > ACL data, which is causing some intermittent glitches when running two > A2DP streams. > > serdev_device_write_buf() is the root cause of the glitch, which is > reverted, and the TX work will continue to write until the queue is empty. > > [...] Here is the summary with links: - [v1] Bluetooth: btnxpuart: Fix glitches seen in dual A2DP streaming https://git.kernel.org/bluetooth/bluetooth-next/c/52f17be9931e You are awesome, thank you!
diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c index 1230045d78a5..aa5ec1d444a9 100644 --- a/drivers/bluetooth/btnxpuart.c +++ b/drivers/bluetooth/btnxpuart.c @@ -1381,13 +1381,12 @@ static void btnxpuart_tx_work(struct work_struct *work) while ((skb = nxp_dequeue(nxpdev))) { len = serdev_device_write_buf(serdev, skb->data, skb->len); - serdev_device_wait_until_sent(serdev, 0); hdev->stat.byte_tx += len; skb_pull(skb, len); if (skb->len > 0) { skb_queue_head(&nxpdev->txq, skb); - break; + continue; } switch (hci_skb_pkt_type(skb)) {
This fixes a regression caused by previous commit for fixing truncated ACL data, which is causing some intermittent glitches when running two A2DP streams. serdev_device_write_buf() is the root cause of the glitch, which is reverted, and the TX work will continue to write until the queue is empty. This change fixes both issues. No A2DP streaming glitches or truncated ACL data issue observed. Fixes: 8023dd220425 ("Bluetooth: btnxpuart: Fix driver sending truncated data") Fixes: 689ca16e5232 ("Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets") Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> --- drivers/bluetooth/btnxpuart.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)