| Message ID | 20250109-gpu-acd-v4-5-08a5efaf4a23@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v4,1/7] drm/msm/adreno: Add support for ACD | expand |
Hi Akhil,
kernel test robot noticed the following build warnings:
[auto build test WARNING on dbfac60febfa806abb2d384cb6441e77335d2799]
url: https://github.com/intel-lab-lkp/linux/commits/Akhil-P-Oommen/drm-msm-adreno-Add-support-for-ACD/20250109-044339
base: dbfac60febfa806abb2d384cb6441e77335d2799
patch link: https://lore.kernel.org/r/20250109-gpu-acd-v4-5-08a5efaf4a23%40quicinc.com
patch subject: [PATCH v4 5/7] dt-bindings: opp: Add v2-qcom-adreno vendor bindings
config: csky-randconfig-051-20250109 (https://download.01.org/0day-ci/archive/20250109/202501092058.5rRJ1ocm-lkp@intel.com/config)
compiler: csky-linux-gcc (GCC) 14.2.0
dtschema version: 2024.12.dev6+gc4da38d
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250109/202501092058.5rRJ1ocm-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501092058.5rRJ1ocm-lkp@intel.com/
All warnings (new ones prefixed by >>):
Documentation/devicetree/bindings/net/snps,dwmac.yaml: mac-mode: missing type definition
>> Warning: Duplicate compatible "operating-points-v2" found in schemas matching "$id":
http://devicetree.org/schemas/opp/opp-v2.yaml#
http://devicetree.org/schemas/opp/opp-v2-qcom-adreno.yaml#
On 1/9/2025 1:36 PM, Krzysztof Kozlowski wrote: > On Thu, Jan 09, 2025 at 02:10:01AM +0530, Akhil P Oommen wrote: >> Add a new schema which extends opp-v2 to support a new vendor specific >> property required for Adreno GPUs found in Qualcomm's SoCs. The new >> property called "qcom,opp-acd-level" carries a u32 value recommended >> for each opp needs to be shared to GMU during runtime. >> >> Also, update MAINTAINERS file include the new opp-v2-qcom-adreno.yaml. >> >> Cc: Rob Clark <robdclark@gmail.com> >> Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> >> --- >> .../bindings/opp/opp-v2-qcom-adreno.yaml | 97 ++++++++++++++++++++++ >> MAINTAINERS | 1 + >> 2 files changed, 98 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml >> new file mode 100644 >> index 000000000000..de1f7c6c4f0e >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml >> @@ -0,0 +1,97 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/opp/opp-v2-qcom-adreno.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Qualcomm Adreno compatible OPP supply >> + >> +description: >> + Adreno GPUs present in Qualcomm's Snapdragon chipsets uses an OPP specific >> + ACD related information tailored for the specific chipset. This binding >> + provides the information needed to describe such a hardware value. >> + >> +maintainers: >> + - Rob Clark <robdclark@gmail.com> >> + > > You need select: here. See bot's warnings and other schemas, like > primecell, how they do it. Somehow this error is not reproducible on my setup. I have upgraded both Dtschema (2024.11) and and yamllint. Anyway, could you please confirm if the below addition would be sufficient? select: required: - compatible properties: compatible: contains: const: operating-points-v2-adreno -Akhil > > Best regards, > Krzysztof >
On 09/01/2025 14:13, Akhil P Oommen wrote: > On 1/9/2025 1:36 PM, Krzysztof Kozlowski wrote: >> On Thu, Jan 09, 2025 at 02:10:01AM +0530, Akhil P Oommen wrote: >>> Add a new schema which extends opp-v2 to support a new vendor specific >>> property required for Adreno GPUs found in Qualcomm's SoCs. The new >>> property called "qcom,opp-acd-level" carries a u32 value recommended >>> for each opp needs to be shared to GMU during runtime. >>> >>> Also, update MAINTAINERS file include the new opp-v2-qcom-adreno.yaml. >>> >>> Cc: Rob Clark <robdclark@gmail.com> >>> Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> >>> --- >>> .../bindings/opp/opp-v2-qcom-adreno.yaml | 97 ++++++++++++++++++++++ >>> MAINTAINERS | 1 + >>> 2 files changed, 98 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml >>> new file mode 100644 >>> index 000000000000..de1f7c6c4f0e >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml >>> @@ -0,0 +1,97 @@ >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >>> +%YAML 1.2 >>> +--- >>> +$id: http://devicetree.org/schemas/opp/opp-v2-qcom-adreno.yaml# >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>> + >>> +title: Qualcomm Adreno compatible OPP supply >>> + >>> +description: >>> + Adreno GPUs present in Qualcomm's Snapdragon chipsets uses an OPP specific >>> + ACD related information tailored for the specific chipset. This binding >>> + provides the information needed to describe such a hardware value. >>> + >>> +maintainers: >>> + - Rob Clark <robdclark@gmail.com> >>> + >> >> You need select: here. See bot's warnings and other schemas, like >> primecell, how they do it. > > Somehow this error is not reproducible on my setup. I have upgraded both > Dtschema (2024.11) and and yamllint. You probably need to test all bindings, so skipping DT_SCHEMA_FILES > Anyway, could you please confirm if the below addition would be sufficient? > > select: > required: > - compatible > properties: > compatible: > contains: > const: operating-points-v2-adreno For this binding yes, but if the warning persist, then you might need to update operating-points-v2 as well, with a similar select but without "contains:". Best regards, Krzysztof
On 1/9/2025 2:10 AM, Akhil P Oommen wrote: > Add a new schema which extends opp-v2 to support a new vendor specific > property required for Adreno GPUs found in Qualcomm's SoCs. The new > property called "qcom,opp-acd-level" carries a u32 value recommended > for each opp needs to be shared to GMU during runtime. > > Also, update MAINTAINERS file include the new opp-v2-qcom-adreno.yaml. > > Cc: Rob Clark <robdclark@gmail.com> > Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> > --- > .../bindings/opp/opp-v2-qcom-adreno.yaml | 97 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 98 insertions(+) > > diff --git a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml > new file mode 100644 > index 000000000000..de1f7c6c4f0e > --- /dev/null > +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml > @@ -0,0 +1,97 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/opp/opp-v2-qcom-adreno.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Adreno compatible OPP supply > + > +description: > + Adreno GPUs present in Qualcomm's Snapdragon chipsets uses an OPP specific > + ACD related information tailored for the specific chipset. This binding > + provides the information needed to describe such a hardware value. > + > +maintainers: > + - Rob Clark <robdclark@gmail.com> > + > +allOf: > + - $ref: opp-v2-base.yaml# > + > +properties: > + compatible: > + items: > + - const: operating-points-v2-adreno > + - const: operating-points-v2 https://lore.kernel.org/all/173637143564.1057127.5997544431977689674.robh@kernel.org/ Krzysztof, sorry for the late response. I was checking further about the above bot error. AFAIU, we should not include "const: operating-points-v2" here, otherwise all opp tables compatible with "operating-points-v2" get matched with opp-v2-qcom-adreno.yaml during validation. So I am sending the v5 revision with the below fix: +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml @@ -19,9 +19,8 @@ allOf: properties: compatible: - items: - - const: operating-points-v2-adreno - - const: operating-points-v2 + contains: + const: operating-points-v2-adreno -Akhil. > + > +patternProperties: > + '^opp-[0-9]+$': > + type: object > + additionalProperties: false > + > + properties: > + opp-hz: true > + > + opp-level: true > + > + opp-peak-kBps: true > + > + opp-supported-hw: true > + > + qcom,opp-acd-level: > + description: | > + A positive value representing the ACD (Adaptive Clock Distribution, > + a fancy name for clk throttling during voltage droop) level associated > + with this OPP node. This value is shared to a co-processor inside GPU > + (called Graphics Management Unit a.k.a GMU) during wake up. It may not > + be present for some OPPs and GMU will disable ACD while transitioning > + to that OPP. This value encodes a voltage threshold, delay cycles & > + calibration margins which are identified by characterization of the > + SoC. So, it doesn't have any unit. This data is passed to GMU firmware > + via 'HFI_H2F_MSG_ACD' packet. > + $ref: /schemas/types.yaml#/definitions/uint32 > + > + required: > + - opp-hz > + - opp-level > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/power/qcom-rpmpd.h> > + > + gpu_opp_table: opp-table { > + compatible = "operating-points-v2-adreno", "operating-points-v2"; > + > + opp-687000000 { > + opp-hz = /bits/ 64 <687000000>; > + opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>; > + opp-peak-kBps = <8171875>; > + qcom,opp-acd-level = <0x882e5ffd>; > + }; > + > + opp-550000000 { > + opp-hz = /bits/ 64 <550000000>; > + opp-level = <RPMH_REGULATOR_LEVEL_SVS>; > + opp-peak-kBps = <6074219>; > + qcom,opp-acd-level = <0xc0285ffd>; > + }; > + > + opp-390000000 { > + opp-hz = /bits/ 64 <390000000>; > + opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS>; > + opp-peak-kBps = <3000000>; > + qcom,opp-acd-level = <0xc0285ffd>; > + }; > + > + opp-300000000 { > + opp-hz = /bits/ 64 <300000000>; > + opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D1>; > + opp-peak-kBps = <2136719>; > + /* Intentionally left out qcom,opp-acd-level property here */ > + }; > + > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 910305c11e8a..f7119623e1f3 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -7292,6 +7292,7 @@ S: Maintained > B: https://gitlab.freedesktop.org/drm/msm/-/issues > T: git https://gitlab.freedesktop.org/drm/msm.git > F: Documentation/devicetree/bindings/display/msm/gpu.yaml > +F: Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml > F: drivers/gpu/drm/msm/adreno/ > F: drivers/gpu/drm/msm/msm_gpu.* > F: drivers/gpu/drm/msm/msm_gpu_devfreq.* >
On Sat, Apr 19, 2025 at 08:03:35PM +0530, Akhil P Oommen wrote: > On 1/9/2025 2:10 AM, Akhil P Oommen wrote: > > Add a new schema which extends opp-v2 to support a new vendor specific > > property required for Adreno GPUs found in Qualcomm's SoCs. The new > > property called "qcom,opp-acd-level" carries a u32 value recommended > > for each opp needs to be shared to GMU during runtime. > > > > Also, update MAINTAINERS file include the new opp-v2-qcom-adreno.yaml. > > > > Cc: Rob Clark <robdclark@gmail.com> > > Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> > > --- > > .../bindings/opp/opp-v2-qcom-adreno.yaml | 97 ++++++++++++++++++++++ > > MAINTAINERS | 1 + > > 2 files changed, 98 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml > > new file mode 100644 > > index 000000000000..de1f7c6c4f0e > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml > > @@ -0,0 +1,97 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/opp/opp-v2-qcom-adreno.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Qualcomm Adreno compatible OPP supply > > + > > +description: > > + Adreno GPUs present in Qualcomm's Snapdragon chipsets uses an OPP specific > > + ACD related information tailored for the specific chipset. This binding > > + provides the information needed to describe such a hardware value. > > + > > +maintainers: > > + - Rob Clark <robdclark@gmail.com> > > + > > +allOf: > > + - $ref: opp-v2-base.yaml# > > + > > +properties: > > + compatible: > > + items: > > + - const: operating-points-v2-adreno > > + - const: operating-points-v2 > > https://lore.kernel.org/all/173637143564.1057127.5997544431977689674.robh@kernel.org/ > > Krzysztof, sorry for the late response. I was checking further about the > above bot error. AFAIU, we should not include "const: > operating-points-v2" here, otherwise all opp tables compatible with > "operating-points-v2" get matched with opp-v2-qcom-adreno.yaml during > validation. So I am sending the v5 revision with the below fix: This is not quite correct. The table is compatible with op-v2. Instead you should add 'select:' clause which will limit the cases where this schema gets selected. > > +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml > @@ -19,9 +19,8 @@ allOf: > > properties: > compatible: > - items: > - - const: operating-points-v2-adreno > - - const: operating-points-v2 > + contains: > + const: operating-points-v2-adreno > > -Akhil. >
diff --git a/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml new file mode 100644 index 000000000000..de1f7c6c4f0e --- /dev/null +++ b/Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml @@ -0,0 +1,97 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/opp/opp-v2-qcom-adreno.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Adreno compatible OPP supply + +description: + Adreno GPUs present in Qualcomm's Snapdragon chipsets uses an OPP specific + ACD related information tailored for the specific chipset. This binding + provides the information needed to describe such a hardware value. + +maintainers: + - Rob Clark <robdclark@gmail.com> + +allOf: + - $ref: opp-v2-base.yaml# + +properties: + compatible: + items: + - const: operating-points-v2-adreno + - const: operating-points-v2 + +patternProperties: + '^opp-[0-9]+$': + type: object + additionalProperties: false + + properties: + opp-hz: true + + opp-level: true + + opp-peak-kBps: true + + opp-supported-hw: true + + qcom,opp-acd-level: + description: | + A positive value representing the ACD (Adaptive Clock Distribution, + a fancy name for clk throttling during voltage droop) level associated + with this OPP node. This value is shared to a co-processor inside GPU + (called Graphics Management Unit a.k.a GMU) during wake up. It may not + be present for some OPPs and GMU will disable ACD while transitioning + to that OPP. This value encodes a voltage threshold, delay cycles & + calibration margins which are identified by characterization of the + SoC. So, it doesn't have any unit. This data is passed to GMU firmware + via 'HFI_H2F_MSG_ACD' packet. + $ref: /schemas/types.yaml#/definitions/uint32 + + required: + - opp-hz + - opp-level + +required: + - compatible + +additionalProperties: false + +examples: + - | + #include <dt-bindings/power/qcom-rpmpd.h> + + gpu_opp_table: opp-table { + compatible = "operating-points-v2-adreno", "operating-points-v2"; + + opp-687000000 { + opp-hz = /bits/ 64 <687000000>; + opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>; + opp-peak-kBps = <8171875>; + qcom,opp-acd-level = <0x882e5ffd>; + }; + + opp-550000000 { + opp-hz = /bits/ 64 <550000000>; + opp-level = <RPMH_REGULATOR_LEVEL_SVS>; + opp-peak-kBps = <6074219>; + qcom,opp-acd-level = <0xc0285ffd>; + }; + + opp-390000000 { + opp-hz = /bits/ 64 <390000000>; + opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS>; + opp-peak-kBps = <3000000>; + qcom,opp-acd-level = <0xc0285ffd>; + }; + + opp-300000000 { + opp-hz = /bits/ 64 <300000000>; + opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D1>; + opp-peak-kBps = <2136719>; + /* Intentionally left out qcom,opp-acd-level property here */ + }; + + }; diff --git a/MAINTAINERS b/MAINTAINERS index 910305c11e8a..f7119623e1f3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7292,6 +7292,7 @@ S: Maintained B: https://gitlab.freedesktop.org/drm/msm/-/issues T: git https://gitlab.freedesktop.org/drm/msm.git F: Documentation/devicetree/bindings/display/msm/gpu.yaml +F: Documentation/devicetree/bindings/opp/opp-v2-qcom-adreno.yaml F: drivers/gpu/drm/msm/adreno/ F: drivers/gpu/drm/msm/msm_gpu.* F: drivers/gpu/drm/msm/msm_gpu_devfreq.*
Add a new schema which extends opp-v2 to support a new vendor specific property required for Adreno GPUs found in Qualcomm's SoCs. The new property called "qcom,opp-acd-level" carries a u32 value recommended for each opp needs to be shared to GMU during runtime. Also, update MAINTAINERS file include the new opp-v2-qcom-adreno.yaml. Cc: Rob Clark <robdclark@gmail.com> Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com> --- .../bindings/opp/opp-v2-qcom-adreno.yaml | 97 ++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 98 insertions(+)