| Message ID | 20250103233407.4001046-1-gwendal@chromium.org |
|---|---|
| State | New |
| Headers | show |
| Series | driver/platform/chrome: Update cros_ec_trace with new USCI commands | expand |
Hi Gwendal,
kernel test robot noticed the following build errors:
[auto build test ERROR on chrome-platform/for-next]
[also build test ERROR on linus/master v6.13-rc5 next-20241220]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Gwendal-Grignou/driver-platform-chrome-Update-cros_ec_trace-with-new-USCI-commands/20250104-073614
base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
patch link: https://lore.kernel.org/r/20250103233407.4001046-1-gwendal%40chromium.org
patch subject: [PATCH] driver/platform/chrome: Update cros_ec_trace with new USCI commands
config: i386-buildonly-randconfig-002-20250104 (https://download.01.org/0day-ci/archive/20250104/202501041541.ZbA4mnNs-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250104/202501041541.ZbA4mnNs-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501041541.ZbA4mnNs-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/trace/define_trace.h:113,
from drivers/platform/chrome/cros_ec_trace.h:83,
from drivers/platform/chrome/cros_ec_trace.c:217:
drivers/platform/chrome/./cros_ec_trace.h: In function 'trace_raw_output_cros_ec_request_start':
>> drivers/platform/chrome/cros_ec_trace.c:169:22: error: 'EC_CMD_UCSI_PPM_SET' undeclared (first use in this function); did you mean 'EC_CMD_GPIO_SET'?
169 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_SET), \
| ^~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:219:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
219 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
drivers/platform/chrome/./cros_ec_trace.h:21:1: note: in expansion of macro 'TRACE_EVENT'
21 | TRACE_EVENT(cros_ec_request_start,
| ^~~~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:38:9: note: in expansion of macro 'TP_printk'
38 | TP_printk("version: %u, offset: %d, command: %s, outsize: %u, insize: %u",
| ^~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:40:19: note: in expansion of macro '__print_symbolic'
40 | __print_symbolic(__entry->command, EC_CMDS),
| ^~~~~~~~~~~~~~~~
drivers/platform/chrome/cros_ec_trace.c:169:9: note: in expansion of macro 'TRACE_SYMBOL'
169 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_SET), \
| ^~~~~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:40:54: note: in expansion of macro 'EC_CMDS'
40 | __print_symbolic(__entry->command, EC_CMDS),
| ^~~~~~~
drivers/platform/chrome/cros_ec_trace.c:169:22: note: each undeclared identifier is reported only once for each function it appears in
169 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_SET), \
| ^~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:219:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
219 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
drivers/platform/chrome/./cros_ec_trace.h:21:1: note: in expansion of macro 'TRACE_EVENT'
21 | TRACE_EVENT(cros_ec_request_start,
| ^~~~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:38:9: note: in expansion of macro 'TP_printk'
38 | TP_printk("version: %u, offset: %d, command: %s, outsize: %u, insize: %u",
| ^~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:40:19: note: in expansion of macro '__print_symbolic'
40 | __print_symbolic(__entry->command, EC_CMDS),
| ^~~~~~~~~~~~~~~~
drivers/platform/chrome/cros_ec_trace.c:169:9: note: in expansion of macro 'TRACE_SYMBOL'
169 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_SET), \
| ^~~~~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:40:54: note: in expansion of macro 'EC_CMDS'
40 | __print_symbolic(__entry->command, EC_CMDS),
| ^~~~~~~
>> drivers/platform/chrome/cros_ec_trace.c:170:22: error: 'EC_CMD_UCSI_PPM_GET' undeclared (first use in this function); did you mean 'EC_CMD_GPIO_GET'?
170 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_GET), \
| ^~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:219:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
219 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
drivers/platform/chrome/./cros_ec_trace.h:21:1: note: in expansion of macro 'TRACE_EVENT'
21 | TRACE_EVENT(cros_ec_request_start,
| ^~~~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:38:9: note: in expansion of macro 'TP_printk'
38 | TP_printk("version: %u, offset: %d, command: %s, outsize: %u, insize: %u",
| ^~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:40:19: note: in expansion of macro '__print_symbolic'
40 | __print_symbolic(__entry->command, EC_CMDS),
| ^~~~~~~~~~~~~~~~
drivers/platform/chrome/cros_ec_trace.c:170:9: note: in expansion of macro 'TRACE_SYMBOL'
170 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_GET), \
| ^~~~~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:40:54: note: in expansion of macro 'EC_CMDS'
40 | __print_symbolic(__entry->command, EC_CMDS),
| ^~~~~~~
drivers/platform/chrome/./cros_ec_trace.h: In function 'trace_raw_output_cros_ec_request_done':
>> drivers/platform/chrome/cros_ec_trace.c:169:22: error: 'EC_CMD_UCSI_PPM_SET' undeclared (first use in this function); did you mean 'EC_CMD_GPIO_SET'?
169 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_SET), \
| ^~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:219:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
219 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
drivers/platform/chrome/./cros_ec_trace.h:44:1: note: in expansion of macro 'TRACE_EVENT'
44 | TRACE_EVENT(cros_ec_request_done,
| ^~~~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:65:9: note: in expansion of macro 'TP_printk'
65 | TP_printk("version: %u, offset: %d, command: %s, outsize: %u, insize: %u, ec result: %s, retval: %u",
| ^~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:67:19: note: in expansion of macro '__print_symbolic'
67 | __print_symbolic(__entry->command, EC_CMDS),
| ^~~~~~~~~~~~~~~~
drivers/platform/chrome/cros_ec_trace.c:169:9: note: in expansion of macro 'TRACE_SYMBOL'
169 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_SET), \
| ^~~~~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:67:54: note: in expansion of macro 'EC_CMDS'
67 | __print_symbolic(__entry->command, EC_CMDS),
| ^~~~~~~
>> drivers/platform/chrome/cros_ec_trace.c:170:22: error: 'EC_CMD_UCSI_PPM_GET' undeclared (first use in this function); did you mean 'EC_CMD_GPIO_GET'?
170 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_GET), \
| ^~~~~~~~~~~~~~~~~~~
include/trace/trace_events.h:219:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
219 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
drivers/platform/chrome/./cros_ec_trace.h:44:1: note: in expansion of macro 'TRACE_EVENT'
44 | TRACE_EVENT(cros_ec_request_done,
| ^~~~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:65:9: note: in expansion of macro 'TP_printk'
65 | TP_printk("version: %u, offset: %d, command: %s, outsize: %u, insize: %u, ec result: %s, retval: %u",
| ^~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:67:19: note: in expansion of macro '__print_symbolic'
67 | __print_symbolic(__entry->command, EC_CMDS),
| ^~~~~~~~~~~~~~~~
drivers/platform/chrome/cros_ec_trace.c:170:9: note: in expansion of macro 'TRACE_SYMBOL'
170 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_GET), \
| ^~~~~~~~~~~~
drivers/platform/chrome/./cros_ec_trace.h:67:54: note: in expansion of macro 'EC_CMDS'
67 | __print_symbolic(__entry->command, EC_CMDS),
| ^~~~~~~
vim +169 drivers/platform/chrome/cros_ec_trace.c
7
8 // Generate the list using the following script:
9 // sed -n 's/^#define \(EC_CMD_[[:alnum:]_]*\)\s.*/\tTRACE_SYMBOL(\1), \\/p' include/linux/platform_data/cros_ec_commands.h
10 #define EC_CMDS \
11 TRACE_SYMBOL(EC_CMD_ACPI_READ), \
12 TRACE_SYMBOL(EC_CMD_ACPI_WRITE), \
13 TRACE_SYMBOL(EC_CMD_ACPI_BURST_ENABLE), \
14 TRACE_SYMBOL(EC_CMD_ACPI_BURST_DISABLE), \
15 TRACE_SYMBOL(EC_CMD_ACPI_QUERY_EVENT), \
16 TRACE_SYMBOL(EC_CMD_PROTO_VERSION), \
17 TRACE_SYMBOL(EC_CMD_HELLO), \
18 TRACE_SYMBOL(EC_CMD_GET_VERSION), \
19 TRACE_SYMBOL(EC_CMD_READ_TEST), \
20 TRACE_SYMBOL(EC_CMD_GET_BUILD_INFO), \
21 TRACE_SYMBOL(EC_CMD_GET_CHIP_INFO), \
22 TRACE_SYMBOL(EC_CMD_GET_BOARD_VERSION), \
23 TRACE_SYMBOL(EC_CMD_READ_MEMMAP), \
24 TRACE_SYMBOL(EC_CMD_GET_CMD_VERSIONS), \
25 TRACE_SYMBOL(EC_CMD_GET_COMMS_STATUS), \
26 TRACE_SYMBOL(EC_CMD_TEST_PROTOCOL), \
27 TRACE_SYMBOL(EC_CMD_GET_PROTOCOL_INFO), \
28 TRACE_SYMBOL(EC_CMD_GSV_PAUSE_IN_S5), \
29 TRACE_SYMBOL(EC_CMD_GET_FEATURES), \
30 TRACE_SYMBOL(EC_CMD_GET_SKU_ID), \
31 TRACE_SYMBOL(EC_CMD_SET_SKU_ID), \
32 TRACE_SYMBOL(EC_CMD_FLASH_INFO), \
33 TRACE_SYMBOL(EC_CMD_FLASH_READ), \
34 TRACE_SYMBOL(EC_CMD_FLASH_WRITE), \
35 TRACE_SYMBOL(EC_CMD_FLASH_ERASE), \
36 TRACE_SYMBOL(EC_CMD_FLASH_PROTECT), \
37 TRACE_SYMBOL(EC_CMD_FLASH_REGION_INFO), \
38 TRACE_SYMBOL(EC_CMD_VBNV_CONTEXT), \
39 TRACE_SYMBOL(EC_CMD_FLASH_SPI_INFO), \
40 TRACE_SYMBOL(EC_CMD_FLASH_SELECT), \
41 TRACE_SYMBOL(EC_CMD_PWM_GET_FAN_TARGET_RPM), \
42 TRACE_SYMBOL(EC_CMD_PWM_SET_FAN_TARGET_RPM), \
43 TRACE_SYMBOL(EC_CMD_PWM_GET_KEYBOARD_BACKLIGHT), \
44 TRACE_SYMBOL(EC_CMD_PWM_SET_KEYBOARD_BACKLIGHT), \
45 TRACE_SYMBOL(EC_CMD_PWM_SET_FAN_DUTY), \
46 TRACE_SYMBOL(EC_CMD_PWM_SET_DUTY), \
47 TRACE_SYMBOL(EC_CMD_PWM_GET_DUTY), \
48 TRACE_SYMBOL(EC_CMD_LIGHTBAR_CMD), \
49 TRACE_SYMBOL(EC_CMD_LED_CONTROL), \
50 TRACE_SYMBOL(EC_CMD_VBOOT_HASH), \
51 TRACE_SYMBOL(EC_CMD_MOTION_SENSE_CMD), \
52 TRACE_SYMBOL(EC_CMD_FORCE_LID_OPEN), \
53 TRACE_SYMBOL(EC_CMD_CONFIG_POWER_BUTTON), \
54 TRACE_SYMBOL(EC_CMD_USB_CHARGE_SET_MODE), \
55 TRACE_SYMBOL(EC_CMD_PSTORE_INFO), \
56 TRACE_SYMBOL(EC_CMD_PSTORE_READ), \
57 TRACE_SYMBOL(EC_CMD_PSTORE_WRITE), \
58 TRACE_SYMBOL(EC_CMD_RTC_GET_VALUE), \
59 TRACE_SYMBOL(EC_CMD_RTC_GET_ALARM), \
60 TRACE_SYMBOL(EC_CMD_RTC_SET_VALUE), \
61 TRACE_SYMBOL(EC_CMD_RTC_SET_ALARM), \
62 TRACE_SYMBOL(EC_CMD_PORT80_LAST_BOOT), \
63 TRACE_SYMBOL(EC_CMD_PORT80_READ), \
64 TRACE_SYMBOL(EC_CMD_VSTORE_INFO), \
65 TRACE_SYMBOL(EC_CMD_VSTORE_READ), \
66 TRACE_SYMBOL(EC_CMD_VSTORE_WRITE), \
67 TRACE_SYMBOL(EC_CMD_THERMAL_SET_THRESHOLD), \
68 TRACE_SYMBOL(EC_CMD_THERMAL_GET_THRESHOLD), \
69 TRACE_SYMBOL(EC_CMD_THERMAL_AUTO_FAN_CTRL), \
70 TRACE_SYMBOL(EC_CMD_TMP006_GET_CALIBRATION), \
71 TRACE_SYMBOL(EC_CMD_TMP006_SET_CALIBRATION), \
72 TRACE_SYMBOL(EC_CMD_TMP006_GET_RAW), \
73 TRACE_SYMBOL(EC_CMD_MKBP_STATE), \
74 TRACE_SYMBOL(EC_CMD_MKBP_INFO), \
75 TRACE_SYMBOL(EC_CMD_MKBP_SIMULATE_KEY), \
76 TRACE_SYMBOL(EC_CMD_GET_KEYBOARD_ID), \
77 TRACE_SYMBOL(EC_CMD_MKBP_SET_CONFIG), \
78 TRACE_SYMBOL(EC_CMD_MKBP_GET_CONFIG), \
79 TRACE_SYMBOL(EC_CMD_KEYSCAN_SEQ_CTRL), \
80 TRACE_SYMBOL(EC_CMD_GET_NEXT_EVENT), \
81 TRACE_SYMBOL(EC_CMD_KEYBOARD_FACTORY_TEST), \
82 TRACE_SYMBOL(EC_CMD_TEMP_SENSOR_GET_INFO), \
83 TRACE_SYMBOL(EC_CMD_HOST_EVENT_GET_B), \
84 TRACE_SYMBOL(EC_CMD_HOST_EVENT_GET_SMI_MASK), \
85 TRACE_SYMBOL(EC_CMD_HOST_EVENT_GET_SCI_MASK), \
86 TRACE_SYMBOL(EC_CMD_HOST_EVENT_GET_WAKE_MASK), \
87 TRACE_SYMBOL(EC_CMD_HOST_EVENT_SET_SMI_MASK), \
88 TRACE_SYMBOL(EC_CMD_HOST_EVENT_SET_SCI_MASK), \
89 TRACE_SYMBOL(EC_CMD_HOST_EVENT_CLEAR), \
90 TRACE_SYMBOL(EC_CMD_HOST_EVENT_SET_WAKE_MASK), \
91 TRACE_SYMBOL(EC_CMD_HOST_EVENT_CLEAR_B), \
92 TRACE_SYMBOL(EC_CMD_HOST_EVENT), \
93 TRACE_SYMBOL(EC_CMD_SWITCH_ENABLE_BKLIGHT), \
94 TRACE_SYMBOL(EC_CMD_SWITCH_ENABLE_WIRELESS), \
95 TRACE_SYMBOL(EC_CMD_GPIO_SET), \
96 TRACE_SYMBOL(EC_CMD_GPIO_GET), \
97 TRACE_SYMBOL(EC_CMD_I2C_READ), \
98 TRACE_SYMBOL(EC_CMD_I2C_WRITE), \
99 TRACE_SYMBOL(EC_CMD_CHARGE_CONTROL), \
100 TRACE_SYMBOL(EC_CMD_CONSOLE_SNAPSHOT), \
101 TRACE_SYMBOL(EC_CMD_CONSOLE_READ), \
102 TRACE_SYMBOL(EC_CMD_BATTERY_CUT_OFF), \
103 TRACE_SYMBOL(EC_CMD_USB_MUX), \
104 TRACE_SYMBOL(EC_CMD_LDO_SET), \
105 TRACE_SYMBOL(EC_CMD_LDO_GET), \
106 TRACE_SYMBOL(EC_CMD_POWER_INFO), \
107 TRACE_SYMBOL(EC_CMD_I2C_PASSTHRU), \
108 TRACE_SYMBOL(EC_CMD_HANG_DETECT), \
109 TRACE_SYMBOL(EC_CMD_CHARGE_STATE), \
110 TRACE_SYMBOL(EC_CMD_CHARGE_CURRENT_LIMIT), \
111 TRACE_SYMBOL(EC_CMD_EXTERNAL_POWER_LIMIT), \
112 TRACE_SYMBOL(EC_CMD_OVERRIDE_DEDICATED_CHARGER_LIMIT), \
113 TRACE_SYMBOL(EC_CMD_HIBERNATION_DELAY), \
114 TRACE_SYMBOL(EC_CMD_HOST_SLEEP_EVENT), \
115 TRACE_SYMBOL(EC_CMD_DEVICE_EVENT), \
116 TRACE_SYMBOL(EC_CMD_SB_READ_WORD), \
117 TRACE_SYMBOL(EC_CMD_SB_WRITE_WORD), \
118 TRACE_SYMBOL(EC_CMD_SB_READ_BLOCK), \
119 TRACE_SYMBOL(EC_CMD_SB_WRITE_BLOCK), \
120 TRACE_SYMBOL(EC_CMD_BATTERY_VENDOR_PARAM), \
121 TRACE_SYMBOL(EC_CMD_SB_FW_UPDATE), \
122 TRACE_SYMBOL(EC_CMD_ENTERING_MODE), \
123 TRACE_SYMBOL(EC_CMD_I2C_PASSTHRU_PROTECT), \
124 TRACE_SYMBOL(EC_CMD_CEC_WRITE_MSG), \
125 TRACE_SYMBOL(EC_CMD_CEC_SET), \
126 TRACE_SYMBOL(EC_CMD_CEC_GET), \
127 TRACE_SYMBOL(EC_CMD_EC_CODEC), \
128 TRACE_SYMBOL(EC_CMD_EC_CODEC_DMIC), \
129 TRACE_SYMBOL(EC_CMD_EC_CODEC_I2S_RX), \
130 TRACE_SYMBOL(EC_CMD_EC_CODEC_WOV), \
131 TRACE_SYMBOL(EC_CMD_REBOOT_EC), \
132 TRACE_SYMBOL(EC_CMD_GET_PANIC_INFO), \
133 TRACE_SYMBOL(EC_CMD_REBOOT), \
134 TRACE_SYMBOL(EC_CMD_RESEND_RESPONSE), \
135 TRACE_SYMBOL(EC_CMD_VERSION0), \
136 TRACE_SYMBOL(EC_CMD_PD_EXCHANGE_STATUS), \
137 TRACE_SYMBOL(EC_CMD_PD_HOST_EVENT_STATUS), \
138 TRACE_SYMBOL(EC_CMD_USB_PD_CONTROL), \
139 TRACE_SYMBOL(EC_CMD_USB_PD_PORTS), \
140 TRACE_SYMBOL(EC_CMD_USB_PD_POWER_INFO), \
141 TRACE_SYMBOL(EC_CMD_CHARGE_PORT_COUNT), \
142 TRACE_SYMBOL(EC_CMD_USB_PD_FW_UPDATE), \
143 TRACE_SYMBOL(EC_CMD_USB_PD_RW_HASH_ENTRY), \
144 TRACE_SYMBOL(EC_CMD_USB_PD_DEV_INFO), \
145 TRACE_SYMBOL(EC_CMD_USB_PD_DISCOVERY), \
146 TRACE_SYMBOL(EC_CMD_PD_CHARGE_PORT_OVERRIDE), \
147 TRACE_SYMBOL(EC_CMD_PD_GET_LOG_ENTRY), \
148 TRACE_SYMBOL(EC_CMD_USB_PD_GET_AMODE), \
149 TRACE_SYMBOL(EC_CMD_USB_PD_SET_AMODE), \
150 TRACE_SYMBOL(EC_CMD_PD_WRITE_LOG_ENTRY), \
151 TRACE_SYMBOL(EC_CMD_PD_CONTROL), \
152 TRACE_SYMBOL(EC_CMD_USB_PD_MUX_INFO), \
153 TRACE_SYMBOL(EC_CMD_PD_CHIP_INFO), \
154 TRACE_SYMBOL(EC_CMD_RWSIG_CHECK_STATUS), \
155 TRACE_SYMBOL(EC_CMD_RWSIG_ACTION), \
156 TRACE_SYMBOL(EC_CMD_EFS_VERIFY), \
157 TRACE_SYMBOL(EC_CMD_GET_CROS_BOARD_INFO), \
158 TRACE_SYMBOL(EC_CMD_SET_CROS_BOARD_INFO), \
159 TRACE_SYMBOL(EC_CMD_GET_UPTIME_INFO), \
160 TRACE_SYMBOL(EC_CMD_ADD_ENTROPY), \
161 TRACE_SYMBOL(EC_CMD_ADC_READ), \
162 TRACE_SYMBOL(EC_CMD_ROLLBACK_INFO), \
163 TRACE_SYMBOL(EC_CMD_AP_RESET), \
164 TRACE_SYMBOL(EC_CMD_REGULATOR_GET_INFO), \
165 TRACE_SYMBOL(EC_CMD_REGULATOR_ENABLE), \
166 TRACE_SYMBOL(EC_CMD_REGULATOR_IS_ENABLED), \
167 TRACE_SYMBOL(EC_CMD_REGULATOR_SET_VOLTAGE), \
168 TRACE_SYMBOL(EC_CMD_REGULATOR_GET_VOLTAGE), \
> 169 TRACE_SYMBOL(EC_CMD_UCSI_PPM_SET), \
> 170 TRACE_SYMBOL(EC_CMD_UCSI_PPM_GET), \
171 TRACE_SYMBOL(EC_CMD_CR51_BASE), \
172 TRACE_SYMBOL(EC_CMD_CR51_LAST), \
173 TRACE_SYMBOL(EC_CMD_FP_PASSTHRU), \
174 TRACE_SYMBOL(EC_CMD_FP_MODE), \
175 TRACE_SYMBOL(EC_CMD_FP_INFO), \
176 TRACE_SYMBOL(EC_CMD_FP_FRAME), \
177 TRACE_SYMBOL(EC_CMD_FP_TEMPLATE), \
178 TRACE_SYMBOL(EC_CMD_FP_CONTEXT), \
179 TRACE_SYMBOL(EC_CMD_FP_STATS), \
180 TRACE_SYMBOL(EC_CMD_FP_SEED), \
181 TRACE_SYMBOL(EC_CMD_FP_ENC_STATUS), \
182 TRACE_SYMBOL(EC_CMD_TP_SELF_TEST), \
183 TRACE_SYMBOL(EC_CMD_TP_FRAME_INFO), \
184 TRACE_SYMBOL(EC_CMD_TP_FRAME_SNAPSHOT), \
185 TRACE_SYMBOL(EC_CMD_TP_FRAME_GET), \
186 TRACE_SYMBOL(EC_CMD_BATTERY_GET_STATIC), \
187 TRACE_SYMBOL(EC_CMD_BATTERY_GET_DYNAMIC), \
188 TRACE_SYMBOL(EC_CMD_CHARGER_CONTROL), \
189 TRACE_SYMBOL(EC_CMD_BOARD_SPECIFIC_BASE), \
190 TRACE_SYMBOL(EC_CMD_BOARD_SPECIFIC_LAST)
191
On Fri, Jan 03, 2025 at 03:34:07PM -0800, Gwendal Grignou wrote: > Add this patch to "platform/chrome: Update ChromeOS EC header for UCSI" I do not understand this changelog text, sorry. How can you "add" something to an existing change? > to add the new commands form cros_ec_commands.h in the tracer so that > they are nicely decoded. Enable the tracer with: > cd /sys/kernel/debug/tracing > echo 1 > events/cros_ec/enable > echo 1 > tracing_on > cat trace_pipe We don't need to document how to enable a tracepoint here in the changelog, right? That's going to get lost and why is this new one somehow special? confused, greg k-h
Hi Gwendal, kernel test robot noticed the following build errors: [auto build test ERROR on chrome-platform/for-next] [also build test ERROR on chrome-platform/for-firmware-next linus/master v6.13-rc5 next-20241220] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Gwendal-Grignou/driver-platform-chrome-Update-cros_ec_trace-with-new-USCI-commands/20250104-073614 base: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next patch link: https://lore.kernel.org/r/20250103233407.4001046-1-gwendal%40chromium.org patch subject: [PATCH] driver/platform/chrome: Update cros_ec_trace with new USCI commands config: x86_64-buildonly-randconfig-005-20250104 (https://download.01.org/0day-ci/archive/20250105/202501050055.oR3g1RHJ-lkp@intel.com/config) compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250105/202501050055.oR3g1RHJ-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202501050055.oR3g1RHJ-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from drivers/platform/chrome/cros_ec_trace.c:217: In file included from drivers/platform/chrome/cros_ec_trace.h:83: In file included from include/trace/define_trace.h:113: In file included from include/trace/trace_events.h:256: >> drivers/platform/chrome/cros_ec_trace.h:40:40: error: use of undeclared identifier 'EC_CMD_UCSI_PPM_SET' 40 | __print_symbolic(__entry->command, EC_CMDS), | ^ drivers/platform/chrome/cros_ec_trace.c:169:15: note: expanded from macro 'EC_CMDS' 169 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_SET), \ | ^ In file included from drivers/platform/chrome/cros_ec_trace.c:217: In file included from drivers/platform/chrome/cros_ec_trace.h:83: In file included from include/trace/define_trace.h:113: In file included from include/trace/trace_events.h:256: >> drivers/platform/chrome/cros_ec_trace.h:40:40: error: use of undeclared identifier 'EC_CMD_UCSI_PPM_GET' drivers/platform/chrome/cros_ec_trace.c:170:15: note: expanded from macro 'EC_CMDS' 170 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_GET), \ | ^ In file included from drivers/platform/chrome/cros_ec_trace.c:217: In file included from drivers/platform/chrome/cros_ec_trace.h:83: In file included from include/trace/define_trace.h:113: In file included from include/trace/trace_events.h:256: drivers/platform/chrome/cros_ec_trace.h:67:40: error: use of undeclared identifier 'EC_CMD_UCSI_PPM_SET' 67 | __print_symbolic(__entry->command, EC_CMDS), | ^ drivers/platform/chrome/cros_ec_trace.c:169:15: note: expanded from macro 'EC_CMDS' 169 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_SET), \ | ^ In file included from drivers/platform/chrome/cros_ec_trace.c:217: In file included from drivers/platform/chrome/cros_ec_trace.h:83: In file included from include/trace/define_trace.h:113: In file included from include/trace/trace_events.h:256: drivers/platform/chrome/cros_ec_trace.h:67:40: error: use of undeclared identifier 'EC_CMD_UCSI_PPM_GET' drivers/platform/chrome/cros_ec_trace.c:170:15: note: expanded from macro 'EC_CMDS' 170 | TRACE_SYMBOL(EC_CMD_UCSI_PPM_GET), \ | ^ 4 errors generated. vim +/EC_CMD_UCSI_PPM_SET +40 drivers/platform/chrome/cros_ec_trace.h 58a2109f6eb46b Raul E Rangel 2019-04-16 20 205c9326fd8665 Raul E Rangel 2019-11-25 21 TRACE_EVENT(cros_ec_request_start, 58a2109f6eb46b Raul E Rangel 2019-04-16 22 TP_PROTO(struct cros_ec_command *cmd), 58a2109f6eb46b Raul E Rangel 2019-04-16 23 TP_ARGS(cmd), 58a2109f6eb46b Raul E Rangel 2019-04-16 24 TP_STRUCT__entry( 58a2109f6eb46b Raul E Rangel 2019-04-16 25 __field(uint32_t, version) 8143182426874a Gwendal Grignou 2020-08-14 26 __field(uint32_t, offset) 58a2109f6eb46b Raul E Rangel 2019-04-16 27 __field(uint32_t, command) 8143182426874a Gwendal Grignou 2020-08-14 28 __field(uint32_t, outsize) 8143182426874a Gwendal Grignou 2020-08-14 29 __field(uint32_t, insize) 58a2109f6eb46b Raul E Rangel 2019-04-16 30 ), 58a2109f6eb46b Raul E Rangel 2019-04-16 31 TP_fast_assign( 58a2109f6eb46b Raul E Rangel 2019-04-16 32 __entry->version = cmd->version; 3db0c9e5de7bd9 Tzung-Bi Shih 2022-06-09 33 __entry->offset = cmd->command / EC_CMD_PASSTHRU_OFFSET(CROS_EC_DEV_PD_INDEX); 3db0c9e5de7bd9 Tzung-Bi Shih 2022-06-09 34 __entry->command = cmd->command % EC_CMD_PASSTHRU_OFFSET(CROS_EC_DEV_PD_INDEX); 8143182426874a Gwendal Grignou 2020-08-14 35 __entry->outsize = cmd->outsize; 8143182426874a Gwendal Grignou 2020-08-14 36 __entry->insize = cmd->insize; 58a2109f6eb46b Raul E Rangel 2019-04-16 37 ), 8143182426874a Gwendal Grignou 2020-08-14 38 TP_printk("version: %u, offset: %d, command: %s, outsize: %u, insize: %u", 8143182426874a Gwendal Grignou 2020-08-14 39 __entry->version, __entry->offset, 8143182426874a Gwendal Grignou 2020-08-14 @40 __print_symbolic(__entry->command, EC_CMDS), 8143182426874a Gwendal Grignou 2020-08-14 41 __entry->outsize, __entry->insize) 58a2109f6eb46b Raul E Rangel 2019-04-16 42 ); 58a2109f6eb46b Raul E Rangel 2019-04-16 43
diff --git a/drivers/platform/chrome/cros_ec_trace.c b/drivers/platform/chrome/cros_ec_trace.c index 425e9441b7ca5..ddc6adfb3897a 100644 --- a/drivers/platform/chrome/cros_ec_trace.c +++ b/drivers/platform/chrome/cros_ec_trace.c @@ -166,6 +166,8 @@ TRACE_SYMBOL(EC_CMD_REGULATOR_IS_ENABLED), \ TRACE_SYMBOL(EC_CMD_REGULATOR_SET_VOLTAGE), \ TRACE_SYMBOL(EC_CMD_REGULATOR_GET_VOLTAGE), \ + TRACE_SYMBOL(EC_CMD_UCSI_PPM_SET), \ + TRACE_SYMBOL(EC_CMD_UCSI_PPM_GET), \ TRACE_SYMBOL(EC_CMD_CR51_BASE), \ TRACE_SYMBOL(EC_CMD_CR51_LAST), \ TRACE_SYMBOL(EC_CMD_FP_PASSTHRU), \
Add this patch to "platform/chrome: Update ChromeOS EC header for UCSI" to add the new commands form cros_ec_commands.h in the tracer so that they are nicely decoded. Enable the tracer with: cd /sys/kernel/debug/tracing echo 1 > events/cros_ec/enable echo 1 > tracing_on cat trace_pipe Signed-off-by: Gwendal Grignou <gwendal@chromium.org> --- drivers/platform/chrome/cros_ec_trace.c | 2 ++ 1 file changed, 2 insertions(+)