| Message ID | 20250103111109.21609-1-hawkxiang.cpp@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | scsi: iscsi: special case for GET_HOST_STATS | expand |
On 1/3/25 5:11 AM, Xiang Zhang wrote: > Special case for ISCSI_UEVENT_GET_HOST_STATS: > - On success: send reply and stats from iscsi_get_host_stats() > within if_recv_msg(). > - On error: fall through. Could you add a line about what is being fixed? The above info describes how you fixed it. > > Signed-off-by: Xiang Zhang <hawkxiang.cpp@gmail.com> > --- > drivers/scsi/scsi_transport_iscsi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c > index fde7de3b1e55..ad4186da1cb4 100644 > --- a/drivers/scsi/scsi_transport_iscsi.c > +++ b/drivers/scsi/scsi_transport_iscsi.c > @@ -4113,6 +4113,8 @@ iscsi_if_rx(struct sk_buff *skb) Patch looks correct, but could you update the code comment right above this line so it mentions ISCSI_UEVENT_GET_STATS and ISCSI_UEVENT_GET_HOST_STATS. > break; > if (ev->type == ISCSI_UEVENT_GET_CHAP && !err) > break; > + if (ev->type == ISCSI_UEVENT_GET_HOST_STATS && !err) > + break; > err = iscsi_if_send_reply(portid, nlh->nlmsg_type, > ev, sizeof(*ev)); > if (err == -EAGAIN && --retries < 0) {
diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c index fde7de3b1e55..ad4186da1cb4 100644 --- a/drivers/scsi/scsi_transport_iscsi.c +++ b/drivers/scsi/scsi_transport_iscsi.c @@ -4113,6 +4113,8 @@ iscsi_if_rx(struct sk_buff *skb) break; if (ev->type == ISCSI_UEVENT_GET_CHAP && !err) break; + if (ev->type == ISCSI_UEVENT_GET_HOST_STATS && !err) + break; err = iscsi_if_send_reply(portid, nlh->nlmsg_type, ev, sizeof(*ev)); if (err == -EAGAIN && --retries < 0) {
Special case for ISCSI_UEVENT_GET_HOST_STATS: - On success: send reply and stats from iscsi_get_host_stats() within if_recv_msg(). - On error: fall through. Signed-off-by: Xiang Zhang <hawkxiang.cpp@gmail.com> --- drivers/scsi/scsi_transport_iscsi.c | 2 ++ 1 file changed, 2 insertions(+)