| Message ID | 20250103230446.197597-5-s-ramamoorthy@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add TI TPS65215 PMIC Regulator Support | expand |
Hi Shree,
kernel test robot noticed the following build errors:
[auto build test ERROR on broonie-regulator/for-next]
[also build test ERROR on next-20241220]
[cannot apply to robh/for-next tmlind-omap/for-next linus/master v6.13-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Shree-Ramamoorthy/regulator-dt-bindings-Add-TI-TPS65215-PMIC-bindings/20250104-070914
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
patch link: https://lore.kernel.org/r/20250103230446.197597-5-s-ramamoorthy%40ti.com
patch subject: [PATCH v2 4/7] regulator: tps65215: Add chip_data struct for multi-PMIC support
config: i386-buildonly-randconfig-004-20250104 (https://download.01.org/0day-ci/archive/20250104/202501041724.qQwuHm5z-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250104/202501041724.qQwuHm5z-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202501041724.qQwuHm5z-lkp@intel.com/
All errors (new ones prefixed by >>):
drivers/regulator/tps65219-regulator.c:266:44: error: 'TPS65215_LDO_2' undeclared here (not in a function); did you mean 'TPS65219_LDO_2'?
266 | TPS65219_REGULATOR("LDO2", "ldo2", TPS65215_LDO_2,
| ^~~~~~~~~~~~~~
drivers/regulator/tps65219-regulator.c:104:43: note: in definition of macro 'TPS65219_REGULATOR'
104 | .id = _id, \
| ^~~
drivers/regulator/tps65219-regulator.c:268:28: error: 'TPS65215_REG_LDO2_VOUT' undeclared here (not in a function); did you mean 'TPS65219_REG_LDO2_VOUT'?
268 | TPS65215_REG_LDO2_VOUT,
| ^~~~~~~~~~~~~~~~~~~~~~
drivers/regulator/tps65219-regulator.c:109:43: note: in definition of macro 'TPS65219_REGULATOR'
109 | .vsel_reg = _vr, \
| ^~~
drivers/regulator/tps65219-regulator.c:271:28: error: 'TPS65215_ENABLE_LDO2_EN_MASK' undeclared here (not in a function); did you mean 'TPS65219_ENABLE_LDO2_EN_MASK'?
271 | TPS65215_ENABLE_LDO2_EN_MASK, 0, 0, tps65215_ldo_2_range,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/regulator/tps65219-regulator.c:116:43: note: in definition of macro 'TPS65219_REGULATOR'
116 | .enable_mask = _em, \
| ^~~
>> drivers/regulator/tps65219-regulator.c:330:10: error: 'TPS65215' undeclared here (not in a function); did you mean 'TPS65219'?
330 | [TPS65215] = {
| ^~~~~~~~
| TPS65219
>> drivers/regulator/tps65219-regulator.c:330:10: error: array index in initializer not of integer type
drivers/regulator/tps65219-regulator.c:330:10: note: (near initialization for 'chip_info_table')
In file included from include/linux/kernel.h:16,
from drivers/regulator/tps65219-regulator.c:13:
drivers/regulator/tps65219-regulator.c: In function 'tps65219_regulator_probe':
drivers/regulator/tps65219-regulator.c:365:36: error: 'regulators' undeclared (first use in this function); did you mean 'regulator'?
365 | for (i = 0; i < ARRAY_SIZE(regulators); i++) {
| ^~~~~~~~~~
include/linux/array_size.h:11:33: note: in definition of macro 'ARRAY_SIZE'
11 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
| ^~~
drivers/regulator/tps65219-regulator.c:365:36: note: each undeclared identifier is reported only once for each function it appears in
365 | for (i = 0; i < ARRAY_SIZE(regulators); i++) {
| ^~~~~~~~~~
include/linux/array_size.h:11:33: note: in definition of macro 'ARRAY_SIZE'
11 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
| ^~~
In file included from include/linux/array_size.h:5:
include/linux/compiler.h:245:77: error: expression in static assertion is not an integer
245 | #define __BUILD_BUG_ON_ZERO_MSG(e, msg) ((int)sizeof(struct {_Static_assert(!(e), msg);}))
| ^
include/linux/compiler.h:249:33: note: in expansion of macro '__BUILD_BUG_ON_ZERO_MSG'
249 | #define __must_be_array(a) __BUILD_BUG_ON_ZERO_MSG(__same_type((a), &(a)[0]), "must be array")
| ^~~~~~~~~~~~~~~~~~~~~~~
include/linux/array_size.h:11:59: note: in expansion of macro '__must_be_array'
11 | #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))
| ^~~~~~~~~~~~~~~
drivers/regulator/tps65219-regulator.c:365:25: note: in expansion of macro 'ARRAY_SIZE'
365 | for (i = 0; i < ARRAY_SIZE(regulators); i++) {
| ^~~~~~~~~~
drivers/regulator/tps65219-regulator.c: At top level:
drivers/regulator/tps65219-regulator.c:329:34: warning: 'chip_info_table' defined but not used [-Wunused-variable]
329 | static struct tps65219_chip_data chip_info_table[] = {
| ^~~~~~~~~~~~~~~
vim +330 drivers/regulator/tps65219-regulator.c
328
329 static struct tps65219_chip_data chip_info_table[] = {
> 330 [TPS65215] = {
331 .rdesc = tps65215_regs,
332 .rdesc_size = ARRAY_SIZE(tps65215_regs),
333 .common_rdesc = common_regs,
334 .common_rdesc_size = ARRAY_SIZE(common_regs),
335 .common_irq_types = common_regulator_irq_types,
336 .common_irq_size = ARRAY_SIZE(common_regulator_irq_types),
337 },
338 [TPS65219] = {
339 .rdesc = tps65219_regs,
340 .rdesc_size = ARRAY_SIZE(tps65219_regs),
341 .common_rdesc = common_regs,
342 .common_rdesc_size = ARRAY_SIZE(common_regs),
343 .common_irq_types = common_regulator_irq_types,
344 .common_irq_size = ARRAY_SIZE(common_regulator_irq_types),
345 .irq_types = tps65219_regulator_irq_types,
346 .dev_irq_size = ARRAY_SIZE(tps65219_regulator_irq_types),
347 },
348 };
349
diff --git a/drivers/regulator/tps65219-regulator.c b/drivers/regulator/tps65219-regulator.c index eddb22d0758a..30928f1f216f 100644 --- a/drivers/regulator/tps65219-regulator.c +++ b/drivers/regulator/tps65219-regulator.c @@ -1,4 +1,5 @@ // SPDX-License-Identifier: GPL-2.0 + // // Regulator driver for TPS65215/TPS65219 PMIC // @@ -314,6 +315,38 @@ static irqreturn_t tps65219_regulator_irq_handler(int irq, void *data) return IRQ_HANDLED; } +struct tps65219_chip_data { + size_t common_irq_size; + size_t rdesc_size; + size_t common_rdesc_size; + size_t dev_irq_size; + const struct regulator_desc *rdesc; + const struct regulator_desc *common_rdesc; + struct tps65219_regulator_irq_type *irq_types; + struct tps65219_regulator_irq_type *common_irq_types; +}; + +static struct tps65219_chip_data chip_info_table[] = { + [TPS65215] = { + .rdesc = tps65215_regs, + .rdesc_size = ARRAY_SIZE(tps65215_regs), + .common_rdesc = common_regs, + .common_rdesc_size = ARRAY_SIZE(common_regs), + .common_irq_types = common_regulator_irq_types, + .common_irq_size = ARRAY_SIZE(common_regulator_irq_types), + }, + [TPS65219] = { + .rdesc = tps65219_regs, + .rdesc_size = ARRAY_SIZE(tps65219_regs), + .common_rdesc = common_regs, + .common_rdesc_size = ARRAY_SIZE(common_regs), + .common_irq_types = common_regulator_irq_types, + .common_irq_size = ARRAY_SIZE(common_regulator_irq_types), + .irq_types = tps65219_regulator_irq_types, + .dev_irq_size = ARRAY_SIZE(tps65219_regulator_irq_types), + }, +}; + static int tps65219_regulator_probe(struct platform_device *pdev) { struct tps65219 *tps = dev_get_drvdata(pdev->dev.parent);
'chipid' will identify which PMIC to support, and the corresponding chip_data struct element to use in probe(). The chip_data struct is helpful for any new PMICs added to this driver. The goal is to add future PMIC info to necessary structs and minimize probe() function edits. Signed-off-by: Shree Ramamoorthy <s-ramamoorthy@ti.com> --- drivers/regulator/tps65219-regulator.c | 33 ++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)