| Message ID | 20250102141204.3413202-1-superm1@kernel.org |
|---|---|
| State | New |
| Headers | show |
| Series | cpufreq/amd-pstate: Fix prefcore rankings | expand |
On 1/2/2025 7:42 PM, Mario Limonciello wrote: > From: Mario Limonciello <mario.limonciello@amd.com> > > commit 50a062a76200 ("cpufreq/amd-pstate: Store the boost numerator as > highest perf again") updated the value stored for highest perf to no longer > store the highest perf value but instead the boost numerator. > > This is a fixed value for systems with preferred cores and not appropriate > for use ITMT rankings. Update the value used for ITMT rankings to be the > preferred core ranking. Looks good to me, Reviewed-by: Dhananjay Ugwekar <dhananjay.ugwekar@amd.com> Thanks, Dhananjay > > Reported-and-tested-by: Sebastian <sobrus@gmail.com> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219640 > Fixes: 50a062a76200 ("cpufreq/amd-pstate: Store the boost numerator as highest perf again") > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> > --- > drivers/cpufreq/amd-pstate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c > index 66e5dfc711c0c..f6d04eb40af94 100644 > --- a/drivers/cpufreq/amd-pstate.c > +++ b/drivers/cpufreq/amd-pstate.c > @@ -802,7 +802,7 @@ static void amd_pstate_init_prefcore(struct amd_cpudata *cpudata) > * sched_set_itmt_support(true) has been called and it is valid to > * update them at any time after it has been called. > */ > - sched_set_itmt_core_prio((int)READ_ONCE(cpudata->highest_perf), cpudata->cpu); > + sched_set_itmt_core_prio((int)READ_ONCE(cpudata->prefcore_ranking), cpudata->cpu); > > schedule_work(&sched_prefcore_work); > }
diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c index 66e5dfc711c0c..f6d04eb40af94 100644 --- a/drivers/cpufreq/amd-pstate.c +++ b/drivers/cpufreq/amd-pstate.c @@ -802,7 +802,7 @@ static void amd_pstate_init_prefcore(struct amd_cpudata *cpudata) * sched_set_itmt_support(true) has been called and it is valid to * update them at any time after it has been called. */ - sched_set_itmt_core_prio((int)READ_ONCE(cpudata->highest_perf), cpudata->cpu); + sched_set_itmt_core_prio((int)READ_ONCE(cpudata->prefcore_ranking), cpudata->cpu); schedule_work(&sched_prefcore_work); }