diff mbox series

[v4,4/6] target/hppa: Only set PSW 'M' bit on reset

Message ID 20241231190620.24442-5-philmd@linaro.org
State New
Headers show
Series hppa CPU reset and speedup | expand

Commit Message

Philippe Mathieu-Daudé Dec. 31, 2024, 7:06 p.m. UTC
On reset:

  "All PSW bits except the M bit is reset. The M bit is set."

Commit 1a19da0da44 ("target/hppa: Fill in hppa_cpu_do_interrupt /
hppa_cpu_exec_interrupt") inadvertently set the W bit at RESET,
remove it and set the M bit.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 target/hppa/cpu.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Helge Deller Jan. 1, 2025, 4:24 p.m. UTC | #1
On 12/31/24 20:06, Philippe Mathieu-Daudé wrote:
> On reset:
>
>    "All PSW bits except the M bit is reset. The M bit is set."
>
> Commit 1a19da0da44 ("target/hppa: Fill in hppa_cpu_do_interrupt /
> hppa_cpu_exec_interrupt") inadvertently set the W bit at RESET,
> remove it and set the M bit.
>
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Acked-by: Helge Deller <deller@gmx.de>



> ---
>   target/hppa/cpu.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c
> index 41538d39d62..dbd46842841 100644
> --- a/target/hppa/cpu.c
> +++ b/target/hppa/cpu.c
> @@ -209,7 +209,7 @@ static void hppa_cpu_reset_hold(Object *obj, ResetType type)
>       memset(env, 0, offsetof(CPUHPPAState, end_reset_fields));
>
>       cpu_hppa_loaded_fr0(env);
> -    cpu_hppa_put_psw(env, PSW_W);
> +    cpu_hppa_put_psw(env, PSW_M);
>   }
>
>   static ObjectClass *hppa_cpu_class_by_name(const char *cpu_model)
diff mbox series

Patch

diff --git a/target/hppa/cpu.c b/target/hppa/cpu.c
index 41538d39d62..dbd46842841 100644
--- a/target/hppa/cpu.c
+++ b/target/hppa/cpu.c
@@ -209,7 +209,7 @@  static void hppa_cpu_reset_hold(Object *obj, ResetType type)
     memset(env, 0, offsetof(CPUHPPAState, end_reset_fields));
 
     cpu_hppa_loaded_fr0(env);
-    cpu_hppa_put_psw(env, PSW_W);
+    cpu_hppa_put_psw(env, PSW_M);
 }
 
 static ObjectClass *hppa_cpu_class_by_name(const char *cpu_model)