| Message ID | 20241223153453.12924-3-markus@notsyncing.net |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] input: touchscreen: ads7846: Use managed variant to get pendown GPIO | expand |
diff --git a/drivers/input/touchscreen/ads7846.c b/drivers/input/touchscreen/ads7846.c index 607f18af7010..212dafa0bba2 100644 --- a/drivers/input/touchscreen/ads7846.c +++ b/drivers/input/touchscreen/ads7846.c @@ -1011,7 +1011,7 @@ static int ads7846_setup_pendown(struct spi_device *spi, if (pdata->get_pendown_state) { ts->get_pendown_state = pdata->get_pendown_state; } else { - ts->gpio_pendown = gpiod_get(&spi->dev, "pendown", GPIOD_IN); + ts->gpio_pendown = devm_gpiod_get(&spi->dev, "pendown", GPIOD_IN); if (IS_ERR(ts->gpio_pendown)) { dev_err(&spi->dev, "failed to request pendown GPIO\n"); return PTR_ERR(ts->gpio_pendown);
Removing and re-probing the driver failed with an error to request the pendown GPIO because it is never released in the remove function. This patch replaces the original gpiod_get function call with the managed devm_gpiod_get variant, which automatically releases the GPIO when the module is unloaded. Signed-off-by: Markus Koch <markus@notsyncing.net> --- Tested on an IMX53-based platform. --- drivers/input/touchscreen/ads7846.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)