Message ID | 20241220130252.1903536-1-neeraj.sanjaykale@nxp.com |
---|---|
State | New |
Headers | show |
Series | [v1] Bluetooth: btnxpuart: Fix driver sending truncated data | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=919895 ---Test result--- Test Summary: CheckPatch PENDING 0.38 seconds GitLint PENDING 0.26 seconds SubjectPrefix PASS 0.08 seconds BuildKernel PASS 24.43 seconds CheckAllWarning PASS 26.94 seconds CheckSparse PASS 30.62 seconds BuildKernel32 PASS 24.63 seconds TestRunnerSetup PASS 435.86 seconds TestRunner_l2cap-tester PASS 20.55 seconds TestRunner_iso-tester PASS 30.13 seconds TestRunner_bnep-tester PASS 4.78 seconds TestRunner_mgmt-tester FAIL 122.19 seconds TestRunner_rfcomm-tester PASS 7.57 seconds TestRunner_sco-tester PASS 9.22 seconds TestRunner_ioctl-tester PASS 8.05 seconds TestRunner_mesh-tester PASS 5.95 seconds TestRunner_smp-tester PASS 6.97 seconds TestRunner_userchan-tester PASS 4.96 seconds IncrementalBuild PENDING 0.46 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: TestRunner_mgmt-tester - FAIL Desc: Run mgmt-tester with test-runner Output: Total: 490, Passed: 482 (98.4%), Failed: 4, Not Run: 4 Failed Test Cases LL Privacy - Add Device 2 (2 Devices to AL) Failed 0.161 seconds LL Privacy - Add Device 3 (AL is full) Failed 0.194 seconds LL Privacy - Set Flags 3 (2 Devices to RL) Failed 0.170 seconds LL Privacy - Start Discovery 1 (Disable RL) Failed 0.157 seconds ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
diff --git a/drivers/bluetooth/btnxpuart.c b/drivers/bluetooth/btnxpuart.c index 569f5b7d6e46..1230045d78a5 100644 --- a/drivers/bluetooth/btnxpuart.c +++ b/drivers/bluetooth/btnxpuart.c @@ -1381,6 +1381,7 @@ static void btnxpuart_tx_work(struct work_struct *work) while ((skb = nxp_dequeue(nxpdev))) { len = serdev_device_write_buf(serdev, skb->data, skb->len); + serdev_device_wait_until_sent(serdev, 0); hdev->stat.byte_tx += len; skb_pull(skb, len);
This fixes the apparent controller hang issue seen during stress test where the host sends a truncated payload, followed by HCI commands. The controller treats these HCI commands as a part of previously truncated payload, leading to command timeouts. Adding a serdev_device_wait_until_sent() call after serdev_device_write_buf() fixed the issue. Fixes: 689ca16e5232 ("Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets") Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@nxp.com> --- drivers/bluetooth/btnxpuart.c | 1 + 1 file changed, 1 insertion(+)