diff mbox series

HID: multitouch: Add quirk for Hantick 5288 touchpad

Message ID 20241216021801.22572-1-youwan@nfschina.com
State New
Headers show
Series HID: multitouch: Add quirk for Hantick 5288 touchpad | expand

Commit Message

Youwan Wang Dec. 16, 2024, 2:18 a.m. UTC 
This device sometimes doesn't send touch release signals when moving
from >=2 fingers to <2 fingers. Using MT_QUIRK_NOT_SEEN_MEANS_UP instead
of MT_QUIRK_ALWAYS_VALID makes sure that no touches become stuck.

Signed-off-by: Enze Xie <enze@nfschina.com>
Signed-off-by: Youwan Wang <youwan@nfschina.com>
---
 drivers/hid/hid-multitouch.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Jiri Kosina Jan. 9, 2025, 9:01 a.m. UTC | #1 
On Mon, 16 Dec 2024, Youwan Wang wrote:

> This device sometimes doesn't send touch release signals when moving
> from >=2 fingers to <2 fingers. Using MT_QUIRK_NOT_SEEN_MEANS_UP instead
> of MT_QUIRK_ALWAYS_VALID makes sure that no touches become stuck.
> 
> Signed-off-by: Enze Xie <enze@nfschina.com>
> Signed-off-by: Youwan Wang <youwan@nfschina.com>

Applied, thank you.
diff mbox series

Patch

diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
index 42c0bd9d2f31..82900857bfd8 100644
--- a/drivers/hid/hid-multitouch.c
+++ b/drivers/hid/hid-multitouch.c
@@ -2314,6 +2314,11 @@  static const struct hid_device_id mt_devices[] = {
 		HID_DEVICE(HID_BUS_ANY, HID_GROUP_ANY, USB_VENDOR_ID_SIS_TOUCH,
 			HID_ANY_ID) },
 
+	/* Hantick */
+	{ .driver_data = MT_CLS_NSMU,
+		HID_DEVICE(BUS_I2C, HID_GROUP_MULTITOUCH_WIN_8,
+			   I2C_VENDOR_ID_HANTICK, I2C_PRODUCT_ID_HANTICK_5288) },
+
 	/* Generic MT device */
 	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_MULTITOUCH, HID_ANY_ID, HID_ANY_ID) },