diff mbox series

[1/4] serial: sc16is7xx: add missing support for rs485 devicetree properties

Message ID 20241216191818.1553557-2-hugo@hugovil.com
State New
Headers show
Series [1/4] serial: sc16is7xx: add missing support for rs485 devicetree properties | expand

Commit Message

Hugo Villeneuve Dec. 16, 2024, 7:18 p.m. UTC 
From: Hugo Villeneuve <hvilleneuve@dimonoff.com>

Retrieve rs485 devicetree properties on registration of sc16is7xx ports in
case they are attached to an rs485 transceiver.

Reworked to fix conflicts when backporting to linux-5.15.y.

Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Reviewed-by: Lech Perczak <lech.perczak@camlingroup.com>
Tested-by: Lech Perczak <lech.perczak@camlingroup.com>
Link: https://lore.kernel.org/r/20230807214556.540627-7-hugo@hugovil.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
 drivers/tty/serial/sc16is7xx.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Hugo Villeneuve Dec. 18, 2024, 8:05 p.m. UTC | #1 
On Tue, 17 Dec 2024 07:41:32 +0100
Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:

> On Mon, Dec 16, 2024 at 02:18:15PM -0500, Hugo Villeneuve wrote:
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > 
> > Retrieve rs485 devicetree properties on registration of sc16is7xx ports in
> > case they are attached to an rs485 transceiver.
> > 
> > Reworked to fix conflicts when backporting to linux-5.15.y.
> > 
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> > Reviewed-by: Lech Perczak <lech.perczak@camlingroup.com>
> > Tested-by: Lech Perczak <lech.perczak@camlingroup.com>
> > Link: https://lore.kernel.org/r/20230807214556.540627-7-hugo@hugovil.com
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> I do not see any commit ids on this series matching up with what is in
> Linus's tree.  Please fix up and resend the series.

Ok will do. I will first submit only this patch to make sure my
submission follows the stable guidelines.

Hugo.
diff mbox series

Patch

diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index 692c14d7f7d1a..3d3f66563b73b 100644
--- a/drivers/tty/serial/sc16is7xx.c
+++ b/drivers/tty/serial/sc16is7xx.c
@@ -1307,6 +1307,10 @@  static int sc16is7xx_probe(struct device *dev,
 
 		mutex_init(&s->p[i].efr_lock);
 
+		ret = uart_get_rs485_mode(&s->p[i].port);
+		if (ret)
+			goto out_ports;
+
 		/* Disable all interrupts */
 		sc16is7xx_port_write(&s->p[i].port, SC16IS7XX_IER_REG, 0);
 		/* Disable TX/RX */