| Message ID | 20241216160514.56630-1-philmd@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | accel/tcg: Really restrict cpu_io_recompile() to system emulation | expand |
On 12/16/24 10:05, Philippe Mathieu-Daudé wrote: > Commit 38fc4b11e03 ("accel/tcg: Restrict cpu_io_recompile() to > system emulation") inadvertently restricted cpu_io_recompile() > to SoftMMU. Correct to restrict to system emulation. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > Based-on: <20241212185341.2857-11-philmd@linaro.org> > --- > accel/tcg/internal-target.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/accel/tcg/internal-target.h b/accel/tcg/internal-target.h > index 1cfa318dc6c..3ed81e740d3 100644 > --- a/accel/tcg/internal-target.h > +++ b/accel/tcg/internal-target.h > @@ -36,9 +36,9 @@ static inline void page_table_config_init(void) { } > void page_table_config_init(void); > #endif > > -#ifdef CONFIG_SOFTMMU > +#ifndef CONFIG_USER_ONLY > G_NORETURN void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr); > -#endif /* CONFIG_SOFTMMU */ > +#endif /* CONFIG_USER_ONLY */ > > /** > * tcg_req_mo: Reviewed-by: Richard Henderson <richard.henderson@linaro.org> r~
On 16/12/24 17:05, Philippe Mathieu-Daudé wrote: > Commit 38fc4b11e03 ("accel/tcg: Restrict cpu_io_recompile() to > system emulation") inadvertently restricted cpu_io_recompile() > to SoftMMU. Correct to restrict to system emulation. > > Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> > --- > Based-on: <20241212185341.2857-11-philmd@linaro.org> > --- > accel/tcg/internal-target.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch queued.
diff --git a/accel/tcg/internal-target.h b/accel/tcg/internal-target.h index 1cfa318dc6c..3ed81e740d3 100644 --- a/accel/tcg/internal-target.h +++ b/accel/tcg/internal-target.h @@ -36,9 +36,9 @@ static inline void page_table_config_init(void) { } void page_table_config_init(void); #endif -#ifdef CONFIG_SOFTMMU +#ifndef CONFIG_USER_ONLY G_NORETURN void cpu_io_recompile(CPUState *cpu, uintptr_t retaddr); -#endif /* CONFIG_SOFTMMU */ +#endif /* CONFIG_USER_ONLY */ /** * tcg_req_mo:
Commit 38fc4b11e03 ("accel/tcg: Restrict cpu_io_recompile() to system emulation") inadvertently restricted cpu_io_recompile() to SoftMMU. Correct to restrict to system emulation. Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org> --- Based-on: <20241212185341.2857-11-philmd@linaro.org> --- accel/tcg/internal-target.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)