| Message ID | 20241213094118.23647-1-chris.lu@mediatek.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Bluetooth: btmtk: add quirk to support HCI_QUIRK_SIMULTANEOUS_DISCOVERY | expand |
Dear Chris, Thank you for your patch. Am 13.12.24 um 10:41 schrieb Chris Lu: > Add quirk to support HCI_QUIRK_SIMULTANEOUS_DISCOVERY feature for MT79xx > series chipset. It’d be great if you elaborated. What is the problem. Why is a quirk needed? Is a firmware update going to fix it? > Signed-off-by: Chris Lu <chris.lu@mediatek.com> > --- > drivers/bluetooth/btmtk.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c > index 8a3f7c3fcfec..562d6ecf0b71 100644 > --- a/drivers/bluetooth/btmtk.c > +++ b/drivers/bluetooth/btmtk.c > @@ -1367,6 +1367,9 @@ int btmtk_usb_setup(struct hci_dev *hdev) > return err; > } > > + /* Apply common HCI quirks for MediaTek chipset */ > + set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks); > + The commit message only talks about MT79xx series chipset. The comment talks about all MediaTek chipsets. > hci_set_msft_opcode(hdev, 0xFD30); > hci_set_aosp_capable(hdev); Kind regards, Paul
Hi Paul, Thanks for your input, On Fri, 2024-12-13 at 10:46 +0100, Paul Menzel wrote: > External email : Please do not click links or open attachments until > you have verified the sender or the content. > > > Dear Chris, > > > Thank you for your patch. > > > Am 13.12.24 um 10:41 schrieb Chris Lu: > > Add quirk to support HCI_QUIRK_SIMULTANEOUS_DISCOVERY feature for > > MT79xx > > series chipset. > > It’d be great if you elaborated. What is the problem. Why is a quirk > needed? Is a firmware update going to fix it? This quirk is related to do BR/EDR inquiry and LE scan simultaneously. More detailed was described in hci.h. Due to requirement from customer and other chip vendors also enable HCI_QUIRK_SIMULTANEOUS_DISCOVERY, MediaTek upload this patch to enable the feature as well. There is no need to update firmware. > > > Signed-off-by: Chris Lu <chris.lu@mediatek.com> > > --- > > drivers/bluetooth/btmtk.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c > > index 8a3f7c3fcfec..562d6ecf0b71 100644 > > --- a/drivers/bluetooth/btmtk.c > > +++ b/drivers/bluetooth/btmtk.c > > @@ -1367,6 +1367,9 @@ int btmtk_usb_setup(struct hci_dev *hdev) > > return err; > > } > > > > + /* Apply common HCI quirks for MediaTek chipset */ > > + set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev- > > >quirks); > > + > > The commit message only talks about MT79xx series chipset. The > comment > talks about all MediaTek chipsets. I'll modify commit message to avoid ambiguity and upload another version. Thanks a lot, Chris Lu > > > hci_set_msft_opcode(hdev, 0xFD30); > > hci_set_aosp_capable(hdev); > > > Kind regards, > > Paul
diff --git a/drivers/bluetooth/btmtk.c b/drivers/bluetooth/btmtk.c index 8a3f7c3fcfec..562d6ecf0b71 100644 --- a/drivers/bluetooth/btmtk.c +++ b/drivers/bluetooth/btmtk.c @@ -1367,6 +1367,9 @@ int btmtk_usb_setup(struct hci_dev *hdev) return err; } + /* Apply common HCI quirks for MediaTek chipset */ + set_bit(HCI_QUIRK_SIMULTANEOUS_DISCOVERY, &hdev->quirks); + hci_set_msft_opcode(hdev, 0xFD30); hci_set_aosp_capable(hdev);
Add quirk to support HCI_QUIRK_SIMULTANEOUS_DISCOVERY feature for MT79xx series chipset. Signed-off-by: Chris Lu <chris.lu@mediatek.com> --- drivers/bluetooth/btmtk.c | 3 +++ 1 file changed, 3 insertions(+)