| Message ID | 20241206072057.1508459-3-quic_mdalam@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] arm64: dts: qcom: ipq5424: Add TRNG node | expand |
On 6.12.2024 8:20 AM, Md Sadre Alam wrote: > RNG hardware versions greater than 3.0 are Truly > Random Number Generators (TRNG). In IPQ95xx RNG > block is TRNG. Update the corresponding compatible > property to ensure the hardware block is registered > with the hw_random framework, which feeds the Linux > entropy pool. Line wrapping should be around 72 chars, this looks funny Please change the commit title to 'update TRNG compatible', as 'enable' implies the functionality is not present as of current. The latter part of the last sentence is misleading, as both compatibles do the same thing in the driver. Instead, put emphasis on the wrong compatible being used and the patch making sure the hardware is described properly, without functional changes. Same for patch 3 Konrad
On 12/13/2024 5:25 AM, Konrad Dybcio wrote: > On 6.12.2024 8:20 AM, Md Sadre Alam wrote: >> RNG hardware versions greater than 3.0 are Truly >> Random Number Generators (TRNG). In IPQ95xx RNG >> block is TRNG. Update the corresponding compatible >> property to ensure the hardware block is registered >> with the hw_random framework, which feeds the Linux >> entropy pool. > > Line wrapping should be around 72 chars, this looks funny Ok > > Please change the commit title to 'update TRNG compatible', as > 'enable' implies the functionality is not present as of current. Ok > > The latter part of the last sentence is misleading, as both > compatibles do the same thing in the driver. Instead, put emphasis > on the wrong compatible being used and the patch making sure the > hardware is described properly, without functional changes. Ok, will update in next revision. > > Same for patch 3 Ok > > Konrad
diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi index d1fd35ebc4a2..db1afa0d5422 100644 --- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi @@ -227,7 +227,7 @@ rpm_msg_ram: sram@60000 { }; rng: rng@e3000 { - compatible = "qcom,prng-ee"; + compatible = "qcom,trng"; reg = <0x000e3000 0x1000>; clocks = <&gcc GCC_PRNG_AHB_CLK>; clock-names = "core";
RNG hardware versions greater than 3.0 are Truly Random Number Generators (TRNG). In IPQ95xx RNG block is TRNG. Update the corresponding compatible property to ensure the hardware block is registered with the hw_random framework, which feeds the Linux entropy pool. Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com> --- arch/arm64/boot/dts/qcom/ipq9574.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)