| Message ID | 20241203203949.483774-2-richard.henderson@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | fpu: pickNaN follow ups | expand |
On 3/12/24 21:39, Richard Henderson wrote: > Now that float_status has a bunch of fp parameters, > it is easier to copy an existing structure than create > one from scratch. Begin by copying the structure that > corresponds to the FPSR and make only the adjustments > required for BFloat16 semantics. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/arm/tcg/vec_helper.c | 20 +++++++------------- > 1 file changed, 7 insertions(+), 13 deletions(-) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Tue, 3 Dec 2024 at 20:39, Richard Henderson <richard.henderson@linaro.org> wrote: > > Now that float_status has a bunch of fp parameters, > it is easier to copy an existing structure than create > one from scratch. Begin by copying the structure that > corresponds to the FPSR and make only the adjustments > required for BFloat16 semantics. > > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > --- > target/arm/tcg/vec_helper.c | 20 +++++++------------- > 1 file changed, 7 insertions(+), 13 deletions(-) Reviewed-by: Peter Maydell <peter.maydell@linaro.org> I missed this in my grep for places where we set up a float_status I think because it's the only place where we use a struct initializer in a way that isn't literally "float_status s = { ... }". But I did a wider grep and I think this is the only place I missed like that. thanks -- PMM
diff --git a/target/arm/tcg/vec_helper.c b/target/arm/tcg/vec_helper.c index e825d501a2..ad6f26545a 100644 --- a/target/arm/tcg/vec_helper.c +++ b/target/arm/tcg/vec_helper.c @@ -2813,25 +2813,19 @@ bool is_ebf(CPUARMState *env, float_status *statusp, float_status *oddstatusp) * no effect on AArch32 instructions. */ bool ebf = is_a64(env) && env->vfp.fpcr & FPCR_EBF; - *statusp = (float_status){ - .tininess_before_rounding = float_tininess_before_rounding, - .float_rounding_mode = float_round_to_odd_inf, - .flush_to_zero = true, - .flush_inputs_to_zero = true, - .default_nan_mode = true, - }; + + *statusp = env->vfp.fp_status; + set_default_nan_mode(true, statusp); if (ebf) { - float_status *fpst = &env->vfp.fp_status; - set_flush_to_zero(get_flush_to_zero(fpst), statusp); - set_flush_inputs_to_zero(get_flush_inputs_to_zero(fpst), statusp); - set_float_rounding_mode(get_float_rounding_mode(fpst), statusp); - /* EBF=1 needs to do a step with round-to-odd semantics */ *oddstatusp = *statusp; set_float_rounding_mode(float_round_to_odd, oddstatusp); + } else { + set_flush_to_zero(true, statusp); + set_flush_inputs_to_zero(true, statusp); + set_float_rounding_mode(float_round_to_odd_inf, statusp); } - return ebf; }
Now that float_status has a bunch of fp parameters, it is easier to copy an existing structure than create one from scratch. Begin by copying the structure that corresponds to the FPSR and make only the adjustments required for BFloat16 semantics. Signed-off-by: Richard Henderson <richard.henderson@linaro.org> --- target/arm/tcg/vec_helper.c | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-)