| Message ID | 20241125092146.1561901-2-yuji2.ishikawa@toshiba.co.jp |
|---|---|
| State | New |
| Headers | show |
| Series | Add Toshiba Visconti Video Input Interface driver | expand |
On 25/11/2024 10:21, Yuji Ishikawa wrote: > Adds the Device Tree binding documentation that allows to describe > the MIPI CSI-2 Receiver found in Toshiba Visconti SoCs. > > Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp> > Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> How newly added patch can have already Rb tag? Was this review really, really performed internally or you just satisfy some internal managers requirements and fake the stats? > --- > > Changelog v12: > - Newly add bindings for CSI2RX driver > > .../media/toshiba,visconti5-csi2rx.yaml | 104 ++++++++++++++++++ > 1 file changed, 104 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yaml > > diff --git a/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yaml b/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yaml > new file mode 100644 > index 000000000000..5488072bc82a > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yaml > @@ -0,0 +1,104 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/toshiba,visconti5-csi2rx.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Toshiba Visconti5 SoC MIPI CSI-2 receiver > + > +maintainers: > + - Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > + > +description: |- Drop |- > + Toshiba Visconti5 SoC MIPI CSI-2 receiver device receives MIPI CSI-2 video > + stream. Use with VIIF device. T.B.D > + > +properties: > + compatible: > + const: toshiba,visconti5-csi2rx Why this is called "RX"? Can you have a TX? I had impression that one cannot. > + > + reg: > + items: > + - description: Registers for CSI2 receiver control > + > + interrupts: > + items: > + - description: CSI2 Receiver Interrupt > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/$defs/port-base > + unevaluatedProperties: false > + description: > + Input port node, single endpoint describing the CSI-2 transmitter. > + > + properties: > + endpoint: > + $ref: video-interfaces.yaml# > + unevaluatedProperties: false > + > + properties: > + data-lanes: > + description: CSI2 receiver supports 1, 2, 3 or 4 data lanes > + minItems: 1 > + items: > + - const: 1 > + - const: 2 > + - const: 3 > + - const: 4 > + required: > + - data-lanes > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: > + Output port node, single endpoint describing the Visconti VIIF. > + > + required: > + - port@0 > + - port@1 > + > +required: > + - compatible > + - reg > + - interrupts > + - ports > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + > + soc { > + #address-cells = <2>; > + #size-cells = <2>; > + > + csi2rx@1c008000 { csi@ Node names should be generic. See also an explanation and list of examples (not exhaustive) in DT specification: https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: Tuesday, December 17, 2024 2:45 PM > To: ishikawa yuji(石川 悠司 ○ＲＤＣ□ＡＩＴＣ○ＥＡ開) > <yuji2.ishikawa@toshiba.co.jp>; laurent.pinchart@ideasonboard.com; > mchehab@kernel.org; robh@kernel.org; krzk+dt@kernel.org; > conor+dt@kernel.org; sakari.ailus@linux.intel.com; hverkuil-cisco@xs4all.nl; > iwamatsu nobuhiro(岩松 信洋 ○ＤＩＴＣ□ＤＩＴ○ＯＳＴ) > <nobuhiro1.iwamatsu@toshiba.co.jp> > Cc: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; devicetree@vger.kernel.org > Subject: Re: [PATCH v12 1/8] dt-bindings: media: platform: visconti: Add > Toshiba Visconti MIPI CSI-2 Receiver > > On 17/12/2024 00:57, yuji2.ishikawa@toshiba.co.jp wrote: > >> On 25/11/2024 10:21, Yuji Ishikawa wrote: > >>> Adds the Device Tree binding documentation that allows to describe > >>> the MIPI CSI-2 Receiver found in Toshiba Visconti SoCs. > >>> > >>> Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@toshiba.co.jp> > >>> Reviewed-by: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > >> > >> > >> How newly added patch can have already Rb tag? Was this review > >> really, really performed internally or you just satisfy some internal > >> managers requirements and fake the stats? > >> > > > > I added this Reviewed-by tag because the patch was reviewed internally. > > > What issues were identified by internal review, especially in the context of > bindings? > The review was insufficient. We discussed the splitting of drivers, but overlooked the schema. I should have been more careful not to add an inappropriate tag. I apologize for not understanding the attention and respect that should be given to the Reviewed-by tag. From now on, I will add the tag to reviews discussed in the open mailing list. > > > >>> --- > >>> > >>> Changelog v12: > >>> - Newly add bindings for CSI2RX driver > >>> > >>> .../media/toshiba,visconti5-csi2rx.yaml | 104 > >> ++++++++++++++++++ > >>> 1 file changed, 104 insertions(+) > >>> create mode 100644 > >>> Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yam > >>> l > >>> > >>> diff --git > >>> a/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.y > >>> am > >>> l > >>> b/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.y > >>> am > >>> l > >>> new file mode 100644 > >>> index 000000000000..5488072bc82a > >>> --- /dev/null > >>> +++ > b/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2 > >>> +++ rx > >>> +++ .yaml > >>> @@ -0,0 +1,104 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML > 1.2 > >>> +--- > >>> +$id: > >>> +http://devicetree.org/schemas/media/toshiba,visconti5-csi2rx.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: Toshiba Visconti5 SoC MIPI CSI-2 receiver > >>> + > >>> +maintainers: > >>> + - Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> > >>> + > >>> +description: |- > >> > >> Drop |- > >> > > > > I'll drop "|-" > > > >>> + Toshiba Visconti5 SoC MIPI CSI-2 receiver device receives MIPI > >>> + CSI-2 video stream. Use with VIIF device. T.B.D > >>> + > >>> +properties: > >>> + compatible: > >>> + const: toshiba,visconti5-csi2rx > >> > >> Why this is called "RX"? Can you have a TX? I had impression that one > cannot. > >> > > > > VIIF has only MIPI CSI2 receiver (CSI2RX). There's no TX for it. > > So this device cannot be anything else? Then drop rx. > I'll drop "rx". The new compatible string will be "toshiba,visconti5-csi2". I'll also update the name of bindings document file. > > Visconti also has VOIF (Video Output Interface) hardware which has MIPI > CSI2 (not DSI) transmitter (CSI2TX). > > Or this can be something else? Confusing. > VOIF has only TX. There's no RX for it. I just wanted to inform you that there is a node with similar name and function. Please forget about it. > > > Best regards, > Krzysztof Best regards, Yuji Ishikawa
diff --git a/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yaml b/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yaml new file mode 100644 index 000000000000..5488072bc82a --- /dev/null +++ b/Documentation/devicetree/bindings/media/toshiba,visconti5-csi2rx.yaml @@ -0,0 +1,104 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/media/toshiba,visconti5-csi2rx.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Toshiba Visconti5 SoC MIPI CSI-2 receiver + +maintainers: + - Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> + +description: |- + Toshiba Visconti5 SoC MIPI CSI-2 receiver device receives MIPI CSI-2 video + stream. Use with VIIF device. T.B.D + +properties: + compatible: + const: toshiba,visconti5-csi2rx + + reg: + items: + - description: Registers for CSI2 receiver control + + interrupts: + items: + - description: CSI2 Receiver Interrupt + + ports: + $ref: /schemas/graph.yaml#/properties/ports + + properties: + port@0: + $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false + description: + Input port node, single endpoint describing the CSI-2 transmitter. + + properties: + endpoint: + $ref: video-interfaces.yaml# + unevaluatedProperties: false + + properties: + data-lanes: + description: CSI2 receiver supports 1, 2, 3 or 4 data lanes + minItems: 1 + items: + - const: 1 + - const: 2 + - const: 3 + - const: 4 + required: + - data-lanes + + port@1: + $ref: /schemas/graph.yaml#/properties/port + description: + Output port node, single endpoint describing the Visconti VIIF. + + required: + - port@0 + - port@1 + +required: + - compatible + - reg + - interrupts + - ports + +additionalProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/interrupt-controller/irq.h> + + soc { + #address-cells = <2>; + #size-cells = <2>; + + csi2rx@1c008000 { + compatible = "toshiba,visconti5-csi2rx"; + reg = <0 0x1c008000 0 0x400>; + interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>; + + ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { + reg = <0>; + csi2rx_in0: endpoint { + data-lanes = <1 2>; + remote-endpoint = <&imx219_out0>; + }; + }; + port@1 { + reg = <1>; + csi2rx_out0: endpoint { + remote-endpoint = <&csi_in0>; + }; + }; + }; + }; + };