| Message ID | 20241122121459.134107-1-dheeraj.linuxdev@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [wireless-next] wifi: rtw88: Fix an unreachable code issue | expand |
diff --git a/drivers/net/wireless/realtek/rtw88/rtw8821a.c b/drivers/net/wireless/realtek/rtw88/rtw8821a.c index db242c9ad68f..c06ba7d615df 100644 --- a/drivers/net/wireless/realtek/rtw88/rtw8821a.c +++ b/drivers/net/wireless/realtek/rtw88/rtw8821a.c @@ -221,8 +221,6 @@ static void rtw8821a_iqk_tx_vdf_true(struct rtw_dev *rtwdev, u32 cal, /* Originally: if (~tx_fail) { * It looks like a typo, so make it more explicit. */ - tx_fail = false; - if (!tx_fail) { rtw_write32(rtwdev, REG_RFECTL_A, 0x02000000);
The error handling in rtw8821a_iqk_tx_vdf_true() contained unreachable code due to tx_fail being explicitly set to false before the error check. This prevented proper handling of failures and resulted in dead code. Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com> --- drivers/net/wireless/realtek/rtw88/rtw8821a.c | 2 -- 1 file changed, 2 deletions(-)